d6c01059a5
The V8 Inspector was sending an additional frame as part of async stack traces for async functions, which pointed to the first executed `await` in the async function. This is leaking an implementation detail of how (and more precisely when) the inspector decides to collect this stack trace. From the users perspective the async part of the stack trace is supposed to capture what happened _prior to the task_ - meaning in case of async functions: What lead to the execution of the async function. This is reflected by the fact that the DevTools front-end (and the V8 Inspector itself) performs post-processing on these async call stacks, removing the misleading top frame from it. But this post-processing is not applied consistently to all async stack traces (i.e. the Console message stack traces don't get this), and potentially also not applied consistently across consumers of the Chromium debugger backend. Instead the V8 Inspector now removes the top frame itself and thus reports `await` consistently with how other async tasks are reported to debugger front-ends. Note: This preserves backwards compatibility with old versions of devtools-frontend, which do post-processing (for the Call Stack) only on async stack traces marked with "async function", while we now mark these async stack traces with "await" instead (aligned with what the front-end is using as user visibile string anyways in the Call Stack section, and this matching will be updated in a separate follow up CL to look for "await" instead of "async function"). Before: https://imgur.com/kIrWcIc.png After: https://imgur.com/HvZGqiP Fixed: chromium:1254259 Bug: chromium:1229662 Change-Id: I57ce051a28892177b6b96221f083ae957f967e52 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3193535 Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Kim-Anh Tran <kimanh@chromium.org> Cr-Commit-Position: refs/heads/main@{#77157}
38 lines
604 B
Plaintext
38 lines
604 B
Plaintext
Checks that async stacks works for async/await
|
|
foo2 (test.js:15:2)
|
|
-- await --
|
|
test (test.js:24:8)
|
|
(anonymous) (expr.js:0:0)
|
|
|
|
foo2 (test.js:17:2)
|
|
-- await --
|
|
test (test.js:24:8)
|
|
(anonymous) (expr.js:0:0)
|
|
|
|
foo1 (test.js:9:2)
|
|
foo2 (test.js:18:8)
|
|
-- await --
|
|
test (test.js:24:8)
|
|
(anonymous) (expr.js:0:0)
|
|
|
|
foo1 (test.js:9:2)
|
|
-- Promise.then --
|
|
foo2 (test.js:19:43)
|
|
-- await --
|
|
test (test.js:24:8)
|
|
(anonymous) (expr.js:0:0)
|
|
|
|
foo2 (test.js:20:2)
|
|
-- await --
|
|
test (test.js:24:8)
|
|
(anonymous) (expr.js:0:0)
|
|
|
|
{
|
|
id : <messageId>
|
|
result : {
|
|
result : {
|
|
type : undefined
|
|
}
|
|
}
|
|
}
|