15cb3fde7d
Reason for revert: Didn't help... Original issue's description: > Revert of [debugger] do not restart frames that reference new.target for liveedit. (patchset #1 id:1 of https://codereview.chromium.org/1493363002/ ) > > Reason for revert: > [Sheriff] Speculative revert for https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/3225 > > Original issue's description: > > [debugger] do not restart frames that reference new.target for liveedit. > > > > R=mstarzinger@chromium.org > > > > Committed: https://crrev.com/6fca870240bdbb07a365189b5eb0c98fa65b3682 > > Cr-Commit-Position: refs/heads/master@{#32572} > > TBR=mstarzinger@chromium.org,yangguo@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/1a61dab34b9849f3f70a42ce69317e22758c53a1 > Cr-Commit-Position: refs/heads/master@{#32582} TBR=mstarzinger@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1492393003 Cr-Commit-Position: refs/heads/master@{#32587}
64 lines
1.5 KiB
JavaScript
64 lines
1.5 KiB
JavaScript
// Copyright 2015 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --expose-debug-as debug --allow-natives-syntax
|
|
|
|
// Test that live-editing a frame to introduce new.target fails.
|
|
|
|
Debug = debug.Debug
|
|
var calls = 0;
|
|
var exceptions = 0;
|
|
var results = [];
|
|
var replace_again;
|
|
|
|
eval(`
|
|
function LogNewTarget() {
|
|
calls++;
|
|
ReplaceOnce();
|
|
results.push(true);
|
|
}
|
|
`);
|
|
|
|
function Replace(fun, original, patch) {
|
|
%ExecuteInDebugContext(function() {
|
|
var change_log = [];
|
|
try {
|
|
var script = Debug.findScript(fun);
|
|
var patch_pos = script.source.indexOf(original);
|
|
Debug.LiveEdit.TestApi.ApplySingleChunkPatch(
|
|
script, patch_pos, original.length, patch, change_log);
|
|
} catch (e) {
|
|
assertEquals("BLOCKED_NO_NEW_TARGET_ON_RESTART",
|
|
change_log[0].functions_on_stack[0].replace_problem);
|
|
assertInstanceof(e, Debug.LiveEdit.Failure);
|
|
exceptions++;
|
|
}
|
|
});
|
|
}
|
|
|
|
function ReplaceOnce(x) {
|
|
if (replace_again) {
|
|
replace_again = false;
|
|
Replace(LogNewTarget, "true", "new.target");
|
|
}
|
|
}
|
|
|
|
function Revert() {
|
|
Replace(LogNewTarget, "new.target", "true");
|
|
}
|
|
|
|
replace_again = true;
|
|
ReplaceOnce();
|
|
new LogNewTarget();
|
|
Revert();
|
|
assertEquals(1, calls);
|
|
assertEquals(0, exceptions);
|
|
assertEquals([LogNewTarget], results);
|
|
|
|
replace_again = true;
|
|
new LogNewTarget();
|
|
assertEquals(2, calls); // No restarts
|
|
assertEquals(1, exceptions); // Replace failed.
|
|
assertEquals([LogNewTarget, true], results);
|