v8/test
Mythri A b61335513a [ic] Fix a bug in StoreOwnIC when storing NaN values
We use StoreOwnIC to initialize the object after creating a new object
with CreateObjectLiteral. CreateObjectLiteral stores kHoleNaNInt64
to indicate an uninitialized double field. When we actually try
to store a NaN value into that field later using StoreOwnIC, IC avoids
actually storing the new value since the existing value is "same as"
the value we try to write. The float comparison treats all NaNs as
equal. In this particular case, we should actually store the new value
since kHoleNaNInt64 value is used to represent an uninitialized field.

This cl just stores the new value even when the existing value is same
as the new value for double fields. The check is still required to
correctly track const fields.

Bug: chromium:1082293
Change-Id: Ib37061802f2403545cffa6d6fef08be074b0825d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2228886
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Commit-Queue: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#68167}
2020-06-04 09:35:22 +00:00
..
benchmarks [snapshot] Clear reconstructable data prior to d8 stress_snapshot run 2020-05-06 07:11:22 +00:00
cctest Reland "Set .name of anonymous functions on the RHS of logical assignment." 2020-06-03 23:14:58 +00:00
common [wasm] Add type immediate to RefNull and RefIsNull instructions 2020-06-03 13:27:27 +00:00
debugger [wasm] Add type immediate to RefNull and RefIsNull instructions 2020-06-03 13:27:27 +00:00
debugging [snapshot] Clear reconstructable data prior to d8 stress_snapshot run 2020-05-06 07:11:22 +00:00
fuzzer [wasm-simd][fuzzer] Add s128 bitwise ops 2020-06-03 17:58:48 +00:00
fuzzilli Integrate fuzzilli into v8 2020-06-03 09:53:24 +00:00
inspector [wasm][debug] Expose wasm function tables in scope view 2020-06-03 17:11:18 +00:00
intl Reland "Roll ICU from 65.1 to 67.1 & correct tests" 2020-06-03 22:28:33 +00:00
js-perf-test [js-perf-test] Benchmark for sloppy equality 2020-05-04 08:29:00 +00:00
memory
message [wasm] Add return value to the tracing of function calls 2020-06-03 13:59:28 +00:00
mjsunit [ic] Fix a bug in StoreOwnIC when storing NaN values 2020-06-04 09:35:22 +00:00
mkgrokdump [heap] Make ReadOnlySpace use bump pointer allocation 2020-06-03 11:59:37 +00:00
mozilla [snapshot] Clear reconstructable data prior to d8 stress_snapshot run 2020-05-06 07:11:22 +00:00
test262 Reland "Roll ICU from 65.1 to 67.1 & correct tests" 2020-06-03 22:28:33 +00:00
torque [torque] Generate better code when using & operator on bitfields 2020-05-22 21:59:06 +00:00
unittests [wasm] Remove anyref subtyping 2020-06-03 16:35:38 +00:00
wasm-api-tests [wasm] Add type immediate to RefNull and RefIsNull instructions 2020-06-03 13:27:27 +00:00
wasm-js [wasm] Update wasm spec tests 2020-05-25 07:59:57 +00:00
wasm-spec-tests [wasm] Remove anyref subtyping 2020-06-03 16:35:38 +00:00
webkit [snapshot] Clear reconstructable data prior to d8 stress_snapshot run 2020-05-06 07:11:22 +00:00
BUILD.gn Integrate fuzzilli into v8 2020-06-03 09:53:24 +00:00
OWNERS