b086cb7b9a
With lazy feedback allocation and bytecode flushing we need to call %PrepareFunctionForOptimize before we call %OptimizeFunctionOnNextCall/ %OptimizeOsr. This cl: 1. Adds an additional state in pending optimized table to check if the optimization was triggered manually. 2. Changes the compilation pipeline to delete the entry from pending optimized table only if the optimization was triggered through %OptimizeFunctionOnNextCall / %OptimizeOsr. 3. Adds a check to enforce %PrepareFunctionForOptimize was called. 4. Adds a new run-time flag to only check in the d8 test runner. We don't want this check enabled in other cases like clusterfuzz that doesn't ensure %PrepareFunctionForOptimize is called. Bug: v8:8394, v8:8801, v8:9183 Change-Id: I9ae2b2da812e313c746b6df0b2da864c2ed5de51 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1664810 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#62653}
76 lines
2.6 KiB
JavaScript
76 lines
2.6 KiB
JavaScript
// Copyright 2014 the V8 project authors. All rights reserved.
|
|
// Redistribution and use in source and binary forms, with or without
|
|
// modification, are permitted provided that the following conditions are
|
|
// met:
|
|
//
|
|
// * Redistributions of source code must retain the above copyright
|
|
// notice, this list of conditions and the following disclaimer.
|
|
// * Redistributions in binary form must reproduce the above
|
|
// copyright notice, this list of conditions and the following
|
|
// disclaimer in the documentation and/or other materials provided
|
|
// with the distribution.
|
|
// * Neither the name of Google Inc. nor the names of its
|
|
// contributors may be used to endorse or promote products derived
|
|
// from this software without specific prior written permission.
|
|
//
|
|
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
// Flags: --allow-natives-syntax --opt --no-always-opt
|
|
|
|
var calls = 0;
|
|
|
|
function callsFReceiver(o) {
|
|
return [].f.call(new Number(o.m), 1, 2, 3);
|
|
}
|
|
|
|
// For the HConstant
|
|
Array.prototype.f = function() {
|
|
calls++;
|
|
return +this;
|
|
};
|
|
|
|
|
|
var o1 = {m: 1};
|
|
var o2 = {a: 0, m:1};
|
|
|
|
%PrepareFunctionForOptimization(callsFReceiver);
|
|
var r1 = callsFReceiver(o1);
|
|
callsFReceiver(o1);
|
|
%OptimizeFunctionOnNextCall(callsFReceiver);
|
|
var r2 = callsFReceiver(o1);
|
|
assertOptimized(callsFReceiver);
|
|
callsFReceiver(o2);
|
|
assertUnoptimized(callsFReceiver);
|
|
|
|
%PrepareFunctionForOptimization(callsFReceiver);
|
|
var r3 = callsFReceiver(o1);
|
|
|
|
assertEquals(1, r1);
|
|
assertTrue(r1 === r2);
|
|
assertTrue(r2 === r3);
|
|
|
|
%OptimizeFunctionOnNextCall(callsFReceiver);
|
|
r1 = callsFReceiver(o1);
|
|
%PrepareFunctionForOptimization(callsFReceiver);
|
|
callsFReceiver(o1);
|
|
%OptimizeFunctionOnNextCall(callsFReceiver);
|
|
r2 = callsFReceiver(o1);
|
|
callsFReceiver(o2);
|
|
r3 = callsFReceiver(o1);
|
|
|
|
assertEquals(1, r1);
|
|
assertTrue(r1 === r2);
|
|
assertTrue(r2 === r3);
|
|
|
|
assertEquals(10, calls);
|