11926e6ecc
Each local ABT is logically for one page. We passed the space in to the constructor, but this is wrong because the space a page is in can change, e.g. for compaction pages. Instead, pass the page to the local ABT constructor and always get the space from this. To do this we need to push the AllocateLocalTracker() helper and friends down to Page, rather than its superclass MemoryChunk. Unfortunately, we need to keep ReleaseLocalTracker() on MemoryChunk even though only Pages can have local trackers, because we can't do virtual dispatch on MemoryChunk::ReleaseAllocatedMemory() which would allow us to clean up the tracker memory nicely for pages only. We also have to make sure we update external bytes accounting properly when swapping spaces, as in SemiSpace::Swap(). Change-Id: Iff02e41dd12a6b04a57fcc32f9e2b4f049fcbc24 Reviewed-on: https://chromium-review.googlesource.com/1107635 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#53930} |
||
---|---|---|
.. | ||
heap-tester.h | ||
heap-utils.cc | ||
heap-utils.h | ||
test-alloc.cc | ||
test-array-buffer-tracker.cc | ||
test-compaction.cc | ||
test-concurrent-marking.cc | ||
test-embedder-tracing.cc | ||
test-heap.cc | ||
test-incremental-marking.cc | ||
test-invalidated-slots.cc | ||
test-lab.cc | ||
test-mark-compact.cc | ||
test-page-promotion.cc | ||
test-spaces.cc | ||
test-unmapper.cc | ||
test-weak-references.cc |