b6b7de0d60
This reverts commit9da3483136Original change's description: > "Reland x4 [arraybuffer] Rearchitect backing store ownership" > > This is a reland ofbc33f5aeba> > Contributed by titzer@chromium.org > > Original change's description: > > [arraybuffer] Rearchitect backing store ownership > > > > This CL completely rearchitects the ownership of array buffer backing stores, > > consolidating ownership into a {BackingStore} C++ object that is tracked > > throughout V8 using unique_ptr and shared_ptr where appropriate. > > > > Overall, lifetime management is simpler and more explicit. The numerous > > ways that array buffers were initialized have been streamlined to one > > Attach() method on JSArrayBuffer. The array buffer tracker in the > > GC implementation now manages std::shared_ptr<BackingStore> pointers, > > and the construction and destruction of the BackingStore object itself > > handles the underlying page or embedder-allocated memory. > > > > The embedder API remains unchanged for now. We use the > > v8::ArrayBuffer::Contents struct to hide an additional shared_ptr to > > keep the backing store alive properly, even in the case of aliases > > from live heap objects. Thus the embedder has a lower chance of making > > a mistake. Long-term, we should move the embedder to a model where they > > manage backing stores using shared_ptr to an opaque backing store object. > > TBR=yangguo@chromium.org > > BUG=v8:9380,v8:9221,chromium:986318 > > Change-Id: If671a4a9ca0476e8f084efae46e0d2bf99ed99ef > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1731005 > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63041} TBR=yangguo@chromium.org Change-Id: I3cc4bb80081c662b1751234bc16a821c20e744be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1792166 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#63617}
35 lines
1.0 KiB
C++
35 lines
1.0 KiB
C++
// Copyright 2019 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#ifndef V8_CCTEST_MANUALLY_EXTERNALIZED_BUFFER_H_
|
|
#define V8_CCTEST_MANUALLY_EXTERNALIZED_BUFFER_H_
|
|
|
|
#include "src/api/api-inl.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
namespace testing {
|
|
|
|
// Utility to free the allocated memory for a buffer that is manually
|
|
// externalized in a test.
|
|
struct ManuallyExternalizedBuffer {
|
|
Handle<JSArrayBuffer> buffer_;
|
|
v8::ArrayBuffer::Contents contents_;
|
|
|
|
explicit ManuallyExternalizedBuffer(Handle<JSArrayBuffer> buffer)
|
|
: buffer_(buffer),
|
|
contents_(v8::Utils::ToLocal(buffer_)->Externalize()) {}
|
|
~ManuallyExternalizedBuffer() {
|
|
contents_.Deleter()(contents_.Data(), contents_.ByteLength(),
|
|
contents_.DeleterData());
|
|
}
|
|
void* backing_store() { return contents_.Data(); }
|
|
};
|
|
|
|
} // namespace testing
|
|
} // namespace internal
|
|
} // namespace v8
|
|
|
|
#endif // V8_CCTEST_MANUALLY_EXTERNALIZED_BUFFER_H_
|