4b4125778a
The most important point of IWYU (include-what-you-use) is that each header includes everything it is using, so that whoever includes that header does not need to additionally include other things. This CL adds a script which generates files to automatically check this. It is automatically invoked during "gclient runhooks" if the "check_v8_header_includes" variable is set. This script generates a number of .cc files in the "check-header-includes" directory, together with a "sources.gni" file which lists all the generated cc files. Each file includes one header. If additionally the gn args "v8_check_header_includes" is set, this gni file is included, and all the generated CC files will be compiled. This will detect violations of the aforementioned IWYU rule. R=titzer@chromium.org, machenbach@chromium.org Bug: v8:7754, v8:7965 Change-Id: Id1cf256507052c3a9ea82f8c80ea1c0385457e31 Reviewed-on: https://chromium-review.googlesource.com/1145199 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Ben Titzer <titzer@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#54590}
399 lines
13 KiB
Python
399 lines
13 KiB
Python
# Note: The buildbots evaluate this file with CWD set to the parent
|
|
# directory and assume that the root of the checkout is in ./v8/, so
|
|
# all paths in here must match this assumption.
|
|
|
|
vars = {
|
|
'checkout_instrumented_libraries': False,
|
|
'chromium_url': 'https://chromium.googlesource.com',
|
|
'download_gcmole': False,
|
|
'download_jsfunfuzz': False,
|
|
'download_mips_toolchain': False,
|
|
'check_v8_header_includes': False,
|
|
}
|
|
|
|
deps = {
|
|
'v8/build':
|
|
Var('chromium_url') + '/chromium/src/build.git' + '@' + '385916c37b59c7fd0210ce918b239bd1c82a0f15',
|
|
'v8/tools/gyp':
|
|
Var('chromium_url') + '/external/gyp.git' + '@' + 'd61a9397e668fa9843c4aa7da9e79460fe590bfb',
|
|
'v8/third_party/depot_tools':
|
|
Var('chromium_url') + '/chromium/tools/depot_tools.git' + '@' + '3899f1bcce7bb87be6af32aec08f8a373e5ae417',
|
|
'v8/third_party/icu':
|
|
Var('chromium_url') + '/chromium/deps/icu.git' + '@' + 'a9a2bd3ee4f1d313651c5272252aaf2a3e7ed529',
|
|
'v8/third_party/instrumented_libraries':
|
|
Var('chromium_url') + '/chromium/src/third_party/instrumented_libraries.git' + '@' + '323cf32193caecbf074d1a0cb5b02b905f163e0f',
|
|
'v8/buildtools':
|
|
Var('chromium_url') + '/chromium/buildtools.git' + '@' + '0dd5c6f980d22be96b728155249df2da355989d9',
|
|
'v8/base/trace_event/common':
|
|
Var('chromium_url') + '/chromium/src/base/trace_event/common.git' + '@' + '211b3ed9d0481b4caddbee1322321b86a483ca1f',
|
|
'v8/third_party/android_ndk': {
|
|
'url': Var('chromium_url') + '/android_ndk.git' + '@' + '5cd86312e794bdf542a3685c6f10cbb96072990b',
|
|
'condition': 'checkout_android',
|
|
},
|
|
'v8/third_party/android_tools': {
|
|
'url': Var('chromium_url') + '/android_tools.git' + '@' + '130499e25286f4d56acafa252fee09f3cc595c49',
|
|
'condition': 'checkout_android',
|
|
},
|
|
'v8/third_party/catapult': {
|
|
'url': Var('chromium_url') + '/catapult.git' + '@' + 'd26f5c315d5ed3e9389ea209a51611f979a18db7',
|
|
'condition': 'checkout_android',
|
|
},
|
|
'v8/third_party/colorama/src': {
|
|
'url': Var('chromium_url') + '/external/colorama.git' + '@' + '799604a1041e9b3bc5d2789ecbd7e8db2e18e6b8',
|
|
'condition': 'checkout_android',
|
|
},
|
|
'v8/third_party/fuchsia-sdk': {
|
|
'url': Var('chromium_url') + '/chromium/src/third_party/fuchsia-sdk.git' + '@' + '62150647e7d7d4b571eec641e1e5b1bbd912cbcd',
|
|
'condition': 'checkout_fuchsia',
|
|
},
|
|
'v8/third_party/googletest/src':
|
|
Var('chromium_url') + '/external/github.com/google/googletest.git' + '@' + 'ce468a17c434e4e79724396ee1b51d86bfc8a88b',
|
|
'v8/third_party/jinja2':
|
|
Var('chromium_url') + '/chromium/src/third_party/jinja2.git' + '@' + 'b41863e42637544c2941b574c7877d3e1f663e25',
|
|
'v8/third_party/markupsafe':
|
|
Var('chromium_url') + '/chromium/src/third_party/markupsafe.git' + '@' + '8f45f5cfa0009d2a70589bcda0349b8cb2b72783',
|
|
'v8/third_party/proguard':
|
|
Var('chromium_url') + '/chromium/src/third_party/proguard.git' + '@' + 'eba7a98d98735b2cc65c54d36baa5c9b46fe4f8e',
|
|
'v8/tools/swarming_client':
|
|
Var('chromium_url') + '/infra/luci/client-py.git' + '@' + '9a518d097dca20b7b00ce3bdfc5d418ccc79893a',
|
|
'v8/test/benchmarks/data':
|
|
Var('chromium_url') + '/v8/deps/third_party/benchmarks.git' + '@' + '05d7188267b4560491ff9155c5ee13e207ecd65f',
|
|
'v8/test/mozilla/data':
|
|
Var('chromium_url') + '/v8/deps/third_party/mozilla-tests.git' + '@' + 'f6c578a10ea707b1a8ab0b88943fe5115ce2b9be',
|
|
'v8/test/test262/data':
|
|
Var('chromium_url') + '/external/github.com/tc39/test262.git' + '@' + 'a6c1d05ac4fed084fa047e4c52ab2a8c9c2a8aef',
|
|
'v8/test/test262/harness':
|
|
Var('chromium_url') + '/external/github.com/test262-utils/test262-harness-py.git' + '@' + '0f2acdd882c84cff43b9d60df7574a1901e2cdcd',
|
|
'v8/tools/clang':
|
|
Var('chromium_url') + '/chromium/src/tools/clang.git' + '@' + 'f30572cab0ed7d31dc5547e709670ac9d252c6c0',
|
|
'v8/tools/luci-go':
|
|
Var('chromium_url') + '/chromium/src/tools/luci-go.git' + '@' + '445d7c4b6a4f10e188edb395b132e3996b127691',
|
|
'v8/test/wasm-js':
|
|
Var('chromium_url') + '/external/github.com/WebAssembly/spec.git' + '@' + '2113ea7e106f8a964e0445ba38f289d2aa845edd',
|
|
}
|
|
|
|
recursedeps = [
|
|
'v8/buildtools',
|
|
'v8/third_party/android_tools',
|
|
]
|
|
|
|
include_rules = [
|
|
# Everybody can use some things.
|
|
'+include',
|
|
'+unicode',
|
|
'+third_party/fdlibm',
|
|
]
|
|
|
|
# checkdeps.py shouldn't check for includes in these directories:
|
|
skip_child_includes = [
|
|
'build',
|
|
'third_party',
|
|
]
|
|
|
|
hooks = [
|
|
{
|
|
# Ensure that the DEPS'd "depot_tools" has its self-update capability
|
|
# disabled.
|
|
'name': 'disable_depot_tools_selfupdate',
|
|
'pattern': '.',
|
|
'action': [
|
|
'python',
|
|
'v8/third_party/depot_tools/update_depot_tools_toggle.py',
|
|
'--disable',
|
|
],
|
|
},
|
|
{
|
|
# This clobbers when necessary (based on get_landmines.py). It must be the
|
|
# first hook so that other things that get/generate into the output
|
|
# directory will not subsequently be clobbered.
|
|
'name': 'landmines',
|
|
'pattern': '.',
|
|
'action': [
|
|
'python',
|
|
'v8/build/landmines.py',
|
|
'--landmine-scripts',
|
|
'v8/tools/get_landmines.py',
|
|
],
|
|
},
|
|
# Pull clang-format binaries using checked-in hashes.
|
|
{
|
|
'name': 'clang_format_win',
|
|
'pattern': '.',
|
|
'condition': 'host_os == "win"',
|
|
'action': [ 'download_from_google_storage',
|
|
'--no_resume',
|
|
'--platform=win32',
|
|
'--no_auth',
|
|
'--bucket', 'chromium-clang-format',
|
|
'-s', 'v8/buildtools/win/clang-format.exe.sha1',
|
|
],
|
|
},
|
|
{
|
|
'name': 'clang_format_mac',
|
|
'pattern': '.',
|
|
'condition': 'host_os == "mac"',
|
|
'action': [ 'download_from_google_storage',
|
|
'--no_resume',
|
|
'--platform=darwin',
|
|
'--no_auth',
|
|
'--bucket', 'chromium-clang-format',
|
|
'-s', 'v8/buildtools/mac/clang-format.sha1',
|
|
],
|
|
},
|
|
{
|
|
'name': 'clang_format_linux',
|
|
'pattern': '.',
|
|
'condition': 'host_os == "linux"',
|
|
'action': [ 'download_from_google_storage',
|
|
'--no_resume',
|
|
'--platform=linux*',
|
|
'--no_auth',
|
|
'--bucket', 'chromium-clang-format',
|
|
'-s', 'v8/buildtools/linux64/clang-format.sha1',
|
|
],
|
|
},
|
|
{
|
|
'name': 'gcmole',
|
|
'pattern': '.',
|
|
'condition': 'download_gcmole',
|
|
'action': [ 'download_from_google_storage',
|
|
'--bucket', 'chrome-v8-gcmole',
|
|
'-u', '--no_resume',
|
|
'-s', 'v8/tools/gcmole/gcmole-tools.tar.gz.sha1',
|
|
'--platform=linux*',
|
|
],
|
|
},
|
|
{
|
|
'name': 'jsfunfuzz',
|
|
'pattern': '.',
|
|
'condition': 'download_jsfunfuzz',
|
|
'action': [ 'download_from_google_storage',
|
|
'--bucket', 'chrome-v8-jsfunfuzz',
|
|
'-u', '--no_resume',
|
|
'-s', 'v8/tools/jsfunfuzz/jsfunfuzz.tar.gz.sha1',
|
|
'--platform=linux*',
|
|
],
|
|
},
|
|
# Pull luci-go binaries (isolate, swarming) using checked-in hashes.
|
|
{
|
|
'name': 'luci-go_win',
|
|
'pattern': '.',
|
|
'condition': 'host_os == "win"',
|
|
'action': [ 'download_from_google_storage',
|
|
'--no_resume',
|
|
'--platform=win32',
|
|
'--no_auth',
|
|
'--bucket', 'chromium-luci',
|
|
'-d', 'v8/tools/luci-go/win64',
|
|
],
|
|
},
|
|
{
|
|
'name': 'luci-go_mac',
|
|
'pattern': '.',
|
|
'condition': 'host_os == "mac"',
|
|
'action': [ 'download_from_google_storage',
|
|
'--no_resume',
|
|
'--platform=darwin',
|
|
'--no_auth',
|
|
'--bucket', 'chromium-luci',
|
|
'-d', 'v8/tools/luci-go/mac64',
|
|
],
|
|
},
|
|
{
|
|
'name': 'luci-go_linux',
|
|
'pattern': '.',
|
|
'condition': 'host_os == "linux"',
|
|
'action': [ 'download_from_google_storage',
|
|
'--no_resume',
|
|
'--platform=linux*',
|
|
'--no_auth',
|
|
'--bucket', 'chromium-luci',
|
|
'-d', 'v8/tools/luci-go/linux64',
|
|
],
|
|
},
|
|
# Pull GN using checked-in hashes.
|
|
{
|
|
'name': 'gn_win',
|
|
'pattern': '.',
|
|
'condition': 'host_os == "win"',
|
|
'action': [ 'download_from_google_storage',
|
|
'--no_resume',
|
|
'--platform=win32',
|
|
'--no_auth',
|
|
'--bucket', 'chromium-gn',
|
|
'-s', 'v8/buildtools/win/gn.exe.sha1',
|
|
],
|
|
},
|
|
{
|
|
'name': 'gn_mac',
|
|
'pattern': '.',
|
|
'condition': 'host_os == "mac"',
|
|
'action': [ 'download_from_google_storage',
|
|
'--no_resume',
|
|
'--platform=darwin',
|
|
'--no_auth',
|
|
'--bucket', 'chromium-gn',
|
|
'-s', 'v8/buildtools/mac/gn.sha1',
|
|
],
|
|
},
|
|
{
|
|
'name': 'gn_linux',
|
|
'pattern': '.',
|
|
'condition': 'host_os == "linux"',
|
|
'action': [ 'download_from_google_storage',
|
|
'--no_resume',
|
|
'--platform=linux*',
|
|
'--no_auth',
|
|
'--bucket', 'chromium-gn',
|
|
'-s', 'v8/buildtools/linux64/gn.sha1',
|
|
],
|
|
},
|
|
{
|
|
'name': 'wasm_spec_tests',
|
|
'pattern': '.',
|
|
'action': [ 'download_from_google_storage',
|
|
'--no_resume',
|
|
'--no_auth',
|
|
'-u',
|
|
'--bucket', 'v8-wasm-spec-tests',
|
|
'-s', 'v8/test/wasm-spec-tests/tests.tar.gz.sha1',
|
|
],
|
|
},
|
|
{
|
|
'name': 'closure_compiler',
|
|
'pattern': '.',
|
|
'action': [ 'download_from_google_storage',
|
|
'--no_resume',
|
|
'--no_auth',
|
|
'-u',
|
|
'--bucket', 'chromium-v8-closure-compiler',
|
|
'-s', 'v8/src/inspector/build/closure-compiler.tar.gz.sha1',
|
|
],
|
|
},
|
|
{
|
|
'name': 'sysroot_arm',
|
|
'pattern': '.',
|
|
'condition': '(checkout_linux and checkout_arm)',
|
|
'action': ['python', 'v8/build/linux/sysroot_scripts/install-sysroot.py',
|
|
'--arch=arm'],
|
|
},
|
|
{
|
|
'name': 'sysroot_arm64',
|
|
'pattern': '.',
|
|
'condition': '(checkout_linux and checkout_arm64)',
|
|
'action': ['python', 'v8/build/linux/sysroot_scripts/install-sysroot.py',
|
|
'--arch=arm64'],
|
|
},
|
|
{
|
|
'name': 'sysroot_x86',
|
|
'pattern': '.',
|
|
'condition': '(checkout_linux and (checkout_x86 or checkout_x64))',
|
|
'action': ['python', 'v8/build/linux/sysroot_scripts/install-sysroot.py',
|
|
'--arch=x86'],
|
|
},
|
|
{
|
|
'name': 'sysroot_mips',
|
|
'pattern': '.',
|
|
'condition': '(checkout_linux and checkout_mips)',
|
|
'action': ['python', 'v8/build/linux/sysroot_scripts/install-sysroot.py',
|
|
'--arch=mips'],
|
|
},
|
|
{
|
|
'name': 'sysroot_x64',
|
|
'pattern': '.',
|
|
'condition': 'checkout_linux and checkout_x64',
|
|
'action': ['python', 'v8/build/linux/sysroot_scripts/install-sysroot.py',
|
|
'--arch=x64'],
|
|
},
|
|
{
|
|
'name': 'msan_chained_origins',
|
|
'pattern': '.',
|
|
'condition': 'checkout_instrumented_libraries',
|
|
'action': [ 'download_from_google_storage',
|
|
'--no_resume',
|
|
'--no_auth',
|
|
'--bucket', 'chromium-instrumented-libraries',
|
|
'-s', 'v8/third_party/instrumented_libraries/binaries/msan-chained-origins-trusty.tgz.sha1',
|
|
],
|
|
},
|
|
{
|
|
'name': 'msan_no_origins',
|
|
'pattern': '.',
|
|
'condition': 'checkout_instrumented_libraries',
|
|
'action': [ 'download_from_google_storage',
|
|
'--no_resume',
|
|
'--no_auth',
|
|
'--bucket', 'chromium-instrumented-libraries',
|
|
'-s', 'v8/third_party/instrumented_libraries/binaries/msan-no-origins-trusty.tgz.sha1',
|
|
],
|
|
},
|
|
{
|
|
# Update the Windows toolchain if necessary.
|
|
'name': 'win_toolchain',
|
|
'pattern': '.',
|
|
'condition': 'checkout_win',
|
|
'action': ['python', 'v8/build/vs_toolchain.py', 'update'],
|
|
},
|
|
# Pull binutils for linux, enabled debug fission for faster linking /
|
|
# debugging when used with clang on Ubuntu Precise.
|
|
# https://code.google.com/p/chromium/issues/detail?id=352046
|
|
{
|
|
'name': 'binutils',
|
|
'pattern': 'v8/third_party/binutils',
|
|
'condition': 'host_os == "linux"',
|
|
'action': [
|
|
'python',
|
|
'v8/third_party/binutils/download.py',
|
|
],
|
|
},
|
|
{
|
|
# Note: On Win, this should run after win_toolchain, as it may use it.
|
|
'name': 'clang',
|
|
'pattern': '.',
|
|
# clang not supported on aix
|
|
'condition': 'host_os != "aix"',
|
|
'action': ['python', 'v8/tools/clang/scripts/update.py'],
|
|
},
|
|
{
|
|
'name': 'fuchsia_sdk',
|
|
'pattern': '.',
|
|
'condition': 'checkout_fuchsia',
|
|
'action': [
|
|
'python',
|
|
'v8/build/fuchsia/update_sdk.py',
|
|
],
|
|
},
|
|
{
|
|
'name': 'mips_toolchain',
|
|
'pattern': '.',
|
|
'condition': 'download_mips_toolchain',
|
|
'action': [ 'download_from_google_storage',
|
|
'--no_resume',
|
|
'--platform=linux',
|
|
'--no_auth',
|
|
'-u',
|
|
'--bucket', 'chromium-v8',
|
|
'-s', 'v8/tools/mips_toolchain.tar.gz.sha1',
|
|
],
|
|
},
|
|
# Download and initialize "vpython" VirtualEnv environment packages.
|
|
{
|
|
'name': 'vpython_common',
|
|
'pattern': '.',
|
|
'condition': 'checkout_android',
|
|
'action': [ 'vpython',
|
|
'-vpython-spec', 'v8/.vpython',
|
|
'-vpython-tool', 'install',
|
|
],
|
|
},
|
|
{
|
|
'name': 'check_v8_header_includes',
|
|
'pattern': '.',
|
|
'condition': 'check_v8_header_includes',
|
|
'action': [
|
|
'python',
|
|
'v8/tools/generate-header-include-checks.py',
|
|
],
|
|
},
|
|
]
|