v8/test
Patrick Thier 24c626c1f7 Improve error messages for property access on null/undefined
Only print the property name when accessing null/undefined if we can
convert it to a string without causing side effects.
If we can't, omit the property name in the error message.
This should avoid confusion when the key is an object with toString().
E.g. undefined[{toString:()=>'a'}] doesn't print 'read property [object
Object]' anymore, which was misleading since the property accessed would
be 'a', but we can't evaluate the key without side effects.

Bug: v8:11365
Change-Id: If82d1adb42561d4851e2bd2ca297a1c71738aee8
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2960211
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: Patrick Thier <pthier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#75250}
2021-06-18 14:47:08 +00:00
..
benchmarks [test] Mark more tests as SLOW for TSAN builds 2021-06-18 11:18:52 +00:00
bigint Reland^2 "[bigint] Karatsuba multiplication" 2021-06-07 11:01:14 +00:00
cctest Improve error messages for property access on null/undefined 2021-06-18 14:47:08 +00:00
common [base] Move utils/vector.h to base/vector.h 2021-06-18 13:33:13 +00:00
debugger Improve error messages for property access on null/undefined 2021-06-18 14:47:08 +00:00
debugging [d8][mjsunit][tools] Improve d8 file API 2021-06-01 13:37:57 +00:00
fuzzer [base] Move utils/vector.h to base/vector.h 2021-06-18 13:33:13 +00:00
fuzzilli
inspector [base] Move utils/vector.h to base/vector.h 2021-06-18 13:33:13 +00:00
intl [intl] Improve test coverage of "best fit" localeMatcher 2021-06-18 03:04:32 +00:00
js-perf-test [d8][mjsunit][tools] Improve d8 file API 2021-06-01 13:37:57 +00:00
memory [snapshot] Fix the Memory.json benchmark 2021-04-28 07:54:34 +00:00
message Improve error messages for property access on null/undefined 2021-06-18 14:47:08 +00:00
mjsunit [sparkplug] Trigger compilation when a FBV exists 2021-06-18 12:06:03 +00:00
mkgrokdump [build] Fold v8_wrappers into v8_libbase 2021-02-25 10:56:20 +00:00
mozilla [test] Mark more tests as SLOW for TSAN builds 2021-06-18 11:18:52 +00:00
test262 [test262] Roll test262 2021-06-18 08:36:43 +00:00
torque [torque] Add LazyNode support 2021-02-23 16:51:53 +00:00
unittests cppgc-js: Set stack start 2021-06-18 14:35:10 +00:00
wasm-api-tests [base] Move utils/vector.h to base/vector.h 2021-06-18 13:33:13 +00:00
wasm-js [wasm] Update spec tests 2021-06-07 11:45:44 +00:00
wasm-spec-tests [compiler] Add TSAN support for generated code movl and movq 2021-06-17 08:46:41 +00:00
webkit Improve error messages for property access on null/undefined 2021-06-18 14:47:08 +00:00
BUILD.gn Reland^2 "[bigint] Karatsuba multiplication" 2021-06-07 11:01:14 +00:00
OWNERS