Go to file
Clemens Hammacher b8cc63ee6d [presubmit] Add check for unbalanced #define / #undef
With jumbo builds, we get spurious errors if several .cc files define
the same preprocessor macro without undefining it. This is also
disallowed by the style guide.
This patch adds a presubmit check to check that each #define is
eventually followed by a corresponding #undef. Special care has to be
taken for conditionally defined macros. Here, the logic to check that
there are not multiple defines and that they are undefined in all
cases is not perfect; it's optimistic in order to avoid false positives.

R=mstarzinger@chromium.org, machenbach@chromium.org

Bug: v8:6811
Change-Id: I55cde499399d97a5eb02fbc5ecfa34e6a8099d06
Reviewed-on: https://chromium-review.googlesource.com/657104
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#47944}
2017-09-11 12:44:40 +00:00
benchmarks Fix common misspellings 2017-08-02 09:35:28 +00:00
build_overrides Remove build_override for macOS min SDK and deployment target. 2017-07-14 18:24:44 +00:00
docs [Docs] Removed unused docs because they are moved to GitHub 2015-11-19 10:23:30 +00:00
gni add gn jumbo build support 2017-08-09 09:05:29 +00:00
gypfiles [gyp] Disable compiler warning 2017-08-29 11:52:47 +00:00
include Make v8::JSON::Stringify take Local<Value> instead of Local<Object>. 2017-09-11 05:17:28 +00:00
infra [build] Add MB config for win64 asan bots 2017-08-16 14:01:31 +00:00
samples [presubmit] Enable and fix "build/namespaces" linter check. 2017-09-04 11:24:26 +00:00
src [turbofan] Fix type of String#indexOf and String#lastIndexOf. 2017-09-11 12:05:29 +00:00
test [wasm] [test] [cleanup] Add missing undefs 2017-09-11 12:09:50 +00:00
testing Use GTEST_LANG_CXX11 in V8 2016-07-25 13:06:42 +00:00
third_party Remove myself from non-toplevel owners files 2017-06-28 10:00:48 +00:00
tools [iwyu] Extend inline include checking to tests. 2017-09-08 09:31:32 +00:00
.clang-format [clang-format] Don't derive pointer alignment 2017-01-17 09:28:19 +00:00
.editorconfig Add .editorconfig 2017-07-28 13:39:24 +00:00
.gitignore add .vscode to .gitignore 2017-08-14 23:18:09 +00:00
.gn For building v8 using gn on aix_ppc64, linux_s390x and linux_ppc64(both LE and BE). 2017-05-12 01:35:09 +00:00
.ycm_extra_conf.py Use C++11 / gnu++11, not 0x 2016-03-22 15:24:43 +00:00
AUTHORS Pass Isolate pointer to String::Utf8Value/Value constructors 2017-08-28 18:17:08 +00:00
BUILD.gn [type-profile] Move type profile to its own files 2017-09-11 06:29:48 +00:00
ChangeLog [Release] Update ChangeLog file 2016-02-17 21:29:09 +00:00
CODE_OF_CONDUCT.md Explicitly state that the Chromium Code of Conduct also applies to V8 2016-03-02 09:51:24 +00:00
codereview.settings Make Gerrit the default code review for V8 2017-06-30 17:37:37 +00:00
DEPS [build] Fix swarming_client DEPS url 2017-09-05 11:35:08 +00:00
LICENSE Updates to the license information of third party components. 2015-06-16 12:37:50 +00:00
LICENSE.fdlibm Add LICENSE.fdlibm for all the fdlibm imported sources. 2016-06-09 07:17:03 +00:00
LICENSE.strongtalk Add LICENSE.v8, LICENSE.strongtalk and LICENSE.valgrind to the v8 2011-02-03 07:10:06 +00:00
LICENSE.v8 Add LICENSE.v8, LICENSE.strongtalk and LICENSE.valgrind to the v8 2011-02-03 07:10:06 +00:00
LICENSE.valgrind Add LICENSE.v8, LICENSE.strongtalk and LICENSE.valgrind to the v8 2011-02-03 07:10:06 +00:00
Makefile [heap] Port concurrent marking flag to GYP. 2017-08-23 15:26:43 +00:00
Makefile.android [build] Fix d8-for-Android builds 2016-05-20 12:10:45 +00:00
OWNERS Add eholk and gdeepti to toplevel owners 2017-08-12 07:07:29 +00:00
PRESUBMIT.py [presubmit] Add check for unbalanced #define / #undef 2017-09-11 12:44:40 +00:00
README.md [Docs] Removed unused docs because they are moved to GitHub 2015-11-19 10:23:30 +00:00
snapshot_toolchain.gni MIPS[64]: Add support for big endian build using GN 2017-06-02 15:02:18 +00:00
WATCHLISTS [V8Tracing] Add lpy@ and fmeawad@ into watchlist for tracing/. 2017-05-22 19:40:17 +00:00

V8 JavaScript Engine

V8 is Google's open source JavaScript engine.

V8 implements ECMAScript as specified in ECMA-262.

V8 is written in C++ and is used in Google Chrome, the open source browser from Google.

V8 can run standalone, or can be embedded into any C++ application.

V8 Project page: https://github.com/v8/v8/wiki

Getting the Code

Checkout depot tools, and run

    fetch v8

This will checkout V8 into the directory v8 and fetch all of its dependencies. To stay up to date, run

    git pull origin
    gclient sync

For fetching all branches, add the following into your remote configuration in .git/config:

    fetch = +refs/branch-heads/*:refs/remotes/branch-heads/*
    fetch = +refs/tags/*:refs/tags/*

Contributing

Please follow the instructions mentioned on the V8 wiki.