f820041aba
This is a reland of 289b25765a
.
The fix for failures landed here:
https://chromium-review.googlesource.com/c/v8/v8/+/1599388
Original change's description:
> [Test] Update tests to work with lazy feedback allocation.
>
> This adds either %EnsureFeedbackVectorForFunction or
> %PrepareFunctionForOptimization to allocate feedback vectors when testing
> optimization, allocation sites, IC transitions etc.,
>
> Bug: v8:8394
> Change-Id: I6ad1b6d460e4abda693b326cddb87754e080a0a1
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1593303
> Commit-Queue: Mythri Alle <mythria@chromium.org>
> Auto-Submit: Mythri Alle <mythria@chromium.org>
> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#61212}
Bug: v8:8394
Change-Id: Idb5bba221d138e6fd73155f959b9e16fc948c709
TBR: rmcilroy@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1599607
Reviewed-by: Mythri Alle <mythria@chromium.org>
Commit-Queue: Mythri Alle <mythria@chromium.org>
Auto-Submit: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#61332}
176 lines
6.2 KiB
JavaScript
176 lines
6.2 KiB
JavaScript
// Copyright 2012 the V8 project authors. All rights reserved.
|
|
// Redistribution and use in source and binary forms, with or without
|
|
// modification, are permitted provided that the following conditions are
|
|
// met:
|
|
//
|
|
// * Redistributions of source code must retain the above copyright
|
|
// notice, this list of conditions and the following disclaimer.
|
|
// * Redistributions in binary form must reproduce the above
|
|
// copyright notice, this list of conditions and the following
|
|
// disclaimer in the documentation and/or other materials provided
|
|
// with the distribution.
|
|
// * Neither the name of Google Inc. nor the names of its
|
|
// contributors may be used to endorse or promote products derived
|
|
// from this software without specific prior written permission.
|
|
//
|
|
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
// Flags: --allow-natives-syntax --expose-gc --no-always-opt --opt
|
|
|
|
// Test element kind of objects.
|
|
|
|
var elements_kind = {
|
|
fast_smi_only : 'fast smi only elements',
|
|
fast : 'fast elements',
|
|
fast_double : 'fast double elements',
|
|
dictionary : 'dictionary elements',
|
|
external_byte : 'external byte elements',
|
|
external_unsigned_byte : 'external unsigned byte elements',
|
|
external_short : 'external short elements',
|
|
external_unsigned_short : 'external unsigned short elements',
|
|
external_int : 'external int elements',
|
|
external_unsigned_int : 'external unsigned int elements',
|
|
external_float : 'external float elements',
|
|
external_double : 'external double elements',
|
|
external_pixel : 'external pixel elements'
|
|
}
|
|
|
|
function getKind(obj) {
|
|
if (%HasSmiElements(obj)) return elements_kind.fast_smi_only;
|
|
if (%HasObjectElements(obj)) return elements_kind.fast;
|
|
if (%HasDoubleElements(obj)) return elements_kind.fast_double;
|
|
if (%HasDictionaryElements(obj)) return elements_kind.dictionary;
|
|
}
|
|
|
|
function isHoley(obj) {
|
|
if (%HasHoleyElements(obj)) return true;
|
|
return false;
|
|
}
|
|
|
|
function assertKind(expected, obj, name_opt) {
|
|
assertEquals(expected, getKind(obj), name_opt);
|
|
}
|
|
|
|
// Test: ensure that crankshafted array constructor sites are deopted
|
|
// if another function is used.
|
|
(function() {
|
|
function bar0(t) {
|
|
return new t();
|
|
}
|
|
%PrepareFunctionForOptimization(bar0);
|
|
a = bar0(Array);
|
|
a[0] = 3.5;
|
|
b = bar0(Array);
|
|
assertKind(elements_kind.fast_double, b);
|
|
%OptimizeFunctionOnNextCall(bar0);
|
|
b = bar0(Array);
|
|
assertKind(elements_kind.fast_double, b);
|
|
assertOptimized(bar0);
|
|
// bar0 should deopt
|
|
b = bar0(Object);
|
|
assertUnoptimized(bar0);
|
|
%PrepareFunctionForOptimization(bar0);
|
|
// When it's re-optimized, we should call through the full stub
|
|
bar0(Array);
|
|
%OptimizeFunctionOnNextCall(bar0);
|
|
b = bar0(Array);
|
|
// We also lost our ability to record kind feedback, as the site
|
|
// is megamorphic now.
|
|
assertKind(elements_kind.fast_smi_only, b);
|
|
assertOptimized(bar0);
|
|
b[0] = 3.5;
|
|
c = bar0(Array);
|
|
assertKind(elements_kind.fast_smi_only, c);
|
|
})();
|
|
|
|
|
|
// Test: When a method with array constructor is crankshafted, the type
|
|
// feedback for elements kind is baked in. Verify that transitions don't
|
|
// change it anymore
|
|
(function() {
|
|
function bar() {
|
|
return new Array();
|
|
}
|
|
%PrepareFunctionForOptimization(bar);
|
|
a = bar();
|
|
bar();
|
|
%OptimizeFunctionOnNextCall(bar);
|
|
b = bar();
|
|
assertOptimized(bar);
|
|
b[0] = 3.5;
|
|
c = bar();
|
|
assertKind(elements_kind.fast_smi_only, c);
|
|
assertOptimized(bar);
|
|
})();
|
|
|
|
|
|
// Test: create arrays in two contexts, verifying that the correct
|
|
// map for Array in that context will be used.
|
|
(function() {
|
|
function bar() { return new Array(); }
|
|
%PrepareFunctionForOptimization(bar);
|
|
bar();
|
|
bar();
|
|
%OptimizeFunctionOnNextCall(bar);
|
|
a = bar();
|
|
assertTrue(a instanceof Array);
|
|
|
|
var contextB = Realm.create();
|
|
Realm.eval(contextB, "function bar2() { return new Array(); };");
|
|
Realm.eval(contextB, "bar2(); bar2();");
|
|
Realm.eval(contextB, "%OptimizeFunctionOnNextCall(bar2);");
|
|
Realm.eval(contextB, "bar2();");
|
|
assertFalse(Realm.eval(contextB, "bar2();") instanceof Array);
|
|
assertTrue(Realm.eval(contextB, "bar2() instanceof Array"));
|
|
})();
|
|
|
|
// Test: create array with packed feedback, then optimize function, which
|
|
// should deal with arguments that create holey arrays.
|
|
(function() {
|
|
function bar(len) { return new Array(len); }
|
|
%PrepareFunctionForOptimization(bar);
|
|
bar(0);
|
|
bar(0);
|
|
%OptimizeFunctionOnNextCall(bar);
|
|
a = bar(0);
|
|
assertOptimized(bar);
|
|
assertTrue(isHoley(a));
|
|
a = bar(1); // ouch!
|
|
assertOptimized(bar);
|
|
assertTrue(isHoley(a));
|
|
a = bar(100);
|
|
assertTrue(isHoley(a));
|
|
a = bar(0);
|
|
assertOptimized(bar);
|
|
assertTrue(isHoley(a));
|
|
})();
|
|
|
|
// Test: Make sure that crankshaft continues with feedback for large arrays.
|
|
(function() {
|
|
function bar(len) { return new Array(len); }
|
|
%PrepareFunctionForOptimization(bar);
|
|
var size = 100001;
|
|
// Perform a gc, because we are allocating a very large array and if a gc
|
|
// happens during the allocation we could lose our memento.
|
|
gc();
|
|
bar(size)[0] = 'string';
|
|
var res = bar(size);
|
|
assertKind(elements_kind.fast, bar(size));
|
|
%OptimizeFunctionOnNextCall(bar);
|
|
assertKind(elements_kind.fast, bar(size));
|
|
// But there is a limit, based on the size of the old generation, currently
|
|
// 22937600, but double it to prevent the test being too brittle.
|
|
var large_size = 22937600 * 2;
|
|
assertKind(elements_kind.dictionary, bar(large_size));
|
|
})();
|