f820041aba
This is a reland of 289b25765a
.
The fix for failures landed here:
https://chromium-review.googlesource.com/c/v8/v8/+/1599388
Original change's description:
> [Test] Update tests to work with lazy feedback allocation.
>
> This adds either %EnsureFeedbackVectorForFunction or
> %PrepareFunctionForOptimization to allocate feedback vectors when testing
> optimization, allocation sites, IC transitions etc.,
>
> Bug: v8:8394
> Change-Id: I6ad1b6d460e4abda693b326cddb87754e080a0a1
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1593303
> Commit-Queue: Mythri Alle <mythria@chromium.org>
> Auto-Submit: Mythri Alle <mythria@chromium.org>
> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#61212}
Bug: v8:8394
Change-Id: Idb5bba221d138e6fd73155f959b9e16fc948c709
TBR: rmcilroy@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1599607
Reviewed-by: Mythri Alle <mythria@chromium.org>
Commit-Queue: Mythri Alle <mythria@chromium.org>
Auto-Submit: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#61332}
56 lines
2.0 KiB
JavaScript
56 lines
2.0 KiB
JavaScript
// Copyright 2016 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --allow-natives-syntax --noalways-opt
|
|
|
|
var elements_kind = {
|
|
fast_smi_only : 'fast smi only elements',
|
|
fast : 'fast elements',
|
|
fast_double : 'fast double elements',
|
|
dictionary : 'dictionary elements',
|
|
}
|
|
|
|
function getKind(obj) {
|
|
if (%HasSmiElements(obj)) return elements_kind.fast_smi_only;
|
|
if (%HasObjectElements(obj)) return elements_kind.fast;
|
|
if (%HasDoubleElements(obj)) return elements_kind.fast_double;
|
|
if (%HasDictionaryElements(obj)) return elements_kind.dictionary;
|
|
}
|
|
|
|
function assertKind(expected, obj, name_opt) {
|
|
assertEquals(expected, getKind(obj), name_opt);
|
|
}
|
|
|
|
(function() {
|
|
function make1() { return new Array(); }
|
|
function make2() { return new Array(); }
|
|
function make3() { return new Array(); }
|
|
function foo(a, i) { a[0] = i; }
|
|
%EnsureFeedbackVectorForFunction(make1);
|
|
%EnsureFeedbackVectorForFunction(make2);
|
|
%EnsureFeedbackVectorForFunction(make3);
|
|
%EnsureFeedbackVectorForFunction(foo);
|
|
|
|
function run_test(maker_function) {
|
|
var one = maker_function();
|
|
assertKind(elements_kind.fast_smi_only, one);
|
|
// Use memento to pre-transition allocation site to DOUBLE elements.
|
|
foo(one, 1.5);
|
|
// Newly created arrays should now have DOUBLE elements right away.
|
|
var two = maker_function();
|
|
assertKind(elements_kind.fast_double, two);
|
|
}
|
|
%EnsureFeedbackVectorForFunction(run_test);
|
|
|
|
// Initialize the KeyedStoreIC in foo; the actual operation will be done
|
|
// in the runtime.
|
|
run_test(make1);
|
|
// Run again; the IC optimistically assumed to only see the transitioned
|
|
// (double-elements) map again, so this will make it polymorphic.
|
|
// The actual operation will again be done in the runtime.
|
|
run_test(make2);
|
|
// Finally, check if the initialized IC honors the allocation memento.
|
|
run_test(make3);
|
|
})();
|