165e725da8
This is a reland of 5dde281c87,
after also fixing the ic-migrated-... test, in which an object died
too early.
Original change's description:
> [compiler] Fix a few test flakes and reenable the tests
>
> Bug: v8:12173
> Change-Id: I2983be9133f8ff4d1740e8eba05a3c29d603dfc3
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3168270
> Auto-Submit: Georg Neis <neis@chromium.org>
> Reviewed-by: Maya Lekova <mslekova@chromium.org>
> Commit-Queue: Maya Lekova <mslekova@chromium.org>
> Commit-Queue: Georg Neis <neis@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#76939}
Bug: v8:12173
Change-Id: If385e5c826b8470ef67f12705c5171f330f6cd57
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3171353
Auto-Submit: Georg Neis <neis@chromium.org>
Reviewed-by: Maya Lekova <mslekova@chromium.org>
Commit-Queue: Georg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#76946}
69 lines
2.1 KiB
JavaScript
69 lines
2.1 KiB
JavaScript
// Copyright 2021 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --allow-natives-syntax --turbo-optimize-apply --opt
|
|
|
|
// These tests do not work well if this script is run more than once (e.g.
|
|
// --stress-opt); after a few runs the whole function is immediately compiled
|
|
// and assertions would fail. We prevent re-runs.
|
|
// Flags: --nostress-opt --no-always-opt
|
|
|
|
// Some of the tests rely on optimizing/deoptimizing at predictable moments, so
|
|
// this is not suitable for deoptimization fuzzing.
|
|
// Flags: --deopt-every-n-times=0
|
|
|
|
// Test for optimization of CallWithSpread when the array iterator is replaced
|
|
// with a generator function after a function is compiled.
|
|
//
|
|
// Note: this test must be in a separate file because the test invalidates a
|
|
// protector, which then remains invalidated.
|
|
(function () {
|
|
"use strict";
|
|
var log_got_interpreted = true;
|
|
|
|
function log(a) {
|
|
assertEquals(1, arguments.length);
|
|
log_got_interpreted = %IsBeingInterpreted();
|
|
return a;
|
|
}
|
|
function foo() {
|
|
return log(...[1]);
|
|
}
|
|
|
|
%PrepareFunctionForOptimization(log);
|
|
%PrepareFunctionForOptimization(foo);
|
|
assertEquals(1, foo());
|
|
assertTrue(log_got_interpreted);
|
|
|
|
// Compile foo.
|
|
%OptimizeFunctionForTopTier(log);
|
|
%OptimizeFunctionForTopTier(foo);
|
|
assertEquals(1, foo());
|
|
// The call with spread should have been inlined.
|
|
assertFalse(log_got_interpreted);
|
|
assertOptimized(foo);
|
|
%PrepareFunctionForOptimization(foo);
|
|
|
|
// This invalidates the DependOnArrayIteratorProtector and causes deopt.
|
|
Object.defineProperty(Array.prototype, Symbol.iterator, {
|
|
value: function* () {
|
|
yield 42;
|
|
},
|
|
});
|
|
|
|
// Now we expect the value yielded by the generator.
|
|
assertEquals(42, foo());
|
|
assertFalse(log_got_interpreted);
|
|
assertUnoptimized(foo);
|
|
|
|
// Recompile 'foo'.
|
|
%PrepareFunctionForOptimization(foo);
|
|
%OptimizeFunctionForTopTier(foo);
|
|
assertEquals(42, foo());
|
|
// The call with spread will not be inlined because we have redefined the
|
|
// array iterator.
|
|
assertFalse(log_got_interpreted);
|
|
assertOptimized(foo);
|
|
})();
|