a513793048
R=machenbach@chromium.org,alexschulze@chromium.org Bug: chromium:1298869 Change-Id: I1ef1ac1d48ccbea81cfebcc360194f5003da17d0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3474672 Commit-Queue: Tamer Tas <tmrts@chromium.org> Auto-Submit: Tamer Tas <tmrts@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#79171}
58 lines
2.1 KiB
Python
58 lines
2.1 KiB
Python
# Copyright 2022 the V8 project authors. All rights reserved.
|
|
# Use of this source code is governed by a BSD-style license that can be
|
|
# found in the LICENSE file.
|
|
|
|
import json
|
|
|
|
# This line is 'magic' in that git-cl looks for it to decide whether to
|
|
# use Python3 instead of Python2 when running the code in this file.
|
|
USE_PYTHON3 = True
|
|
|
|
|
|
def _CheckTrialsConfig(input_api, output_api):
|
|
def FilterFile(affected_file):
|
|
return input_api.FilterSourceFile(
|
|
affected_file,
|
|
files_to_check=(r'.+clusterfuzz_trials_config\.json',))
|
|
|
|
results = []
|
|
for f in input_api.AffectedFiles(
|
|
file_filter=FilterFile, include_deletes=False):
|
|
with open(f.AbsoluteLocalPath()) as j:
|
|
try:
|
|
trials = json.load(j)
|
|
for trial in trials:
|
|
if not all(
|
|
k in trial for k in ('app_args', 'app_name', 'probability')):
|
|
results.append('trial {} is not configured correctly'.format(trial))
|
|
if trial['app_name'] != 'd8':
|
|
results.append('trial {} has an incorrect app_name'.format(trial))
|
|
if not isinstance(trial['probability'], float):
|
|
results.append('trial {} probability is not a float'.format(trial))
|
|
if not (0 <= trial['probability'] <= 1):
|
|
results.append(
|
|
'trial {} has invalid probability value'.format(trial))
|
|
if not isinstance(trial['app_args'], str) or not trial['app_args']:
|
|
results.append(
|
|
'trial {} should have a non-empty string for app_args'.format(
|
|
trial))
|
|
except Exception as e:
|
|
results.append(
|
|
'JSON validation failed for %s. Error:\n%s' % (f.LocalPath(), e))
|
|
|
|
return [output_api.PresubmitError(r) for r in results]
|
|
|
|
def _CommonChecks(input_api, output_api):
|
|
"""Checks common to both upload and commit."""
|
|
checks = [
|
|
_CheckTrialsConfig,
|
|
]
|
|
|
|
return sum([check(input_api, output_api) for check in checks], [])
|
|
|
|
def CheckChangeOnCommit(input_api, output_api):
|
|
return _CommonChecks(input_api, output_api)
|
|
|
|
def CheckChangeOnUpload(input_api, output_api):
|
|
return _CommonChecks(input_api, output_api)
|