bbc8f787f0
Make sure that any GCs required for off-thread heap merging happen before any off-thread handle transferring (both transferring using OffThreadTransferHandle, and the handles created for the string slot fixups). This is to avoid the marker from walking Handle roots that point into off-thread pages which the sweeper doesn't see (and can't clear mark bits on) Now, the merging and handle creation is atomic as far as the GC is concerned. The merging is done before handle creation to avoid the incremental marker from entering off-thread pages, but we ensure that the raw objects pointers that point into the off-thread pages (which are used for creating the main-thread handles) stay valid until the handle creation completes. Since handle transfer now happens in the middle of publishing, this patch also moves the OffThreadTransferHandleStorage ownership over to OffThreadHeap. This requires some header juggling to avoid leaking OffThreadTransferHandleStorage into the off-thread-isolate header. Bug: chromium:1086478, chromium:1011762 Change-Id: Id5e7622d6b5520400a4872c5f6ad396c74b30ca6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2218058 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#68043}
122 lines
5.3 KiB
C++
122 lines
5.3 KiB
C++
// Copyright 2015 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#ifndef HEAP_HEAP_TESTER_H_
|
|
#define HEAP_HEAP_TESTER_H_
|
|
|
|
#include "src/heap/spaces.h"
|
|
#include "src/objects/fixed-array.h"
|
|
|
|
// Tests that should have access to private methods of {v8::internal::Heap}.
|
|
// Those tests need to be defined using HEAP_TEST(Name) { ... }.
|
|
#define HEAP_TEST_METHODS(V) \
|
|
V(CompactionFullAbortedPage) \
|
|
V(CompactionPartiallyAbortedPage) \
|
|
V(CompactionPartiallyAbortedPageIntraAbortedPointers) \
|
|
V(CompactionPartiallyAbortedPageWithInvalidatedSlots) \
|
|
V(CompactionPartiallyAbortedPageWithRememberedSetEntries) \
|
|
V(CompactionSpaceDivideMultiplePages) \
|
|
V(CompactionSpaceDivideSinglePage) \
|
|
V(InvalidatedSlotsAfterTrimming) \
|
|
V(InvalidatedSlotsAllInvalidatedRanges) \
|
|
V(InvalidatedSlotsCleanupEachObject) \
|
|
V(InvalidatedSlotsCleanupFull) \
|
|
V(InvalidatedSlotsCleanupRightTrim) \
|
|
V(InvalidatedSlotsCleanupOverlapRight) \
|
|
V(InvalidatedSlotsEvacuationCandidate) \
|
|
V(InvalidatedSlotsNoInvalidatedRanges) \
|
|
V(InvalidatedSlotsResetObjectRegression) \
|
|
V(InvalidatedSlotsRightTrimFixedArray) \
|
|
V(InvalidatedSlotsRightTrimLargeFixedArray) \
|
|
V(InvalidatedSlotsLeftTrimFixedArray) \
|
|
V(InvalidatedSlotsFastToSlow) \
|
|
V(InvalidatedSlotsSomeInvalidatedRanges) \
|
|
V(TestNewSpaceRefsInCopiedCode) \
|
|
V(GCDuringOffThreadMergeWithTransferHandle) \
|
|
V(GCFlags) \
|
|
V(MarkCompactCollector) \
|
|
V(MarkCompactEpochCounter) \
|
|
V(MemoryReducerActivationForSmallHeaps) \
|
|
V(NoPromotion) \
|
|
V(NumberStringCacheSize) \
|
|
V(ObjectGroups) \
|
|
V(Promotion) \
|
|
V(Regression39128) \
|
|
V(ResetWeakHandle) \
|
|
V(StressHandles) \
|
|
V(TestMemoryReducerSampleJsCalls) \
|
|
V(TestSizeOfObjects) \
|
|
V(Regress5831) \
|
|
V(Regress538257) \
|
|
V(Regress587004) \
|
|
V(Regress589413) \
|
|
V(Regress658718) \
|
|
V(Regress670675) \
|
|
V(Regress777177) \
|
|
V(Regress779503) \
|
|
V(Regress791582) \
|
|
V(Regress845060) \
|
|
V(RegressMissingWriteBarrierInAllocate) \
|
|
V(WriteBarriersInCopyJSObject)
|
|
|
|
#define HEAP_TEST(Name) \
|
|
CcTest register_test_##Name(v8::internal::heap::HeapTester::Test##Name, \
|
|
__FILE__, #Name, true, true); \
|
|
void v8::internal::heap::HeapTester::Test##Name()
|
|
|
|
#define UNINITIALIZED_HEAP_TEST(Name) \
|
|
CcTest register_test_##Name(v8::internal::heap::HeapTester::Test##Name, \
|
|
__FILE__, #Name, true, false); \
|
|
void v8::internal::heap::HeapTester::Test##Name()
|
|
|
|
#define THREADED_HEAP_TEST(Name) \
|
|
RegisterThreadedTest register_##Name( \
|
|
v8::internal::heap::HeapTester::Test##Name, #Name); \
|
|
/* */ HEAP_TEST(Name)
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
|
|
template <typename T>
|
|
class Handle;
|
|
|
|
namespace heap {
|
|
|
|
class HeapTester {
|
|
public:
|
|
#define DECLARE_STATIC(Name) static void Test##Name();
|
|
|
|
HEAP_TEST_METHODS(DECLARE_STATIC)
|
|
#undef HEAP_TEST_METHODS
|
|
|
|
// test-alloc.cc
|
|
static AllocationResult AllocateAfterFailures();
|
|
static Handle<Object> TestAllocateAfterFailures();
|
|
|
|
// test-invalidated-slots.cc
|
|
static Page* AllocateByteArraysOnPage(Heap* heap,
|
|
std::vector<ByteArray>* byte_arrays);
|
|
|
|
// test-api.cc
|
|
static void ResetWeakHandle(bool global_gc);
|
|
|
|
// test-heap.cc
|
|
static AllocationResult AllocateByteArrayForTest(Heap* heap, int length,
|
|
AllocationType allocation);
|
|
static bool CodeEnsureLinearAllocationArea(Heap* heap, int size_in_bytes);
|
|
|
|
// test-mark-compact.cc
|
|
static AllocationResult AllocateMapForTest(v8::internal::Isolate* isolate);
|
|
static AllocationResult AllocateFixedArrayForTest(Heap* heap, int length,
|
|
AllocationType allocation);
|
|
|
|
static void UncommitFromSpace(Heap* heap);
|
|
};
|
|
|
|
} // namespace heap
|
|
} // namespace internal
|
|
} // namespace v8
|
|
|
|
#endif // HEAP_HEAP_TESTER_H_
|