a8176a530c
Nop bytecodes are required only for break locations in debugger. Since nop bytecode doesn't change program state we can remove all of them. There are at least two changes which this CL produce: - we don't provide break position when we load local variable (still provide when load variable from global), - we don't provide break position for statements without actual break positions (e.g. "a;") - these expressions should be super rare and user always can set breakpoint before or after this statement. More details in one pager: https://docs.google.com/a/google.com/document/d/1JXlQpfMa9vRojbE272b6GMBbrfh6m_00135iAUOJEz8/edit?usp=sharing Bug: v8:6425 Change-Id: I4aee73d497a84f7b5d89caa6dda6d3060567dfda Reviewed-on: https://chromium-review.googlesource.com/543161 Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#46742}
192 lines
2.9 KiB
Plaintext
192 lines
2.9 KiB
Plaintext
Checks Debugger.scheduleStepIntoAsync.
|
|
|
|
Running test: testScheduleErrors
|
|
paused at:
|
|
function testNoScheduledTask() {
|
|
#debugger;
|
|
return 42;
|
|
|
|
{
|
|
error : {
|
|
code : -32000
|
|
message : Current scheduled step into async was overriden with new one.
|
|
}
|
|
id : <messageId>
|
|
}
|
|
{
|
|
error : {
|
|
code : -32000
|
|
message : No async tasks were scheduled before pause.
|
|
}
|
|
id : <messageId>
|
|
}
|
|
paused at:
|
|
debugger;
|
|
#return 42;
|
|
}
|
|
|
|
|
|
Running test: testSimple
|
|
paused at:
|
|
function testSimple() {
|
|
#debugger;
|
|
Promise.resolve().then(v => v * 2);
|
|
|
|
paused at:
|
|
debugger;
|
|
#Promise.resolve().then(v => v * 2);
|
|
}
|
|
|
|
{
|
|
id : <messageId>
|
|
result : {
|
|
}
|
|
}
|
|
paused at:
|
|
debugger;
|
|
Promise.resolve().then(#v => v * 2);
|
|
}
|
|
|
|
|
|
Running test: testNotResolvedPromise
|
|
paused at:
|
|
var p = new Promise(resolve => resolveCallback = resolve);
|
|
#debugger;
|
|
p.then(v => v * 2);
|
|
|
|
paused at:
|
|
debugger;
|
|
p.#then(v => v * 2);
|
|
resolveCallback();
|
|
|
|
{
|
|
id : <messageId>
|
|
result : {
|
|
}
|
|
}
|
|
paused at:
|
|
debugger;
|
|
p.then(#v => v * 2);
|
|
resolveCallback();
|
|
|
|
|
|
Running test: testTwoAsyncTasks
|
|
paused at:
|
|
function testTwoAsyncTasks() {
|
|
#debugger;
|
|
Promise.resolve().then(v => v * 2);
|
|
|
|
{
|
|
id : <messageId>
|
|
result : {
|
|
}
|
|
}
|
|
paused at:
|
|
debugger;
|
|
Promise.resolve().then(#v => v * 2);
|
|
Promise.resolve().then(v => v * 4);
|
|
|
|
|
|
Running test: testTwoTasksAndGoToSecond
|
|
paused at:
|
|
function testTwoAsyncTasks() {
|
|
#debugger;
|
|
Promise.resolve().then(v => v * 2);
|
|
|
|
paused at:
|
|
debugger;
|
|
#Promise.resolve().then(v => v * 2);
|
|
Promise.resolve().then(v => v * 4);
|
|
|
|
paused at:
|
|
Promise.resolve().then(v => v * 2);
|
|
#Promise.resolve().then(v => v * 4);
|
|
}
|
|
|
|
{
|
|
id : <messageId>
|
|
result : {
|
|
}
|
|
}
|
|
paused at:
|
|
Promise.resolve().then(v => v * 2);
|
|
Promise.resolve().then(#v => v * 4);
|
|
}
|
|
|
|
|
|
Running test: testTwoAsyncTasksWithBreak
|
|
paused at:
|
|
function testTwoAsyncTasksWithBreak() {
|
|
#debugger;
|
|
Promise.resolve().then(v => v * 2);
|
|
|
|
paused at:
|
|
debugger;
|
|
#Promise.resolve().then(v => v * 2);
|
|
debugger;
|
|
|
|
{
|
|
id : <messageId>
|
|
result : {
|
|
}
|
|
}
|
|
paused at:
|
|
Promise.resolve().then(v => v * 2);
|
|
#debugger;
|
|
Promise.resolve().then(v => v * 4);
|
|
|
|
{
|
|
id : <messageId>
|
|
result : {
|
|
}
|
|
}
|
|
paused at:
|
|
debugger;
|
|
Promise.resolve().then(#v => v * 4);
|
|
}
|
|
|
|
|
|
Running test: testPromiseAll
|
|
paused at:
|
|
function testPromiseAll() {
|
|
#debugger;
|
|
Promise.all([ Promise.resolve(), Promise.resolve() ]).then(v => v * 2);
|
|
|
|
paused at:
|
|
debugger;
|
|
#Promise.all([ Promise.resolve(), Promise.resolve() ]).then(v => v * 2);
|
|
}
|
|
|
|
{
|
|
id : <messageId>
|
|
result : {
|
|
}
|
|
}
|
|
paused at:
|
|
debugger;
|
|
Promise.all([ Promise.resolve(), Promise.resolve() ]).then(#v => v * 2);
|
|
}
|
|
|
|
|
|
Running test: testWithBlackboxedCode
|
|
paused at:
|
|
function testBlackboxedCreatePromise() {
|
|
#debugger;
|
|
createPromise().then(v => v * 2);
|
|
|
|
paused at:
|
|
debugger;
|
|
#createPromise().then(v => v * 2);
|
|
}
|
|
|
|
{
|
|
id : <messageId>
|
|
result : {
|
|
}
|
|
}
|
|
paused at:
|
|
debugger;
|
|
createPromise().then(#v => v * 2);
|
|
}
|
|
|