2bd7464ec1
For global object property cells, we did not check that the map on the previous object is still the same for which we actually optimized. So the optimized code was not in sync with the actual state of the property cell. When loading from such a global object property cell, Crankshaft optimizes away any map checks (based on the stable map assumption), leading to arbitrary memory access in the worst case. TurboFan has the same bug for stores, but is safe on loads because we do appropriate map checks there. However mixing TurboFan and Crankshaft still exposes the bug. R=yangguo@chromium.org BUG=chromium:659475 Review-Url: https://codereview.chromium.org/2444233004 Cr-Commit-Position: refs/heads/master@{#40592}
31 lines
456 B
JavaScript
31 lines
456 B
JavaScript
// Copyright 2016 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --allow-natives-syntax
|
|
|
|
var n;
|
|
|
|
function Ctor() {
|
|
n = new Set();
|
|
}
|
|
|
|
function Check() {
|
|
n.xyz = 0x826852f4;
|
|
}
|
|
|
|
Ctor();
|
|
Ctor();
|
|
%OptimizeFunctionOnNextCall(Ctor);
|
|
Ctor();
|
|
|
|
Check();
|
|
Check();
|
|
%OptimizeFunctionOnNextCall(Check);
|
|
Check();
|
|
|
|
Ctor();
|
|
Check();
|
|
|
|
parseInt('AAAAAAAA');
|