dd3f1ecf71
Even though the change is ES6 spec compliant, we decided to revert to be consistent with other browsers and work on fixing the spec. Original issue's description: > Make dates default to the local timezone if none specified > > In ES5, dates were supposed to default to UTC if no timezone was specified. However, this changed in ES6, which specified that dates should be in the local timezone if no timezone was specified. This CL updates our behavior to match that part of the ES6 spec. > BUG=chromium:391730, v8:4242 > LOG=Y > Committed: https://crrev.com/f06754a8e1d305a43560705f6c167d85d40e602d > Cr-Commit-Position: refs/heads/master@{#29854} BUG=chromium:543320,chromium:539813 LOG=NO Review URL: https://codereview.chromium.org/1403153003 Cr-Commit-Position: refs/heads/master@{#31295}
306 lines
11 KiB
JavaScript
306 lines
11 KiB
JavaScript
// Copyright 2008 the V8 project authors. All rights reserved.
|
|
// Redistribution and use in source and binary forms, with or without
|
|
// modification, are permitted provided that the following conditions are
|
|
// met:
|
|
//
|
|
// * Redistributions of source code must retain the above copyright
|
|
// notice, this list of conditions and the following disclaimer.
|
|
// * Redistributions in binary form must reproduce the above
|
|
// copyright notice, this list of conditions and the following
|
|
// disclaimer in the documentation and/or other materials provided
|
|
// with the distribution.
|
|
// * Neither the name of Google Inc. nor the names of its
|
|
// contributors may be used to endorse or promote products derived
|
|
// from this software without specific prior written permission.
|
|
//
|
|
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
// Test that we can parse dates in all the different formats that we
|
|
// have to support.
|
|
//
|
|
// These formats are all supported by KJS but a lot of them are not
|
|
// supported by Spidermonkey.
|
|
|
|
function testDateParse(string) {
|
|
var d = Date.parse(string);
|
|
assertEquals(946713600000, d, "parse: " + string);
|
|
};
|
|
|
|
|
|
// For local time we just test that parsing returns non-NaN positive
|
|
// number of milliseconds to make it timezone independent.
|
|
function testDateParseLocalTime(string) {
|
|
var d = Date.parse("parse-local-time:" + string);
|
|
assertTrue(!isNaN(d), "parse-local-time: " + string + " is NaN.");
|
|
assertTrue(d > 0, "parse-local-time: " + string + " <= 0.");
|
|
};
|
|
|
|
|
|
function testDateParseMisc(array) {
|
|
assertEquals(2, array.length, "array [" + array + "] length != 2.");
|
|
var string = array[0];
|
|
var expected = array[1];
|
|
var d = Date.parse(string);
|
|
assertEquals(expected, d, "parse-misc: " + string);
|
|
}
|
|
|
|
|
|
//
|
|
// Test all the formats in UT timezone.
|
|
//
|
|
var testCasesUT = [
|
|
'Sat, 01-Jan-2000 08:00:00 UT',
|
|
'Sat, 01 Jan 2000 08:00:00 UT',
|
|
'Jan 01 2000 08:00:00 UT',
|
|
'Jan 01 08:00:00 UT 2000',
|
|
'Saturday, 01-Jan-00 08:00:00 UT',
|
|
'01 Jan 00 08:00 +0000',
|
|
// Ignore weekdays.
|
|
'Mon, 01 Jan 2000 08:00:00 UT',
|
|
'Tue, 01 Jan 2000 08:00:00 UT',
|
|
// Ignore prefix that is not part of a date.
|
|
'[Saturday] Jan 01 08:00:00 UT 2000',
|
|
'Ignore all of this stuff because it is annoying 01 Jan 2000 08:00:00 UT',
|
|
'[Saturday] Jan 01 2000 08:00:00 UT',
|
|
'All of this stuff is really annnoying, so it will be ignored Jan 01 2000 08:00:00 UT',
|
|
// If the three first letters of the month is a
|
|
// month name we are happy - ignore the rest.
|
|
'Sat, 01-Janisamonth-2000 08:00:00 UT',
|
|
'Sat, 01 Janisamonth 2000 08:00:00 UT',
|
|
'Janisamonth 01 2000 08:00:00 UT',
|
|
'Janisamonth 01 08:00:00 UT 2000',
|
|
'Saturday, 01-Janisamonth-00 08:00:00 UT',
|
|
'01 Janisamonth 00 08:00 +0000',
|
|
// Allow missing space between month and day.
|
|
'Janisamonthandtherestisignored01 2000 08:00:00 UT',
|
|
'Jan01 2000 08:00:00 UT',
|
|
// Allow year/month/day format.
|
|
'Sat, 2000/01/01 08:00:00 UT',
|
|
// Allow month/day/year format.
|
|
'Sat, 01/01/2000 08:00:00 UT',
|
|
// Allow month/day year format.
|
|
'Sat, 01/01 2000 08:00:00 UT',
|
|
// Allow comma instead of space after day, month and year.
|
|
'Sat, 01,Jan,2000,08:00:00 UT',
|
|
// Seconds are optional.
|
|
'Sat, 01-Jan-2000 08:00 UT',
|
|
'Sat, 01 Jan 2000 08:00 UT',
|
|
'Jan 01 2000 08:00 UT',
|
|
'Jan 01 08:00 UT 2000',
|
|
'Saturday, 01-Jan-00 08:00 UT',
|
|
'01 Jan 00 08:00 +0000',
|
|
// Allow AM/PM after the time.
|
|
'Sat, 01-Jan-2000 08:00 AM UT',
|
|
'Sat, 01 Jan 2000 08:00 AM UT',
|
|
'Jan 01 2000 08:00 AM UT',
|
|
'Jan 01 08:00 AM UT 2000',
|
|
'Saturday, 01-Jan-00 08:00 AM UT',
|
|
'01 Jan 00 08:00 AM +0000',
|
|
// White space and stuff in parenthesis is
|
|
// apparently allowed in most places where white
|
|
// space is allowed.
|
|
' Sat, 01-Jan-2000 08:00:00 UT ',
|
|
' Sat, 01 Jan 2000 08:00:00 UT ',
|
|
' Saturday, 01-Jan-00 08:00:00 UT ',
|
|
' 01 Jan 00 08:00 +0000 ',
|
|
' ()(Sat, 01-Jan-2000) Sat, 01-Jan-2000 08:00:00 UT ',
|
|
' Sat()(Sat, 01-Jan-2000)01 Jan 2000 08:00:00 UT ',
|
|
' Sat,(02)01 Jan 2000 08:00:00 UT ',
|
|
' Sat, 01(02)Jan 2000 08:00:00 UT ',
|
|
' Sat, 01 Jan 2000 (2001)08:00:00 UT ',
|
|
' Sat, 01 Jan 2000 (01)08:00:00 UT ',
|
|
' Sat, 01 Jan 2000 (01:00:00)08:00:00 UT ',
|
|
' Sat, 01 Jan 2000 08:00:00 (CDT)UT ',
|
|
' Sat, 01 Jan 2000 08:00:00 UT((((CDT))))',
|
|
' Saturday, 01-Jan-00 ()(((asfd)))(Sat, 01-Jan-2000)08:00:00 UT ',
|
|
' 01 Jan 00 08:00 ()(((asdf)))(Sat, 01-Jan-2000)+0000 ',
|
|
' 01 Jan 00 08:00 +0000()((asfd)(Sat, 01-Jan-2000)) '];
|
|
|
|
//
|
|
// Test that we do the right correction for different time zones.
|
|
// I'll assume that we can handle the same formats as for UT and only
|
|
// test a few formats for each of the timezones.
|
|
//
|
|
|
|
// GMT = UT
|
|
var testCasesGMT = [
|
|
'Sat, 01-Jan-2000 08:00:00 GMT',
|
|
'Sat, 01-Jan-2000 08:00:00 GMT+0',
|
|
'Sat, 01-Jan-2000 08:00:00 GMT+00',
|
|
'Sat, 01-Jan-2000 08:00:00 GMT+000',
|
|
'Sat, 01-Jan-2000 08:00:00 GMT+0000',
|
|
'Sat, 01-Jan-2000 08:00:00 GMT+00:00', // Interestingly, KJS cannot handle this.
|
|
'Sat, 01 Jan 2000 08:00:00 GMT',
|
|
'Saturday, 01-Jan-00 08:00:00 GMT',
|
|
'01 Jan 00 08:00 -0000',
|
|
'01 Jan 00 08:00 +0000'];
|
|
|
|
// EST = UT minus 5 hours.
|
|
var testCasesEST = [
|
|
'Sat, 01-Jan-2000 03:00:00 UTC-0500',
|
|
'Sat, 01-Jan-2000 03:00:00 UTC-05:00', // Interestingly, KJS cannot handle this.
|
|
'Sat, 01-Jan-2000 03:00:00 EST',
|
|
'Sat, 01 Jan 2000 03:00:00 EST',
|
|
'Saturday, 01-Jan-00 03:00:00 EST',
|
|
'01 Jan 00 03:00 -0500'];
|
|
|
|
// EDT = UT minus 4 hours.
|
|
var testCasesEDT = [
|
|
'Sat, 01-Jan-2000 04:00:00 EDT',
|
|
'Sat, 01 Jan 2000 04:00:00 EDT',
|
|
'Saturday, 01-Jan-00 04:00:00 EDT',
|
|
'01 Jan 00 04:00 -0400'];
|
|
|
|
// CST = UT minus 6 hours.
|
|
var testCasesCST = [
|
|
'Sat, 01-Jan-2000 02:00:00 CST',
|
|
'Sat, 01 Jan 2000 02:00:00 CST',
|
|
'Saturday, 01-Jan-00 02:00:00 CST',
|
|
'01 Jan 00 02:00 -0600'];
|
|
|
|
// CDT = UT minus 5 hours.
|
|
var testCasesCDT = [
|
|
'Sat, 01-Jan-2000 03:00:00 CDT',
|
|
'Sat, 01 Jan 2000 03:00:00 CDT',
|
|
'Saturday, 01-Jan-00 03:00:00 CDT',
|
|
'01 Jan 00 03:00 -0500'];
|
|
|
|
// MST = UT minus 7 hours.
|
|
var testCasesMST = [
|
|
'Sat, 01-Jan-2000 01:00:00 MST',
|
|
'Sat, 01 Jan 2000 01:00:00 MST',
|
|
'Saturday, 01-Jan-00 01:00:00 MST',
|
|
'01 Jan 00 01:00 -0700'];
|
|
|
|
// MDT = UT minus 6 hours.
|
|
var testCasesMDT = [
|
|
'Sat, 01-Jan-2000 02:00:00 MDT',
|
|
'Sat, 01 Jan 2000 02:00:00 MDT',
|
|
'Saturday, 01-Jan-00 02:00:00 MDT',
|
|
'01 Jan 00 02:00 -0600'];
|
|
|
|
// PST = UT minus 8 hours.
|
|
var testCasesPST = [
|
|
'Sat, 01-Jan-2000 00:00:00 PST',
|
|
'Sat, 01 Jan 2000 00:00:00 PST',
|
|
'Saturday, 01-Jan-00 00:00:00 PST',
|
|
'01 Jan 00 00:00 -0800',
|
|
// Allow missing time.
|
|
'Sat, 01-Jan-2000 PST'];
|
|
|
|
// PDT = UT minus 7 hours.
|
|
var testCasesPDT = [
|
|
'Sat, 01-Jan-2000 01:00:00 PDT',
|
|
'Sat, 01 Jan 2000 01:00:00 PDT',
|
|
'Saturday, 01-Jan-00 01:00:00 PDT',
|
|
'01 Jan 00 01:00 -0700'];
|
|
|
|
// Local time cases.
|
|
var testCasesLocalTime = [
|
|
// Allow timezone ommision.
|
|
'Sat, 01-Jan-2000 08:00:00',
|
|
'Sat, 01 Jan 2000 08:00:00',
|
|
'Jan 01 2000 08:00:00',
|
|
'Jan 01 08:00:00 2000',
|
|
'Saturday, 01-Jan-00 08:00:00',
|
|
'01 Jan 00 08:00'];
|
|
|
|
|
|
// Misc. test cases that result in a different time value.
|
|
var testCasesMisc = [
|
|
// Special handling for years in the [0, 100) range.
|
|
['Sat, 01 Jan 0 08:00:00 UT', 946713600000], // year 2000
|
|
['Sat, 01 Jan 49 08:00:00 UT', 2493100800000], // year 2049
|
|
['Sat, 01 Jan 50 08:00:00 UT', -631123200000], // year 1950
|
|
['Sat, 01 Jan 99 08:00:00 UT', 915177600000], // year 1999
|
|
['Sat, 01 Jan 100 08:00:00 UT', -59011430400000], // year 100
|
|
// Test PM after time.
|
|
['Sat, 01-Jan-2000 08:00 PM UT', 946756800000],
|
|
['Sat, 01 Jan 2000 08:00 PM UT', 946756800000],
|
|
['Jan 01 2000 08:00 PM UT', 946756800000],
|
|
['Jan 01 08:00 PM UT 2000', 946756800000],
|
|
['Saturday, 01-Jan-00 08:00 PM UT', 946756800000],
|
|
['01 Jan 00 08:00 PM +0000', 946756800000]];
|
|
|
|
// Test different version of the ES5 date time string format.
|
|
var testCasesES5Misc = [
|
|
['2000-01-01T08:00:00.000Z', 946713600000],
|
|
['2000-01-01T08:00:00Z', 946713600000],
|
|
['2000-01-01T08:00Z', 946713600000],
|
|
['2000-01T08:00:00.000Z', 946713600000],
|
|
['2000T08:00:00.000Z', 946713600000],
|
|
['2000T08:00Z', 946713600000],
|
|
['2000-01T00:00:00.000-08:00', 946713600000],
|
|
['2000-01T08:00:00.001Z', 946713600001],
|
|
['2000-01T08:00:00.099Z', 946713600099],
|
|
['2000-01T08:00:00.999Z', 946713600999],
|
|
['2000-01T00:00:00.001-08:00', 946713600001],
|
|
['2000-01-01T24:00', 946771200000],
|
|
['2000-01-01T24:00:00', 946771200000],
|
|
['2000-01-01T24:00:00.000', 946771200000],
|
|
['2000-01-01T24:00:00.000Z', 946771200000]];
|
|
|
|
var testCasesES5MiscNegative = [
|
|
'2000-01-01TZ',
|
|
'2000-01-01T60Z',
|
|
'2000-01-01T60:60Z',
|
|
'2000-01-0108:00Z',
|
|
'2000-01-01T08Z',
|
|
'2000-01-01T24:01',
|
|
'2000-01-01T24:00:01',
|
|
'2000-01-01T24:00:00.001',
|
|
'2000-01-01T24:00:00.999Z'];
|
|
|
|
|
|
// Run all the tests.
|
|
testCasesUT.forEach(testDateParse);
|
|
testCasesGMT.forEach(testDateParse);
|
|
testCasesEST.forEach(testDateParse);
|
|
testCasesEDT.forEach(testDateParse);
|
|
testCasesCST.forEach(testDateParse);
|
|
testCasesCDT.forEach(testDateParse);
|
|
testCasesMST.forEach(testDateParse);
|
|
testCasesMDT.forEach(testDateParse);
|
|
testCasesPST.forEach(testDateParse);
|
|
testCasesPDT.forEach(testDateParse);
|
|
testCasesLocalTime.forEach(testDateParseLocalTime);
|
|
testCasesMisc.forEach(testDateParseMisc);
|
|
|
|
// ES5 date time string format compliance.
|
|
testCasesES5Misc.forEach(testDateParseMisc);
|
|
testCasesES5MiscNegative.forEach(function (s) {
|
|
assertTrue(isNaN(Date.parse(s)), s + " is not NaN.");
|
|
});
|
|
|
|
|
|
// Test that we can parse our own date format.
|
|
// (Dates from 1970 to ~2070 with 150h steps.)
|
|
for (var i = 0; i < 24 * 365 * 100; i += 150) {
|
|
var ms = i * (3600 * 1000);
|
|
var s = (new Date(ms)).toString();
|
|
assertEquals(ms, Date.parse(s), "parse own: " + s);
|
|
}
|
|
|
|
// Negative tests.
|
|
var testCasesNegative = [
|
|
'May 25 2008 1:30 (PM)) UTC', // Bad unmatched ')' after number.
|
|
'May 25 2008 1:30( )AM (PM)', //
|
|
'a1', // Issue 126448, 53209.
|
|
'nasfdjklsfjoaifg1',
|
|
'x_2',
|
|
'May 25 2008 AAA (GMT)']; // Unknown word after number.
|
|
|
|
testCasesNegative.forEach(function (s) {
|
|
assertTrue(isNaN(Date.parse(s)), s + " is not NaN.");
|
|
});
|