35c28ce0a7
Prior to this patch, we enter a global debug mode whenever a break point is set. By entering this mode, all code is deoptimized and activated frames are recompiled and redirected to newly compiled debug code. After this patch, we only deoptimize/redirect for functions we want to debug. Trigger for this is Debug::EnsureDebugInfo, and having DebugInfo object attached to the SFI prevents optimization/inlining. The result is that we can have optimized code for functions without break points alongside functions that do have break points, which are not optimized. R=mstarzinger@chromium.org, ulan@chromium.org BUG=v8:4132 LOG=Y Review URL: https://codereview.chromium.org/1233073005 Cr-Commit-Position: refs/heads/master@{#29758}
157 lines
5.6 KiB
JavaScript
157 lines
5.6 KiB
JavaScript
// Copyright 2008 the V8 project authors. All rights reserved.
|
|
// Redistribution and use in source and binary forms, with or without
|
|
// modification, are permitted provided that the following conditions are
|
|
// met:
|
|
//
|
|
// * Redistributions of source code must retain the above copyright
|
|
// notice, this list of conditions and the following disclaimer.
|
|
// * Redistributions in binary form must reproduce the above
|
|
// copyright notice, this list of conditions and the following
|
|
// disclaimer in the documentation and/or other materials provided
|
|
// with the distribution.
|
|
// * Neither the name of Google Inc. nor the names of its
|
|
// contributors may be used to endorse or promote products derived
|
|
// from this software without specific prior written permission.
|
|
//
|
|
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
// Flags: --expose-debug-as debug
|
|
// Get the Debug object exposed from the debug context global object.
|
|
Debug = debug.Debug
|
|
|
|
listenerComplete = false;
|
|
exception = false;
|
|
|
|
// The base part of all evaluate requests.
|
|
var base_request = '"seq":0,"type":"request","command":"evaluate"'
|
|
|
|
function safeEval(code) {
|
|
try {
|
|
return eval('(' + code + ')');
|
|
} catch (e) {
|
|
assertEquals(void 0, e);
|
|
return undefined;
|
|
}
|
|
}
|
|
|
|
function testRequest(dcp, arguments, success, result) {
|
|
// Generate request with the supplied arguments.
|
|
var request;
|
|
if (arguments) {
|
|
request = '{' + base_request + ',"arguments":' + arguments + '}';
|
|
} else {
|
|
request = '{' + base_request + '}'
|
|
}
|
|
var response = safeEval(dcp.processDebugJSONRequest(request));
|
|
if (success) {
|
|
assertTrue(response.success, request + ' -> ' + response.message);
|
|
assertEquals(result, response.body.value);
|
|
} else {
|
|
assertFalse(response.success, request + ' -> ' + response.message);
|
|
}
|
|
assertEquals(response.running, "unspecified_running_state",
|
|
request + ' -> expected not running');
|
|
}
|
|
|
|
function listener(event, exec_state, event_data, data) {
|
|
try {
|
|
if (event == Debug.DebugEvent.Break) {
|
|
// Get the debug command processor.
|
|
var dcp = exec_state.debugCommandProcessor("unspecified_running_state");
|
|
|
|
// Test some illegal evaluate requests.
|
|
testRequest(dcp, void 0, false);
|
|
testRequest(dcp, '{"expression":"1","global"=true}', false);
|
|
testRequest(dcp, '{"expression":"a","frame":4}', false);
|
|
|
|
// Test some legal evaluate requests.
|
|
testRequest(dcp, '{"expression":"1+2"}', true, 3);
|
|
testRequest(dcp, '{"expression":"a+2"}', true, 5);
|
|
testRequest(dcp, '{"expression":"({\\"a\\":1,\\"b\\":2}).b+2"}', true, 4);
|
|
|
|
// Test evaluation of a in the stack frames and the global context.
|
|
testRequest(dcp, '{"expression":"a"}', true, 3);
|
|
testRequest(dcp, '{"expression":"a","frame":0}', true, 3);
|
|
testRequest(dcp, '{"expression":"a","frame":1}', true, 2);
|
|
testRequest(dcp, '{"expression":"a","frame":2}', true, 1);
|
|
testRequest(dcp, '{"expression":"a","global":true}', true, 1);
|
|
testRequest(dcp, '{"expression":"this.a","global":true}', true, 1);
|
|
|
|
// Test that the whole string text is returned if maxStringLength
|
|
// parameter is passed.
|
|
testRequest(
|
|
dcp,
|
|
'{"expression":"this.longString","global":true,"maxStringLength":-1}',
|
|
true,
|
|
longString);
|
|
testRequest(
|
|
dcp,
|
|
'{"expression":"this.longString","global":true,"maxStringLength":' +
|
|
longString.length + '}',
|
|
true,
|
|
longString);
|
|
var truncatedStringSuffix = '... (length: ' + longString.length + ')';
|
|
testRequest(
|
|
dcp,
|
|
'{"expression":"this.longString","global":true,"maxStringLength":0}',
|
|
true,
|
|
truncatedStringSuffix);
|
|
testRequest(
|
|
dcp,
|
|
'{"expression":"this.longString","global":true,"maxStringLength":1}',
|
|
true,
|
|
longString.charAt(0) + truncatedStringSuffix);
|
|
// Test that by default string is truncated to first 80 chars.
|
|
testRequest(
|
|
dcp,
|
|
'{"expression":"this.longString","global":true}',
|
|
true,
|
|
longString.substring(0, 80) + truncatedStringSuffix);
|
|
|
|
// Indicate that all was processed.
|
|
listenerComplete = true;
|
|
}
|
|
} catch (e) {
|
|
exception = e
|
|
};
|
|
};
|
|
|
|
// Add the debug event listener.
|
|
Debug.setListener(listener);
|
|
|
|
function f() {
|
|
var a = 3;
|
|
};
|
|
|
|
function g() {
|
|
var a = 2;
|
|
f();
|
|
return a; // Use the value to prevent it being removed by DCE.
|
|
};
|
|
|
|
a = 1;
|
|
|
|
// String which is longer than 80 chars.
|
|
var longString = "1234567890_";
|
|
for (var i = 0; i < 4; i++) {
|
|
longString += longString;
|
|
}
|
|
|
|
// Set a break point at return in f and invoke g to hit the breakpoint.
|
|
Debug.setBreakPoint(f, 2, 0);
|
|
g();
|
|
|
|
assertFalse(exception, "exception in listener")
|
|
// Make sure that the debug event listener vas invoked.
|
|
assertTrue(listenerComplete, "listener did not run to completion");
|