71cf4890d0
Today, the semantics of:
WebAssembly.instantiate
and
WebAssembly.compile().then(new WebAssemblyInstance)
are subtly different, to the point where attempting the proposed
change uncovered bugs.
In the future, it's possible that .instantiate actually have different
semantics - if we pre-specialized to the provided ffi, for example.
Right now that's not the case.
This CL:
- gets our implementation closer to what developers may write using
the compile -> new Instance alternative, in particular wrt promise
creation. By reusing code paths, we uncover more bugs, and keep
maintenance cost lower.
- it gives us the response-based WebAssembly.instantiate implicitly.
Otherwise, we'd need that same implementation on the blink side. The
negative is maintenance: imagine if the bugs I mentioned could only be
found when running in Blink.
BUG=chromium:697028
Review-Url: https://codereview.chromium.org/2806073002
Cr-Original-Commit-Position: refs/heads/master@{#44592}
Committed: 7829af3275
Review-Url: https://codereview.chromium.org/2806073002
Cr-Commit-Position: refs/heads/master@{#44669}
40 lines
1.0 KiB
JavaScript
40 lines
1.0 KiB
JavaScript
// Copyright 2017 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --allow-natives-syntax
|
|
|
|
load("test/mjsunit/wasm/wasm-constants.js");
|
|
load("test/mjsunit/wasm/wasm-module-builder.js");
|
|
|
|
%ResetWasmOverloads();
|
|
let buffer = (() => {
|
|
let builder = new WasmModuleBuilder();
|
|
builder.addFunction("f", kSig_i_v)
|
|
.addBody([kExprI32Const, 42])
|
|
.exportAs("f");
|
|
return builder.toBuffer();
|
|
})();
|
|
|
|
var module = new WebAssembly.Module(buffer);
|
|
var wrapper = [module];
|
|
|
|
assertPromiseResult(
|
|
WebAssembly.instantiate(wrapper),
|
|
assertUnreachable,
|
|
e => assertTrue(e instanceof TypeError));
|
|
|
|
assertPromiseResult(
|
|
(() => {
|
|
%SetWasmCompileFromPromiseOverload();
|
|
return WebAssembly.instantiate(wrapper);
|
|
})(),
|
|
pair => {
|
|
print(2);
|
|
var pair = result.pair;
|
|
assertTrue(pair.instance instanceof WebAssembly.Instance);
|
|
assertTrue(pair.module instanceof WebAssembly.Module);
|
|
%ResetWasmOverloads();
|
|
},
|
|
assertUnreachable);
|