3b1509389a
When formatting console messages (for consumption in Chromium/Blink), we have special logic to unwrap value wrapper objects. But this logic was not very consistent, and especially Number values and NumberObject values were formatted differently. This changes the V8ValueStringBuilder::append() logic to always unwrap any value wrapper first and then use the regular dispatch for the primitive value. Fixed: chromium:1321833 Change-Id: I9996671e1f91da0841e5d5f1687cf647ab72a561 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3622913 Commit-Queue: Yang Guo <yangguo@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/main@{#80323}
68 lines
1.4 KiB
Plaintext
68 lines
1.4 KiB
Plaintext
Regression test for crbug.com/1321833
|
|
|
|
Running test: testNumberNaN
|
|
log[
|
|
[0] : {
|
|
className : Number
|
|
description : Number
|
|
objectId : 1.1.1
|
|
preview : {
|
|
description : Number
|
|
overflow : false
|
|
properties : [
|
|
[0] : {
|
|
name : [[PrimitiveValue]]
|
|
type : number
|
|
value : NaN
|
|
}
|
|
]
|
|
type : object
|
|
}
|
|
type : object
|
|
}
|
|
]
|
|
|
|
Running test: testNumberInfinity
|
|
log[
|
|
[0] : {
|
|
className : Number
|
|
description : Number
|
|
objectId : 1.1.2
|
|
preview : {
|
|
description : Number
|
|
overflow : false
|
|
properties : [
|
|
[0] : {
|
|
name : [[PrimitiveValue]]
|
|
type : number
|
|
value : Infinity
|
|
}
|
|
]
|
|
type : object
|
|
}
|
|
type : object
|
|
}
|
|
]
|
|
|
|
Running test: testNumberMinusInfinity
|
|
log[
|
|
[0] : {
|
|
className : Number
|
|
description : Number
|
|
objectId : 1.1.3
|
|
preview : {
|
|
description : Number
|
|
overflow : false
|
|
properties : [
|
|
[0] : {
|
|
name : [[PrimitiveValue]]
|
|
type : number
|
|
value : -Infinity
|
|
}
|
|
]
|
|
type : object
|
|
}
|
|
type : object
|
|
}
|
|
]
|