e4a15a7b4e
Reason for revert: The test is very flaky on the bots, e.g.: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20ASAN/builds/17031 https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20shared/builds/14776 Original issue's description: > [counters] RuntimeStats: fix wrong bookkeeping when dynamically changing counters > > RuntimeTimerScopes always subtract their own time from the parent timer's > counter to properly account for the own time. Once a scope is destructed it > adds it own timer to the current active counter. However, if the current > counter is changed with CorrectCurrentCounterId we will attribute all the > subtimers to the previous counter, and add the own time to the new counter. > This way it is possible to end up with negative times in certain counters but > the overall would still be correct. > > BUG= > > Committed: https://crrev.com/f6c74d964d9387df4bed3d8c1ded51eb9e8aa6e8 > Committed: https://crrev.com/491651792d7818aed04eaeffb9890b5a309b543e > Cr-Original-Commit-Position: refs/heads/master@{#41142} > Cr-Commit-Position: refs/heads/master@{#41214} TBR=ishell@chromium.org,fmeawad@chromium.org,lpy@chromium.org,cbruni@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2526843002 Cr-Commit-Position: refs/heads/master@{#41229}
399 lines
12 KiB
C++
399 lines
12 KiB
C++
// Copyright 2012 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "src/counters.h"
|
|
|
|
#include <iomanip>
|
|
|
|
#include "src/base/platform/platform.h"
|
|
#include "src/isolate.h"
|
|
#include "src/log-inl.h"
|
|
#include "src/log.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
|
|
StatsTable::StatsTable()
|
|
: lookup_function_(NULL),
|
|
create_histogram_function_(NULL),
|
|
add_histogram_sample_function_(NULL) {}
|
|
|
|
|
|
int* StatsCounter::FindLocationInStatsTable() const {
|
|
return isolate_->stats_table()->FindLocation(name_);
|
|
}
|
|
|
|
|
|
void Histogram::AddSample(int sample) {
|
|
if (Enabled()) {
|
|
isolate()->stats_table()->AddHistogramSample(histogram_, sample);
|
|
}
|
|
}
|
|
|
|
void* Histogram::CreateHistogram() const {
|
|
return isolate()->stats_table()->
|
|
CreateHistogram(name_, min_, max_, num_buckets_);
|
|
}
|
|
|
|
|
|
// Start the timer.
|
|
void HistogramTimer::Start() {
|
|
if (Enabled()) {
|
|
timer_.Start();
|
|
}
|
|
Logger::CallEventLogger(isolate(), name(), Logger::START, true);
|
|
}
|
|
|
|
|
|
// Stop the timer and record the results.
|
|
void HistogramTimer::Stop() {
|
|
if (Enabled()) {
|
|
int64_t sample = resolution_ == MICROSECOND
|
|
? timer_.Elapsed().InMicroseconds()
|
|
: timer_.Elapsed().InMilliseconds();
|
|
// Compute the delta between start and stop, in microseconds.
|
|
AddSample(static_cast<int>(sample));
|
|
timer_.Stop();
|
|
}
|
|
Logger::CallEventLogger(isolate(), name(), Logger::END, true);
|
|
}
|
|
|
|
|
|
Counters::Counters(Isolate* isolate) {
|
|
#define HR(name, caption, min, max, num_buckets) \
|
|
name##_ = Histogram(#caption, min, max, num_buckets, isolate);
|
|
HISTOGRAM_RANGE_LIST(HR)
|
|
#undef HR
|
|
|
|
#define HT(name, caption, max, res) \
|
|
name##_ = HistogramTimer(#caption, 0, max, HistogramTimer::res, 50, isolate);
|
|
HISTOGRAM_TIMER_LIST(HT)
|
|
#undef HT
|
|
|
|
#define AHT(name, caption) \
|
|
name##_ = AggregatableHistogramTimer(#caption, 0, 10000000, 50, isolate);
|
|
AGGREGATABLE_HISTOGRAM_TIMER_LIST(AHT)
|
|
#undef AHT
|
|
|
|
#define HP(name, caption) \
|
|
name##_ = Histogram(#caption, 0, 101, 100, isolate);
|
|
HISTOGRAM_PERCENTAGE_LIST(HP)
|
|
#undef HP
|
|
|
|
|
|
// Exponential histogram assigns bucket limits to points
|
|
// p[1], p[2], ... p[n] such that p[i+1] / p[i] = constant.
|
|
// The constant factor is equal to the n-th root of (high / low),
|
|
// where the n is the number of buckets, the low is the lower limit,
|
|
// the high is the upper limit.
|
|
// For n = 50, low = 1000, high = 500000: the factor = 1.13.
|
|
#define HM(name, caption) \
|
|
name##_ = Histogram(#caption, 1000, 500000, 50, isolate);
|
|
HISTOGRAM_LEGACY_MEMORY_LIST(HM)
|
|
#undef HM
|
|
// For n = 100, low = 4000, high = 2000000: the factor = 1.06.
|
|
#define HM(name, caption) \
|
|
name##_ = Histogram(#caption, 4000, 2000000, 100, isolate);
|
|
HISTOGRAM_MEMORY_LIST(HM)
|
|
#undef HM
|
|
|
|
#define HM(name, caption) \
|
|
aggregated_##name##_ = AggregatedMemoryHistogram<Histogram>(&name##_);
|
|
HISTOGRAM_MEMORY_LIST(HM)
|
|
#undef HM
|
|
|
|
#define SC(name, caption) \
|
|
name##_ = StatsCounter(isolate, "c:" #caption);
|
|
|
|
STATS_COUNTER_LIST_1(SC)
|
|
STATS_COUNTER_LIST_2(SC)
|
|
#undef SC
|
|
|
|
#define SC(name) \
|
|
count_of_##name##_ = StatsCounter(isolate, "c:" "V8.CountOf_" #name); \
|
|
size_of_##name##_ = StatsCounter(isolate, "c:" "V8.SizeOf_" #name);
|
|
INSTANCE_TYPE_LIST(SC)
|
|
#undef SC
|
|
|
|
#define SC(name) \
|
|
count_of_CODE_TYPE_##name##_ = \
|
|
StatsCounter(isolate, "c:" "V8.CountOf_CODE_TYPE-" #name); \
|
|
size_of_CODE_TYPE_##name##_ = \
|
|
StatsCounter(isolate, "c:" "V8.SizeOf_CODE_TYPE-" #name);
|
|
CODE_KIND_LIST(SC)
|
|
#undef SC
|
|
|
|
#define SC(name) \
|
|
count_of_FIXED_ARRAY_##name##_ = \
|
|
StatsCounter(isolate, "c:" "V8.CountOf_FIXED_ARRAY-" #name); \
|
|
size_of_FIXED_ARRAY_##name##_ = \
|
|
StatsCounter(isolate, "c:" "V8.SizeOf_FIXED_ARRAY-" #name);
|
|
FIXED_ARRAY_SUB_INSTANCE_TYPE_LIST(SC)
|
|
#undef SC
|
|
|
|
#define SC(name) \
|
|
count_of_CODE_AGE_##name##_ = \
|
|
StatsCounter(isolate, "c:" "V8.CountOf_CODE_AGE-" #name); \
|
|
size_of_CODE_AGE_##name##_ = \
|
|
StatsCounter(isolate, "c:" "V8.SizeOf_CODE_AGE-" #name);
|
|
CODE_AGE_LIST_COMPLETE(SC)
|
|
#undef SC
|
|
}
|
|
|
|
|
|
void Counters::ResetCounters() {
|
|
#define SC(name, caption) name##_.Reset();
|
|
STATS_COUNTER_LIST_1(SC)
|
|
STATS_COUNTER_LIST_2(SC)
|
|
#undef SC
|
|
|
|
#define SC(name) \
|
|
count_of_##name##_.Reset(); \
|
|
size_of_##name##_.Reset();
|
|
INSTANCE_TYPE_LIST(SC)
|
|
#undef SC
|
|
|
|
#define SC(name) \
|
|
count_of_CODE_TYPE_##name##_.Reset(); \
|
|
size_of_CODE_TYPE_##name##_.Reset();
|
|
CODE_KIND_LIST(SC)
|
|
#undef SC
|
|
|
|
#define SC(name) \
|
|
count_of_FIXED_ARRAY_##name##_.Reset(); \
|
|
size_of_FIXED_ARRAY_##name##_.Reset();
|
|
FIXED_ARRAY_SUB_INSTANCE_TYPE_LIST(SC)
|
|
#undef SC
|
|
|
|
#define SC(name) \
|
|
count_of_CODE_AGE_##name##_.Reset(); \
|
|
size_of_CODE_AGE_##name##_.Reset();
|
|
CODE_AGE_LIST_COMPLETE(SC)
|
|
#undef SC
|
|
}
|
|
|
|
|
|
void Counters::ResetHistograms() {
|
|
#define HR(name, caption, min, max, num_buckets) name##_.Reset();
|
|
HISTOGRAM_RANGE_LIST(HR)
|
|
#undef HR
|
|
|
|
#define HT(name, caption, max, res) name##_.Reset();
|
|
HISTOGRAM_TIMER_LIST(HT)
|
|
#undef HT
|
|
|
|
#define AHT(name, caption) name##_.Reset();
|
|
AGGREGATABLE_HISTOGRAM_TIMER_LIST(AHT)
|
|
#undef AHT
|
|
|
|
#define HP(name, caption) name##_.Reset();
|
|
HISTOGRAM_PERCENTAGE_LIST(HP)
|
|
#undef HP
|
|
|
|
#define HM(name, caption) name##_.Reset();
|
|
HISTOGRAM_LEGACY_MEMORY_LIST(HM)
|
|
#undef HM
|
|
}
|
|
|
|
class RuntimeCallStatEntries {
|
|
public:
|
|
void Print(std::ostream& os) {
|
|
if (total_call_count == 0) return;
|
|
std::sort(entries.rbegin(), entries.rend());
|
|
os << std::setw(50) << "Runtime Function/C++ Builtin" << std::setw(12)
|
|
<< "Time" << std::setw(18) << "Count" << std::endl
|
|
<< std::string(88, '=') << std::endl;
|
|
for (Entry& entry : entries) {
|
|
entry.SetTotal(total_time, total_call_count);
|
|
entry.Print(os);
|
|
}
|
|
os << std::string(88, '-') << std::endl;
|
|
Entry("Total", total_time, total_call_count).Print(os);
|
|
}
|
|
|
|
// By default, the compiler will usually inline this, which results in a large
|
|
// binary size increase: std::vector::push_back expands to a large amount of
|
|
// instructions, and this function is invoked repeatedly by macros.
|
|
V8_NOINLINE void Add(RuntimeCallCounter* counter) {
|
|
if (counter->count == 0) return;
|
|
entries.push_back(Entry(counter->name, counter->time, counter->count));
|
|
total_time += counter->time;
|
|
total_call_count += counter->count;
|
|
}
|
|
|
|
private:
|
|
class Entry {
|
|
public:
|
|
Entry(const char* name, base::TimeDelta time, uint64_t count)
|
|
: name_(name),
|
|
time_(time.InMicroseconds()),
|
|
count_(count),
|
|
time_percent_(100),
|
|
count_percent_(100) {}
|
|
|
|
bool operator<(const Entry& other) const {
|
|
if (time_ < other.time_) return true;
|
|
if (time_ > other.time_) return false;
|
|
return count_ < other.count_;
|
|
}
|
|
|
|
V8_NOINLINE void Print(std::ostream& os) {
|
|
os.precision(2);
|
|
os << std::fixed << std::setprecision(2);
|
|
os << std::setw(50) << name_;
|
|
os << std::setw(10) << static_cast<double>(time_) / 1000 << "ms ";
|
|
os << std::setw(6) << time_percent_ << "%";
|
|
os << std::setw(10) << count_ << " ";
|
|
os << std::setw(6) << count_percent_ << "%";
|
|
os << std::endl;
|
|
}
|
|
|
|
V8_NOINLINE void SetTotal(base::TimeDelta total_time,
|
|
uint64_t total_count) {
|
|
if (total_time.InMicroseconds() == 0) {
|
|
time_percent_ = 0;
|
|
} else {
|
|
time_percent_ = 100.0 * time_ / total_time.InMicroseconds();
|
|
}
|
|
count_percent_ = 100.0 * count_ / total_count;
|
|
}
|
|
|
|
private:
|
|
const char* name_;
|
|
int64_t time_;
|
|
uint64_t count_;
|
|
double time_percent_;
|
|
double count_percent_;
|
|
};
|
|
|
|
uint64_t total_call_count = 0;
|
|
base::TimeDelta total_time;
|
|
std::vector<Entry> entries;
|
|
};
|
|
|
|
void RuntimeCallCounter::Reset() {
|
|
count = 0;
|
|
time = base::TimeDelta();
|
|
}
|
|
|
|
void RuntimeCallCounter::Dump(v8::tracing::TracedValue* value) {
|
|
value->BeginArray(name);
|
|
value->AppendLongInteger(count);
|
|
value->AppendLongInteger(time.InMicroseconds());
|
|
value->EndArray();
|
|
}
|
|
|
|
void RuntimeCallCounter::Add(RuntimeCallCounter* other) {
|
|
count += other->count;
|
|
time += other->time;
|
|
}
|
|
|
|
// static
|
|
const RuntimeCallStats::CounterId RuntimeCallStats::counters[] = {
|
|
#define CALL_RUNTIME_COUNTER(name) &RuntimeCallStats::name,
|
|
FOR_EACH_MANUAL_COUNTER(CALL_RUNTIME_COUNTER) //
|
|
#undef CALL_RUNTIME_COUNTER
|
|
#define CALL_RUNTIME_COUNTER(name, nargs, ressize) \
|
|
&RuntimeCallStats::Runtime_##name, //
|
|
FOR_EACH_INTRINSIC(CALL_RUNTIME_COUNTER) //
|
|
#undef CALL_RUNTIME_COUNTER
|
|
#define CALL_BUILTIN_COUNTER(name) &RuntimeCallStats::Builtin_##name,
|
|
BUILTIN_LIST_C(CALL_BUILTIN_COUNTER) //
|
|
#undef CALL_BUILTIN_COUNTER
|
|
#define CALL_BUILTIN_COUNTER(name) &RuntimeCallStats::API_##name,
|
|
FOR_EACH_API_COUNTER(CALL_BUILTIN_COUNTER) //
|
|
#undef CALL_BUILTIN_COUNTER
|
|
#define CALL_BUILTIN_COUNTER(name) &RuntimeCallStats::Handler_##name,
|
|
FOR_EACH_HANDLER_COUNTER(CALL_BUILTIN_COUNTER)
|
|
#undef CALL_BUILTIN_COUNTER
|
|
};
|
|
|
|
// static
|
|
void RuntimeCallStats::Enter(RuntimeCallStats* stats, RuntimeCallTimer* timer,
|
|
CounterId counter_id) {
|
|
RuntimeCallCounter* counter = &(stats->*counter_id);
|
|
DCHECK(counter->name != nullptr);
|
|
timer->Start(counter, stats->current_timer_.Value());
|
|
stats->current_timer_.SetValue(timer);
|
|
}
|
|
|
|
// static
|
|
void RuntimeCallStats::Leave(RuntimeCallStats* stats, RuntimeCallTimer* timer) {
|
|
if (stats->current_timer_.Value() == timer) {
|
|
stats->current_timer_.SetValue(timer->Stop());
|
|
} else {
|
|
// Must be a Threading cctest. Walk the chain of Timers to find the
|
|
// buried one that's leaving. We don't care about keeping nested timings
|
|
// accurate, just avoid crashing by keeping the chain intact.
|
|
RuntimeCallTimer* next = stats->current_timer_.Value();
|
|
while (next && next->parent() != timer) next = next->parent();
|
|
if (next == nullptr) return;
|
|
next->parent_.SetValue(timer->Stop());
|
|
}
|
|
}
|
|
|
|
void RuntimeCallStats::Add(RuntimeCallStats* other) {
|
|
for (const RuntimeCallStats::CounterId counter_id :
|
|
RuntimeCallStats::counters) {
|
|
RuntimeCallCounter* counter = &(this->*counter_id);
|
|
RuntimeCallCounter* other_counter = &(other->*counter_id);
|
|
counter->Add(other_counter);
|
|
}
|
|
}
|
|
|
|
// static
|
|
void RuntimeCallStats::CorrectCurrentCounterId(RuntimeCallStats* stats,
|
|
CounterId counter_id) {
|
|
RuntimeCallTimer* timer = stats->current_timer_.Value();
|
|
// When RCS are enabled dynamically there might be no current timer set up.
|
|
if (timer == nullptr) return;
|
|
timer->counter_ = &(stats->*counter_id);
|
|
}
|
|
|
|
void RuntimeCallStats::Print(std::ostream& os) {
|
|
RuntimeCallStatEntries entries;
|
|
if (current_timer_.Value() != nullptr) {
|
|
current_timer_.Value()->Elapsed();
|
|
}
|
|
for (const RuntimeCallStats::CounterId counter_id :
|
|
RuntimeCallStats::counters) {
|
|
RuntimeCallCounter* counter = &(this->*counter_id);
|
|
entries.Add(counter);
|
|
}
|
|
entries.Print(os);
|
|
}
|
|
|
|
void RuntimeCallStats::Reset() {
|
|
if (V8_LIKELY(FLAG_runtime_stats == 0)) return;
|
|
|
|
// In tracing, we only what to trace the time spent on top level trace events,
|
|
// if runtime counter stack is not empty, we should clear the whole runtime
|
|
// counter stack, and then reset counters so that we can dump counters into
|
|
// top level trace events accurately.
|
|
while (current_timer_.Value()) {
|
|
current_timer_.SetValue(current_timer_.Value()->Stop());
|
|
}
|
|
|
|
for (const RuntimeCallStats::CounterId counter_id :
|
|
RuntimeCallStats::counters) {
|
|
RuntimeCallCounter* counter = &(this->*counter_id);
|
|
counter->Reset();
|
|
}
|
|
|
|
in_use_ = true;
|
|
}
|
|
|
|
void RuntimeCallStats::Dump(v8::tracing::TracedValue* value) {
|
|
for (const RuntimeCallStats::CounterId counter_id :
|
|
RuntimeCallStats::counters) {
|
|
RuntimeCallCounter* counter = &(this->*counter_id);
|
|
if (counter->count > 0) counter->Dump(value);
|
|
}
|
|
|
|
in_use_ = false;
|
|
}
|
|
|
|
} // namespace internal
|
|
} // namespace v8
|