v8/test/mjsunit/for-in-special-cases.js
Toon Verwaest 21ad38ef83 Revert "[runtime] Cache prototype chain enumerable keys in PrototypeInfo"
This reverts commit 5253d7bf15.

Reason for revert: Elements don't properly invalidate the cache.

Original change's description:
> [runtime] Cache prototype chain enumerable keys in PrototypeInfo
> 
> This CL adds a prototype_chain_enum_cache to cache the enumeration of a
> prototype and its entire chain on the PrototypeInfo. It can improve for-in
> performance via simply merging the receiver enumeration with this cache.
> 
> It improves the score of JetStream2-tagcloud-SP case by ~9% on IA Chromebook.
> 
> Contributed by tao.pan@intel.com
> 
> Change-Id: Ib40bfe41e772672337155584672f06fa1ba1e70d
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1870844
> Commit-Queue: Shiyu Zhang <shiyu.zhang@intel.com>
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#65224}

TBR=verwaest@chromium.org,shiyu.zhang@intel.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Ic5d476bc8b334241b2accb8344749fcf7dcf5e09
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1943153
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Commit-Queue: Toon Verwaest <verwaest@chromium.org>
Auto-Submit: Toon Verwaest <verwaest@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65259}
2019-11-29 11:42:29 +00:00

144 lines
4.2 KiB
JavaScript

// Copyright 2008 the V8 project authors. All rights reserved.
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are
// met:
//
// * Redistributions of source code must retain the above copyright
// notice, this list of conditions and the following disclaimer.
// * Redistributions in binary form must reproduce the above
// copyright notice, this list of conditions and the following
// disclaimer in the documentation and/or other materials provided
// with the distribution.
// * Neither the name of Google Inc. nor the names of its
// contributors may be used to endorse or promote products derived
// from this software without specific prior written permission.
//
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
// Flags: --expose-gc
function for_in_null() {
try {
for (var x in null) {
return false;
}
} catch(e) {
return false;
}
return true;
}
function for_in_undefined() {
try {
for (var x in undefined) {
return false;
}
} catch(e) {
return false;
}
return true;
}
for (var i = 0; i < 10; ++i) {
assertTrue(for_in_null());
gc();
}
for (var j = 0; j < 10; ++j) {
assertTrue(for_in_undefined());
gc();
}
assertEquals(10, i);
assertEquals(10, j);
function Accumulate(x) {
var accumulator = [];
for (var i in x) {
accumulator.push(i);
}
return accumulator;
}
for (var i = 0; i < 3; ++i) {
assertEquals(Accumulate("abcd"), ['0', '1', '2', '3']);
}
function for_in_string_prototype() {
var x = new String("abc");
x.foo = 19;
function B() {
this.bar = 5;
this[7] = 4;
}
B.prototype = x;
var y = new B();
y.gub = 13;
var elements = Accumulate(y);
var elements1 = Accumulate(y);
// If for-in returns elements in a different order on multiple calls, this
// assert will fail. If that happens, consider if that behavior is OK.
assertEquals(elements, elements1, "For-in elements not the same both times.");
assertEquals(["7","bar","gub","0","1","2","foo"], elements)
assertEquals(['0', '1', '2', 'foo'], Accumulate(x))
}
for_in_string_prototype();
for_in_string_prototype();
(function for_in_dictionary_prototype_1() {
let prototype1 = {prop: 0, prop1: 1};
let derived1 = Object.create(null, {
prop: {enumerable: false, configurable: true, value: 0},
});
Object.setPrototypeOf(derived1, prototype1);
let prototype2 = {prop: 0, prop1: 1};
let derived2 = Object.create(prototype2, {
prop: {enumerable: false, configurable: true, value: 0},
});
for (let i = 0; i < 3; i++) {
assertEquals(['prop1'], Accumulate(derived1));
assertEquals(['prop1'], Accumulate(derived2));
}
})();
(function for_in_dictionary_prototype_2() {
let prototype1 = {prop: 0, prop1: 1};
let derived1 = Object.create(null, {
prop: {enumerable: false, configurable: true, value: 1},
prop2: {enumerable: true, configurable: true, value: 2},
prop3: {enumerable: false, configurable: true, value: 3},
});
Object.setPrototypeOf(derived1, prototype1);
let prototype2 = {prop: 0, prop1: 1};
let derived2 = Object.create(prototype2, {
prop: {enumerable: false, configurable: true, value: 0},
prop2: {enumerable: true, configurable: true, value: 2},
prop3: {enumerable: false, configurable: true, value: 3},
});
for (let i = 0; i < 3; i++) {
assertEquals(['prop2', 'prop1'], Accumulate(derived1));
assertEquals(['prop2', 'prop1'], Accumulate(derived2));
}
})();