62f8337742
This reverts commit 4851745fe3.
Reason for revert: Top crasher on Canary, see https://crbug.com/746935
Original change's description:
> [literals] Introduce CreateEmptyArrayLiteral Bytecode
>
> Empty Array literals are amongst the most commonly used literal types on our
> top25 page list. Using a custom bytecode we can drop the boilerplate for empty
> Array literals alltogether. However, we still need a proper AllocationSite to
> track ElementsKind transitions.
>
> Bug: v8:6211
> Change-Id: Id5dbdac0ea8e24dd474e679c902c6e4a2957af1d
> Reviewed-on: https://chromium-review.googlesource.com/567079
> Commit-Queue: Camillo Bruni <cbruni@chromium.org>
> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
> Reviewed-by: Igor Sheludko <ishell@chromium.org>
> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#46752}
TBR=rmcilroy@chromium.org,mstarzinger@chromium.org,cbruni@chromium.org,ishell@chromium.org,rmcilroy@google.com
Bug: v8:6211, chromium:746935
Change-Id: Ibf19a923688c071d03bad8661a10e08f8414db56
Reviewed-on: https://chromium-review.googlesource.com/580193
Commit-Queue: Adam Klein <adamk@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#46804}
108 lines
4.0 KiB
JavaScript
108 lines
4.0 KiB
JavaScript
// Copyright 2013 the V8 project authors. All rights reserved.
|
|
// Redistribution and use in source and binary forms, with or without
|
|
// modification, are permitted provided that the following conditions are
|
|
// met:
|
|
//
|
|
// * Redistributions of source code must retain the above copyright
|
|
// notice, this list of conditions and the following disclaimer.
|
|
// * Redistributions in binary form must reproduce the above
|
|
// copyright notice, this list of conditions and the following
|
|
// disclaimer in the documentation and/or other materials provided
|
|
// with the distribution.
|
|
// * Neither the name of Google Inc. nor the names of its
|
|
// contributors may be used to endorse or promote products derived
|
|
// from this software without specific prior written permission.
|
|
//
|
|
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
// Flags: --allow-natives-syntax --expose-gc
|
|
// Flags: --opt --no-always-opt --no-stress-fullcodegen
|
|
|
|
var elements_kind = {
|
|
fast_smi_only : 'fast smi only elements',
|
|
fast : 'fast elements',
|
|
fast_double : 'fast double elements',
|
|
dictionary : 'dictionary elements',
|
|
external_byte : 'external byte elements',
|
|
external_unsigned_byte : 'external unsigned byte elements',
|
|
external_short : 'external short elements',
|
|
external_unsigned_short : 'external unsigned short elements',
|
|
external_int : 'external int elements',
|
|
external_unsigned_int : 'external unsigned int elements',
|
|
external_float : 'external float elements',
|
|
external_double : 'external double elements',
|
|
external_pixel : 'external pixel elements'
|
|
}
|
|
|
|
function getKind(obj) {
|
|
if (%HasSmiElements(obj)) return elements_kind.fast_smi_only;
|
|
if (%HasObjectElements(obj)) return elements_kind.fast;
|
|
if (%HasDoubleElements(obj)) return elements_kind.fast_double;
|
|
if (%HasDictionaryElements(obj)) return elements_kind.dictionary;
|
|
}
|
|
|
|
function isHoley(obj) {
|
|
if (%HasHoleyElements(obj)) return true;
|
|
return false;
|
|
}
|
|
|
|
function assertKind(expected, obj, name_opt) {
|
|
assertEquals(expected, getKind(obj), name_opt);
|
|
}
|
|
|
|
function get_literal(x) {
|
|
var literal = [1, 2, x];
|
|
return literal;
|
|
}
|
|
|
|
get_literal(3);
|
|
// It's important to store a from before we crankshaft get_literal, because
|
|
// mementos won't be created from crankshafted code at all.
|
|
a = get_literal(3);
|
|
%OptimizeFunctionOnNextCall(get_literal);
|
|
get_literal(3);
|
|
assertOptimized(get_literal);
|
|
assertTrue(%HasSmiElements(a));
|
|
// a has a memento so the transition caused by the store will affect the
|
|
// boilerplate.
|
|
a[0] = 3.5;
|
|
|
|
// We should have transitioned the boilerplate array to double, and
|
|
// crankshafted code should de-opt on the unexpected elements kind
|
|
b = get_literal(3);
|
|
assertTrue(%HasDoubleElements(b));
|
|
assertEquals([1, 2, 3], b);
|
|
assertUnoptimized(get_literal);
|
|
|
|
// Optimize again
|
|
get_literal(3);
|
|
%OptimizeFunctionOnNextCall(get_literal);
|
|
b = get_literal(3);
|
|
assertTrue(%HasDoubleElements(b));
|
|
assertOptimized(get_literal);
|
|
|
|
|
|
// Test: make sure allocation site information is updated through a
|
|
// transition from SMI->DOUBLE->FAST
|
|
(function() {
|
|
function bar(a, b, c) {
|
|
return [a, b, c];
|
|
}
|
|
|
|
a = bar(1, 2, 3);
|
|
a[0] = 3.5;
|
|
a[1] = 'hi';
|
|
b = bar(1, 2, 3);
|
|
assertKind(elements_kind.fast, b);
|
|
})();
|