v8/test/debugger/regress
Clemens Backes 724b2eb416 Revert "[wasm] Send a single scriptParsed event per script"
This reverts commit b471bc9318.

Reason for revert: Seems like we don't reliably deliver scriptParsed events on reload after this CL.

Original change's description:
> [wasm] Send a single scriptParsed event per script
>
> If a script was shared between multiple modules (because they used the
> same wire bytes) it could happen that we still triggered multiple
> "scriptParsed" events via CDP. This was because
> {WasmEngine::GetOrCreateScript} did not communicate back whether it
> used a cached script or whether it created a new one.
>
> This CL moves the call to {Debug::OnAfterCompile} (which triggers the
> "scriptParsed" event) to the {WasmEngine::GetOrCreateScript} method,
> such that we only call it once per script.
> Since the engine only holds a weak reference to the script, we would
> still trigger multiple events if the script is garbage-collected in the
> meantime. In this case there is no way around this, as the new script
> would have a new ID, hence we need to emit a new event to make it
> public to the debugger.
>
> R=​thibaudm@chromium.org
> CC=​bmeurer@chromium.org
>
> Bug: chromium:1151211
> Change-Id: I1a7986514fd708680541a0e5dc24e60f01f42c28
> Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_isolates_rel_ng
> Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng
> Cq-Include-Trybots: luci.v8.try:v8_mac64_gc_stress_dbg_ng
> Cq-Include-Trybots: luci.v8.try:v8_linux_gc_stress_dbg_ng
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2687755
> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
> Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
> Commit-Queue: Clemens Backes <clemensb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#72648}

TBR=clemensb@chromium.org,bmeurer@chromium.org,thibaudm@chromium.org

Change-Id: I6cc299734e4fcff29289355973e7660b60b49a25
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1151211
Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_isolates_rel_ng
Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng
Cq-Include-Trybots: luci.v8.try:v8_mac64_gc_stress_dbg_ng
Cq-Include-Trybots: luci.v8.try:v8_linux_gc_stress_dbg_ng
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2689199
Reviewed-by: Clemens Backes <clemensb@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#72667}
2021-02-11 16:35:35 +00:00
..
regress-1639-2.js [tests] Fix assertFalse(exception) anti-pattern 2018-03-21 10:59:46 +00:00
regress-2318.js [inspector] gracefully handle stack overflows in the inspector. 2016-12-19 14:07:55 +00:00
regress-5575-1.js [debugger,compiler] do not recompile already compiled inner functions. 2016-11-11 15:53:33 +00:00
regress-5575-2.js [debugger,compiler] do not recompile already compiled inner functions. 2016-11-11 15:53:33 +00:00
regress-5575-3.js [debugger,compiler] do not recompile already compiled inner functions. 2016-11-11 15:53:33 +00:00
regress-5610.js [async] Improve async function handling. 2018-10-10 06:37:53 +00:00
regress-5901-1.js [Test] Add PrepareForOptimization to debugger/ tests. 2019-04-29 13:47:16 +00:00
regress-5901-2.js [Test] Add PrepareForOptimization to debugger/ tests. 2019-04-29 13:47:16 +00:00
regress-5950.js [Test] Add PrepareForOptimization to debugger/ tests. 2019-04-29 13:47:16 +00:00
regress-6085.js [debugger] fix switch block source positions. 2017-03-13 12:47:48 +00:00
regress-6526.js [Test] Add PrepareForOptimization to debugger/ tests. 2019-04-29 13:47:16 +00:00
regress-7421.js [cleanup] Add %PrepareFunctionForOptimize for tests that use %OptimizeOsr 2019-06-18 16:47:29 +00:00
regress-9482.js Add test for debug evaluating a previously non-whitelisted variable 2019-09-11 09:45:33 +00:00
regress-crbug-10132.js [debug] Collect source positions Debug::PrintBreakLocation 2020-01-21 12:07:03 +00:00
regress-crbug-507070.js [debug] remove legacy implementation for break points. 2018-02-26 10:01:39 +00:00
regress-crbug-724858.js [inspector] improve return position of explicit return in non-async function 2017-07-14 19:10:13 +00:00
regress-crbug-736758.js [Test] Add PrepareForOptimization to debugger/ tests. 2019-04-29 13:47:16 +00:00
regress-crbug-760225.js [debugger] Fix debug-evaluate for context-allocated this. 2019-07-05 12:14:35 +00:00
regress-crbug-808973.js [d8] Exit with error code upon unhandled promise rejection 2020-06-24 07:21:58 +00:00
regress-crbug-835973.js [interpreter] correctly advance over debug scaling prefixes. 2018-05-03 07:02:57 +00:00
regress-crbug-840288.js Report real module in addition to fake scripts 2019-11-15 09:59:58 +00:00
regress-crbug-882664.js [debug] fix scaling prefix patching for debug evaluate 2018-09-14 14:33:07 +00:00
regress-crbug-1032042.js Revert "[wasm] Send a single scriptParsed event per script" 2021-02-11 16:35:35 +00:00