d1b4e31bc5
Since it's explicit what we're tracking, we can immediately throw errors in certain cases, and ignore irrelevant errors. We don't need to use the classifier itself to track "let let", since we know whether we're parsing a "let". Errors that were previously (almost) always accumulated are now immediately pushed to the scopes that care (parameter initialization errors). This CL drops avoiding allocation of classified errors, at least for now, but that doesn't affect performance anymore since we don't aggressively blacklist anymore. Classified errors are even less likely with the more precise approach. ParseAssignmentExpression doesn't introduce its own scope immediately, but reuses the outer scope. Rather than using full ExpressionClassifiers + Accumulate to separate expressions/patterns from each other while keeping track of the overall error state, this now uses an explicit AccumulationScope. When we parse (async) arrow functions we introduce new scopes that track that they may be (async) arrow functions. We track StrictModeFormal parameters in 2 different ways if it isn't immediately certain that it is a strict-mode formal error: Either directly on the (Pre)ParserFormalParameters, or on the NextArrowFunctionInfo in the case we're not yet certain that we'll have an arrow function. In the latter case we don't have a FormalParameter object yet, and we'll copy it over once we know we're parsing an arrow function. The latter works because it's not allowed to change strictness of a function with non-simple parameters. Design doc: https://docs.google.com/document/d/1FAvEp9EUK-G8kHfDIEo_385Hs2SUBCYbJ5H-NnLvq8M/ Change-Id: If4ecd717c9780095c7ddc859c8945b3d7d268a9d Reviewed-on: https://chromium-review.googlesource.com/c/1367809 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#58307} |
||
|---|---|---|
| .. | ||
| fail | ||
| mjsunit | ||
| regress/fail | ||
| asm-assignment-undeclared.js | ||
| asm-assignment-undeclared.out | ||
| asm-function-mismatch-def.js | ||
| asm-function-mismatch-def.out | ||
| asm-function-mismatch-use.js | ||
| asm-function-mismatch-use.out | ||
| asm-function-redefined.js | ||
| asm-function-redefined.out | ||
| asm-function-undefined.js | ||
| asm-function-undefined.out | ||
| asm-function-variable-collision.js | ||
| asm-function-variable-collision.out | ||
| asm-import-wrong-annotation.js | ||
| asm-import-wrong-annotation.out | ||
| asm-import-wrong-object.js | ||
| asm-import-wrong-object.out | ||
| asm-linking-bogus-heap.js | ||
| asm-linking-bogus-heap.out | ||
| asm-linking-bogus-stdlib.js | ||
| asm-linking-bogus-stdlib.out | ||
| asm-linking-missing-heap.js | ||
| asm-linking-missing-heap.out | ||
| asm-missing-parameter-annotation.js | ||
| asm-missing-parameter-annotation.out | ||
| asm-missing-return-annotation.js | ||
| asm-missing-return-annotation.out | ||
| asm-table-mismatch-def.js | ||
| asm-table-mismatch-def.out | ||
| asm-table-mismatch-use.js | ||
| asm-table-mismatch-use.out | ||
| asm-table-redefined.js | ||
| asm-table-redefined.out | ||
| asm-table-undefined.js | ||
| asm-table-undefined.out | ||
| asm-table-variable-collision.js | ||
| asm-table-variable-collision.out | ||
| BUILD.gn | ||
| message.status | ||
| non-use-strict-hex-escape.js | ||
| non-use-strict-hex-escape.out | ||
| non-use-strict-octal-escape.js | ||
| non-use-strict-octal-escape.out | ||
| non-use-strict-uhex-escape.js | ||
| non-use-strict-uhex-escape.out | ||
| nonstrict-arguments.js | ||
| nonstrict-arguments.out | ||
| nonstrict-eval.js | ||
| nonstrict-eval.out | ||
| nonstrict-with.js | ||
| nonstrict-with.out | ||
| object-binding-pattern-await-computed-name.js | ||
| object-binding-pattern-await-computed-name.out | ||
| README.md | ||
| strict-octal-indirect-regexp.js | ||
| strict-octal-indirect-regexp.out | ||
| strict-octal-regexp.js | ||
| strict-octal-regexp.out | ||
| testcfg.py | ||
| try-catch-finally-no-message.js | ||
| try-catch-finally-no-message.out | ||
| try-catch-finally-return-in-finally.js | ||
| try-catch-finally-return-in-finally.out | ||
| try-finally-return-in-finally.js | ||
| try-finally-return-in-finally.out | ||
| wasm-finish-compilation.js | ||
| wasm-finish-compilation.out | ||
| wasm-function-name-async.js | ||
| wasm-function-name-async.out | ||
| wasm-function-name-streaming.js | ||
| wasm-function-name-streaming.out | ||
| wasm-module-and-function-name-async.js | ||
| wasm-module-and-function-name-async.out | ||
| wasm-module-and-function-name-streaming.js | ||
| wasm-module-and-function-name-streaming.out | ||
| wasm-module-name-async.js | ||
| wasm-module-name-async.out | ||
| wasm-module-name-streaming.js | ||
| wasm-module-name-streaming.out | ||
| wasm-no-name-async.js | ||
| wasm-no-name-async.out | ||
| wasm-no-name-streaming.js | ||
| wasm-no-name-streaming.out | ||
| wasm-trace-memory-interpreted.js | ||
| wasm-trace-memory-interpreted.out | ||
| wasm-trace-memory-liftoff.js | ||
| wasm-trace-memory-liftoff.out | ||
| wasm-trace-memory.js | ||
| wasm-trace-memory.out | ||
JavaScript tests with expected output
Tests in test/message pass if the output matches the expected output.
Message tests are particularly useful when checking for exact error messages.
Tests and their expected output must have the same filename, with the .js and
.out extension.
foo.js
foo.out
All tests must end with an exception. The test runner does not
handle output from multiple runs, e.g., --stress-opt. Without an exception,
the output will be generated several times and the comparison will fail.
You can use a regex in the expected output instead of the exact path:
*%(basename)s:7: SyntaxError: Detected cycle while resolving name 'a'
Empty lines are ignored in the comparison, but whitespaces are not.
Exact details of the test runner are in testcfg.py.