c0fd89c3c0
This is a reland of819c3ae2f8Original change's description: > Reland "Reland "Improve error messages for property access on null/undefined"" > > This is a reland of8b18c5e6a5> > Original change's description: > > Reland "Improve error messages for property access on null/undefined" > > > > This is a reland of24c626c1f7> > > > Original change's description: > > > Improve error messages for property access on null/undefined > > > > > > Only print the property name when accessing null/undefined if we can > > > convert it to a string without causing side effects. > > > If we can't, omit the property name in the error message. > > > This should avoid confusion when the key is an object with toString(). > > > E.g. undefined[{toString:()=>'a'}] doesn't print 'read property [object > > > Object]' anymore, which was misleading since the property accessed would > > > be 'a', but we can't evaluate the key without side effects. > > > > > > Bug: v8:11365 > > > Change-Id: If82d1adb42561d4851e2bd2ca297a1c71738aee8 > > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2960211 > > > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > > > Commit-Queue: Patrick Thier <pthier@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#75250} > > > > Bug: v8:11365 > > Change-Id: Ie2312337f4f1915faa31528a728d90833d80dbd1 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2979599 > > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > > Commit-Queue: Patrick Thier <pthier@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#75571} > > Bug: v8:11365 > Change-Id: I90360641ecd870bd93247aa6d91dfb0ad049cfb8 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3008219 > Auto-Submit: Patrick Thier <pthier@chromium.org> > Commit-Queue: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75604} Bug: v8:11365 Change-Id: I002b537144f328ccbbdcd655e26e5dc87c49c6f5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3013935 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/master@{#75645}
39 lines
844 B
JavaScript
39 lines
844 B
JavaScript
// Copyright 2016 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
|
|
// Test that debug-evaluate doesn't crash when this is used before super() call
|
|
// in constructor.
|
|
|
|
Debug = debug.Debug
|
|
|
|
var result;
|
|
|
|
function listener(event, exec_state, event_data, data)
|
|
{
|
|
try {
|
|
if (event == Debug.DebugEvent.Break) {
|
|
result = exec_state.frame(0).evaluate("this.a").value();
|
|
}
|
|
} catch (e) {
|
|
result = e.message;
|
|
}
|
|
}
|
|
|
|
Debug.setListener(listener);
|
|
|
|
class A { constructor () { this.a = 239; } }
|
|
class B extends A {
|
|
constructor () {
|
|
debugger;
|
|
assertTrue(result.indexOf("Cannot read properties of undefined (reading 'a')") >= 0);
|
|
super();
|
|
debugger;
|
|
assertEquals(239, result);
|
|
}
|
|
}
|
|
new B();
|
|
|
|
Debug.setListener(null);
|