c2d239ddb3
This is a reland of commit c8c176190a
This CL includes:
- crrev.com/c/3679846 Add condition use_ic to the removing the optimized OSR code logic
- crrev.com/c/3686589 Add out of bytecode array to break condition of removing OSR code cache logic
- Add JumpLoop nesting level 0 to break condition of removing OSR code cache logic
- Change to use Deoptimizer::DeoptimizeFunction() to deoptimize OSR code
Original change's description:
> [compiler] Remove the optimized OSR code if deoptimizing at inside of loop
>
> If the optimized code is deoptimized and the deoptimized exit offset is
> inside of the optimized OSR code related loop, the optimized OSR code is
> also out of date, remove the optimized OSR code, it will avoid hit the
> optimized OSR code and soon later deoptimization of the optimized OSR
> code.
> This CL will reduce deoptimization. E.g. Deoptimization of JetStream2
> case navier-stokes function addFields is reduced from twice to once.
>
> Change-Id: I5bbf3039e916c3736b5b967d1f36b6ea90cfd40b
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3648219
> Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> Commit-Queue: Tao Pan <tao.pan@intel.com>
> Cr-Commit-Position: refs/heads/main@{#80826}
Bug: chromium:1330444
Change-Id: I97a466ddfa764438b45f33c6ae33cb921d57278d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3690451
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Tao Pan <tao.pan@intel.com>
Cr-Commit-Position: refs/heads/main@{#81110}
140 lines
2.9 KiB
JavaScript
140 lines
2.9 KiB
JavaScript
// Copyright 2015 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --interrupt-budget=100 --deopt-every-n-times=4
|
|
// Flags: --allow-natives-syntax --use-osr
|
|
|
|
"use strict";
|
|
|
|
function nest(body, name, depth) {
|
|
var header = "";
|
|
for (var i = 0; i < depth; i++) {
|
|
var x = "x" + (i + 1);
|
|
header += " for(var " + x + " = 0; " + x + " < 2; " + x + " = " + x + " + 1 | 0) {\n";
|
|
body = body + "}"
|
|
}
|
|
|
|
// Replace function name
|
|
var new_func = body.replace(new RegExp("function " + name + "\\(\\) {"),
|
|
"function " + name + "_" + x + "() {\n" + header);
|
|
|
|
// Replace PrepareForOptimize
|
|
return new_func.replace(new RegExp("%PrepareFunctionForOptimization\\(" + name + "\\);"),
|
|
"%PrepareFunctionForOptimization(" + name + "_" + x + ");");
|
|
}
|
|
|
|
function test(expected, func, depth) {
|
|
%PrepareFunctionForOptimization(func);
|
|
assertEquals(expected, func());
|
|
%PrepareFunctionForOptimization(func);
|
|
assertEquals(expected, func());
|
|
%PrepareFunctionForOptimization(func);
|
|
assertEquals(expected, func());
|
|
|
|
var orig = func.toString();
|
|
var name = func.name;
|
|
for (var depth = 1; depth < 4; depth++) {
|
|
var body = nest(orig, name, depth);
|
|
func = eval("(" + body + ")");
|
|
|
|
%PrepareFunctionForOptimization(func);
|
|
assertEquals(expected, func());
|
|
%PrepareFunctionForOptimization(func);
|
|
assertEquals(expected, func());
|
|
%PrepareFunctionForOptimization(func);
|
|
assertEquals(expected, func());
|
|
}
|
|
}
|
|
|
|
function foo() {
|
|
var result;
|
|
{
|
|
let sum = 0;
|
|
for (var i = 0; i < 10; i++) {
|
|
%OptimizeOsr();
|
|
sum += i;
|
|
%PrepareFunctionForOptimization(foo);
|
|
}
|
|
result = sum;
|
|
}
|
|
return result;
|
|
}
|
|
%PrepareFunctionForOptimization(foo);
|
|
|
|
test(45, foo);
|
|
|
|
function bar() {
|
|
let sum = 0;
|
|
for (var i = 0; i < 10; i++) {
|
|
%OptimizeOsr();
|
|
sum += i;
|
|
%PrepareFunctionForOptimization(bar);
|
|
}
|
|
return sum;
|
|
}
|
|
%PrepareFunctionForOptimization(bar);
|
|
|
|
test(45, bar);
|
|
|
|
function bon() {
|
|
{
|
|
let sum = 0;
|
|
for (var i = 0; i < 10; i++) {
|
|
if (i == 5) %OptimizeOsr();
|
|
sum += i;
|
|
}
|
|
return sum;
|
|
}
|
|
}
|
|
%PrepareFunctionForOptimization(bon);
|
|
|
|
test(45, bon);
|
|
|
|
function row() {
|
|
var i = 0;
|
|
{
|
|
let sum = 0;
|
|
while (true) {
|
|
if (i == 8) return sum;
|
|
%OptimizeOsr();
|
|
sum = i;
|
|
i = i + 1 | 0;
|
|
%PrepareFunctionForOptimization(row);
|
|
}
|
|
}
|
|
return 11;
|
|
}
|
|
%PrepareFunctionForOptimization(row);
|
|
|
|
test(7, row);
|
|
|
|
function nub() {
|
|
let i = 0;
|
|
while (i < 2) {
|
|
%OptimizeOsr();
|
|
i++;
|
|
%PrepareFunctionForOptimization(nub);
|
|
}
|
|
return i;
|
|
}
|
|
%PrepareFunctionForOptimization(nub);
|
|
|
|
test(2, nub);
|
|
|
|
function kub() {
|
|
var result = 0;
|
|
let i = 0;
|
|
while (i < 2) {
|
|
let x = i;
|
|
%OptimizeOsr();
|
|
i++;
|
|
result = x;
|
|
%PrepareFunctionForOptimization(kub);
|
|
}
|
|
return result;
|
|
}
|
|
%PrepareFunctionForOptimization(kub);
|
|
|
|
test(1, kub);
|