c7c47c68f2
This is a reland of f05bae1e0d
Previously I presumed that the context read from a frame in the profiler was
a valid context. Turns out that on non-intel we're not guaranteed that the
frame is properly set up. In the case we looked at, the profiler took a
sample right before writing the frame marker indicating a builtin frame,
causing the "context" pointer from that frame to be a bytecode array. Since
we'll read random garbage on the stack as a possible context pointer, I made
the code reading the native context from it a little more defensive.
Bug: v8:9860
Original change's description:
> [runtime] Move Context::native_context to the map
>
> Remove the native context slot from contexts by making context maps
> native-context-specific. Now we require 2 loads to go from a context to the
> native context, but we have 1 field fewer to store when creating contexts.
>
> Change-Id: I3c0d7c50c94060c4129db684f46a567de6f30e8d
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1859629
> Commit-Queue: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Igor Sheludko <ishell@chromium.org>
> Reviewed-by: Peter Marshall <petermarshall@chromium.org>
> Reviewed-by: Maya Lekova <mslekova@chromium.org>
> Reviewed-by: Georg Neis <neis@chromium.org>
> Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#64296}
Change-Id: If9461e9b21d35a260d71c79d7f95e518cc429e09
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864930
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Reviewed-by: Georg Neis <neis@chromium.org>
Commit-Queue: Toon Verwaest <verwaest@chromium.org>
Auto-Submit: Toon Verwaest <verwaest@chromium.org>
Cr-Commit-Position: refs/heads/master@{#64314}
111 lines
2.6 KiB
Plaintext
111 lines
2.6 KiB
Plaintext
#
|
|
# Autogenerated by generate-bytecode-expectations.
|
|
#
|
|
|
|
---
|
|
wrap: yes
|
|
|
|
---
|
|
snippet: "
|
|
const x = 10; function f1() {return x;}
|
|
"
|
|
frame size: 1
|
|
parameter count: 1
|
|
bytecode array length: 15
|
|
bytecodes: [
|
|
B(CreateFunctionContext), U8(0), U8(1),
|
|
B(PushContext), R(0),
|
|
B(LdaTheHole),
|
|
B(StaCurrentContextSlot), U8(3),
|
|
/* 30 E> */ B(StackCheck),
|
|
/* 44 S> */ B(LdaSmi), I8(10),
|
|
/* 44 E> */ B(StaCurrentContextSlot), U8(3),
|
|
B(LdaUndefined),
|
|
/* 74 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
SCOPE_INFO_TYPE,
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
const x = 10; function f1() {return x;} return x;
|
|
"
|
|
frame size: 1
|
|
parameter count: 1
|
|
bytecode array length: 16
|
|
bytecodes: [
|
|
B(CreateFunctionContext), U8(0), U8(1),
|
|
B(PushContext), R(0),
|
|
B(LdaTheHole),
|
|
B(StaCurrentContextSlot), U8(3),
|
|
/* 30 E> */ B(StackCheck),
|
|
/* 44 S> */ B(LdaSmi), I8(10),
|
|
/* 44 E> */ B(StaCurrentContextSlot), U8(3),
|
|
/* 74 S> */ B(LdaImmutableCurrentContextSlot), U8(3),
|
|
/* 83 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
SCOPE_INFO_TYPE,
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
const x = (x = 20); function f1() {return x;}
|
|
"
|
|
frame size: 2
|
|
parameter count: 1
|
|
bytecode array length: 26
|
|
bytecodes: [
|
|
B(CreateFunctionContext), U8(0), U8(1),
|
|
B(PushContext), R(0),
|
|
B(LdaTheHole),
|
|
B(StaCurrentContextSlot), U8(3),
|
|
/* 30 E> */ B(StackCheck),
|
|
/* 44 S> */ B(LdaSmi), I8(20),
|
|
B(Star), R(1),
|
|
B(LdaCurrentContextSlot), U8(3),
|
|
/* 47 E> */ B(ThrowReferenceErrorIfHole), U8(1),
|
|
B(CallRuntime), U16(Runtime::kThrowConstAssignError), R(0), U8(0),
|
|
/* 44 E> */ B(StaCurrentContextSlot), U8(3),
|
|
B(LdaUndefined),
|
|
/* 80 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
SCOPE_INFO_TYPE,
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["x"],
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
const x = 10; x = 20; function f1() {return x;}
|
|
"
|
|
frame size: 1
|
|
parameter count: 1
|
|
bytecode array length: 22
|
|
bytecodes: [
|
|
B(CreateFunctionContext), U8(0), U8(1),
|
|
B(PushContext), R(0),
|
|
B(LdaTheHole),
|
|
B(StaCurrentContextSlot), U8(3),
|
|
/* 30 E> */ B(StackCheck),
|
|
/* 44 S> */ B(LdaSmi), I8(10),
|
|
/* 44 E> */ B(StaCurrentContextSlot), U8(3),
|
|
/* 48 S> */ B(LdaSmi), I8(20),
|
|
/* 50 E> */ B(CallRuntime), U16(Runtime::kThrowConstAssignError), R(0), U8(0),
|
|
B(LdaUndefined),
|
|
/* 82 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
SCOPE_INFO_TYPE,
|
|
]
|
|
handlers: [
|
|
]
|
|
|