AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity
c92572ba2f
v8/test
History
Santiago Aboy Solanes c92572ba2f Revert "[objects] Remove MakeExternal case for uncached internal strings" 
This reverts commit 3a6f75ac94.

Reason for revert: performance regressions https://bugs.chromium.org/p/chromium/issues/detail?id=1163063

Original change's description:
> [objects] Remove MakeExternal case for uncached internal strings
>
> Concurrently accessing internal external uncached strings is not
> thread-safe. We are removing a case where we can make such a string
> through MakeExternal.
>
> Bug: v8:7790
> Change-Id: I958062c15cf40ccc330600bb572de98620866e54
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2565511
> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
> Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#71573}

TBR=leszeks@chromium.org,solanes@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: v8:7790
Change-Id: I5dcc734869c3c921eacd89426309141127a85f47
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2633547
Reviewed-by: Santiago Aboy Solanes <solanes@chromium.org>
Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#72123}
2021-01-15 20:57:04 +00:00
..
benchmarks [tools] Mark raytrace as slow everywhere 2020-12-03 17:05:14 +00:00
cctest Revert "[objects] Remove MakeExternal case for uncached internal strings" 2021-01-15 20:57:04 +00:00
common [wasm][eh] Remove exnref type 2021-01-15 16:37:26 +00:00
debugger [wasm][eh] Fix delegate opcode 2021-01-15 17:28:53 +00:00
debugging [wasm] [debugging] Fix --wasm-gdb-remote 2020-12-08 19:37:25 +00:00
fuzzer [wasm][eh] Remove exnref type 2021-01-15 16:37:26 +00:00
fuzzilli Fix unhandled promise rejections in REPRL mode 2020-09-30 13:34:23 +00:00
inspector [api] Make ScriptOrigin take isolate as parameter 2021-01-14 23:51:04 +00:00
intl Fix resolvedOption calendar for "iso8601" 2021-01-12 06:22:08 +00:00
js-perf-test [super] Rewrite perf tests 2020-11-16 08:36:24 +00:00
memory Reland^4 "[serializer] Allocate during deserialization" 2020-10-07 08:15:50 +00:00
message [wasm][eh] Revert to catch with tag immediate 2020-12-03 18:55:31 +00:00
mjsunit Revert "[objects] Remove MakeExternal case for uncached internal strings" 2021-01-15 20:57:04 +00:00
mkgrokdump Replace libc functions with base wrappers 2020-11-17 08:50:41 +00:00
mozilla [Respect] Prefer inclusive terms 2020-06-22 18:11:23 +00:00
test262 [test262] Remove myself from OWNERS 2021-01-15 17:13:56 +00:00
torque [torque] introduce const slices 2020-11-30 11:28:15 +00:00
unittests [wasm][eh] Remove exnref type 2021-01-15 16:37:26 +00:00
wasm-api-tests [test][cleanup] Rename WASM_*_GLOBAL to WASM_GLOBAL_* 2020-12-17 21:26:54 +00:00
wasm-js [wasm] Update spec tests 2021-01-15 12:13:40 +00:00
wasm-spec-tests [wasm] Update spec tests 2021-01-15 12:13:40 +00:00
webkit Disallow \8 and \9 in strict mode and template literals 2020-08-03 18:05:14 +00:00
BUILD.gn [turbofan] Make OSR and stack slots compatible 2020-10-05 17:41:02 +00:00
OWNERS Use relative paths to OWNERS files 2019-08-12 13:52:52 +00:00