v8/test
pthier cabbc128e4 [string] Don't overwrite original string in InternalizedStringKey
When internalizing external strings, a new internalized external string object is allocated if the string is not in-place internalizable. This newly allocated strings external resource is set to null (the actual resource will be transferred by MakeThin to ensure unique ownership of the resource).

We need to preserve the original string in the InternalizedStringKey for
the second lookup (inside the critical section), as we need to access
the external resource in case of hash collisions to check for equality.

Bug: chromium:1402187
Change-Id: I62b637859b06f05d1b34cb26495f08ec44d2f2db
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4128089
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Patrick Thier <pthier@chromium.org>
Cr-Commit-Position: refs/heads/main@{#85057}
2023-01-02 14:27:51 +00:00
..
benchmarks Microoptimizations in FastDtoa. 2022-12-16 15:03:39 +00:00
bigint [test] Refactor testrunner (4) 2022-07-18 09:52:24 +00:00
cctest [string] Don't overwrite original string in InternalizedStringKey 2023-01-02 14:27:51 +00:00
common [relaxed-simd] Fix ordering of relaxed FMA/FNMA operands 2022-12-16 19:12:44 +00:00
debugger Reland: "[wasm] Compile debug code lazily" 2022-12-15 14:59:13 +00:00
debugging [test] Refactor testrunner (4) 2022-07-18 09:52:24 +00:00
fuzzer [wasm-gc] Final types 2022-12-20 14:03:30 +00:00
fuzzilli [test] Refactor testrunner (4) 2022-07-18 09:52:24 +00:00
inspector Runtime.callFunctionOn supports uniqueContextId 2022-12-28 10:45:28 +00:00
intl [Intl] Impl LocaleInfo PR 63 2022-12-15 01:21:58 +00:00
js-perf-test [js-perf-test] Reduce input sizes for small BigInts 2022-10-06 14:23:53 +00:00
memory [snapshot] Fix the Memory.json benchmark 2021-04-28 07:54:34 +00:00
message Resolved an issue where an earlier error was not reported first in certain cases 2022-11-11 13:43:32 +00:00
mjsunit [maglev] Fix missing sign-extension in Switch 2023-01-02 11:24:04 +00:00
mkgrokdump [heap] Rename safepoint scopes 2022-10-25 16:32:55 +00:00
mozilla [mips32] Delete mips32 from v8 2022-09-13 07:54:54 +00:00
test262 [string-iswellformed] Implement String#{is,to}WellFormed 2022-12-22 18:04:40 +00:00
torque Reland "Reland "[Torque] Generalize Torque literals to larger size"" 2022-02-04 09:40:24 +00:00
unittests Revert "Reland "[heap] Fix conservative stack scanning for client isolates"" 2022-12-21 11:27:43 +00:00
wasm-api-tests [wasm-gc] Final types 2022-12-20 14:03:30 +00:00
wasm-js [wasm] Update spec tests 2022-12-16 13:05:33 +00:00
wasm-spec-tests [wasm] Update spec tests 2022-12-16 13:05:33 +00:00
webkit [mips32] Delete mips32 from v8 2022-09-13 07:54:54 +00:00
BUILD.gn [test] Move cctest/interpreter to unittests 2022-06-10 08:37:10 +00:00
OWNERS