c360c6a1d0
Introduces ThrowReferenceErrorIfHole / ThrowSuperNotCalledIfHole / ThrowSuperAlreadyCalledIfNotHole bytecodes to handle hole checks. In the bytecode-graph builder they are handled by introducing a deopt point instead of adding explicit control flow. JumpIfNotHole / JumpIfNotHoleConstant bytecodes are removed since they are no longer required. Bug: v8:4280, v8:6383 Change-Id: I58b70c556b0ffa30e41a0cd44016874c3e9c5fe1 Reviewed-on: https://chromium-review.googlesource.com/509613 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#45720}
28 lines
789 B
JavaScript
28 lines
789 B
JavaScript
// Copyright 2016 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --opt --allow-natives-syntax --turbo --no-always-opt
|
|
|
|
function f(b) {
|
|
if (b == 1) {
|
|
let a = a = 20;
|
|
}
|
|
}
|
|
|
|
f(0);
|
|
f(0);
|
|
%OptimizeFunctionOnNextCall(f);
|
|
f(0);
|
|
assertOptimized(f);
|
|
// Check that hole checks are handled correctly in optimized code.
|
|
assertThrowsEquals(() => {f(1)}, ReferenceError());
|
|
// The first time we introduce a deopt point so on hole f should deopt.
|
|
assertUnoptimized(f);
|
|
assertTrue(%GetDeoptCount(f) > 0);
|
|
%OptimizeFunctionOnNextCall(f);
|
|
f(0);
|
|
assertThrowsEquals(() => {f(1)}, ReferenceError());
|
|
// The second time it should generate normal control flow and not deopt.
|
|
assertOptimized(f);
|