07011cc4f0
This replaces Runtime_RunMicrotasks with Runtime_PerformMicrotaskCheckpoint.
RunMicrotasks forcibly runs Microtasks even when the microtasks are suppressed,
and may causes nested Microtasks in a problematic way. E.g. that confuses
v8::MicrotasksScope::IsRunningMicrotasks() and GetEnteredOrMicrotaskContext().
OTOH, PerformMicrotaskCheckpoint() doesn't run cause the failure as it
respects the microtask suppressions.
As all existing tests don't call RunMicrotasks() in the suppressed situation
(like Promise.resolve().then(()=>{%RunMicrotasks();})), this change should
not affect to these tests.
Change-Id: Ib043a0cc8e482e022d375084d65ea98a6f54ef3d
Reviewed-on: https://chromium-review.googlesource.com/c/1360095
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58068}
35 lines
1.3 KiB
JavaScript
35 lines
1.3 KiB
JavaScript
// Copyright 2018 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --allow-natives-syntax --harmony-dynamic-import
|
|
// Resources: test/mjsunit/regress/modules-skip-regress-797581-1.js
|
|
// Resources: test/mjsunit/regress/modules-skip-regress-797581-2.js
|
|
// Resources: test/mjsunit/regress/modules-skip-regress-797581-3.js
|
|
// Resources: test/mjsunit/regress/modules-skip-regress-797581-4.js
|
|
// Resources: test/mjsunit/regress/modules-skip-regress-797581-5.js
|
|
|
|
function TryToLoadModule(filename, expect_error, token) {
|
|
let caught_error;
|
|
|
|
function SetError(e) {
|
|
caught_error = e;
|
|
}
|
|
|
|
import(filename).catch(SetError);
|
|
%PerformMicrotaskCheckpoint();
|
|
|
|
if (expect_error) {
|
|
assertTrue(caught_error instanceof SyntaxError);
|
|
assertEquals("Unexpected token " + token, caught_error.message);
|
|
} else {
|
|
assertEquals(undefined, caught_error);
|
|
}
|
|
}
|
|
|
|
TryToLoadModule("modules-skip-regress-797581-1.js", true, ")");
|
|
TryToLoadModule("modules-skip-regress-797581-2.js", true, ")");
|
|
TryToLoadModule("modules-skip-regress-797581-3.js", true, "...");
|
|
TryToLoadModule("modules-skip-regress-797581-4.js", true, ",");
|
|
TryToLoadModule("modules-skip-regress-797581-5.js", false);
|