8fdb23873b
This reverts commit5611f70b3d. Reason for revert: flaky tests: v8:9588, v8:9587 Original change's description: > "Reland x4 [arraybuffer] Rearchitect backing store ownership" > > This is a reland ofbc33f5aeba> > Contributed by titzer@chromium.org > > Original change's description: > > [arraybuffer] Rearchitect backing store ownership > > > > This CL completely rearchitects the ownership of array buffer backing stores, > > consolidating ownership into a {BackingStore} C++ object that is tracked > > throughout V8 using unique_ptr and shared_ptr where appropriate. > > > > Overall, lifetime management is simpler and more explicit. The numerous > > ways that array buffers were initialized have been streamlined to one > > Attach() method on JSArrayBuffer. The array buffer tracker in the > > GC implementation now manages std::shared_ptr<BackingStore> pointers, > > and the construction and destruction of the BackingStore object itself > > handles the underlying page or embedder-allocated memory. > > > > The embedder API remains unchanged for now. We use the > > v8::ArrayBuffer::Contents struct to hide an additional shared_ptr to > > keep the backing store alive properly, even in the case of aliases > > from live heap objects. Thus the embedder has a lower chance of making > > a mistake. Long-term, we should move the embedder to a model where they > > manage backing stores using shared_ptr to an opaque backing store object. > > TBR=yangguo@chromium.org > > BUG=v8:9380,v8:9221,chromium:986318 > > Change-Id: If671a4a9ca0476e8f084efae46e0d2bf99ed99ef > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1731005 > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63041} TBR=ulan@chromium.org,yangguo@chromium.org,mstarzinger@chromium.org,clemensh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:9380, v8:9221, chromium:986318 Change-Id: Ic7381239f4e90d0c437b7e47a5ac6e8bce60f882 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1736747 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#63081}
50 lines
1.8 KiB
Plaintext
50 lines
1.8 KiB
Plaintext
# Copyright 2014 the V8 project authors. All rights reserved.
|
|
# Use of this source code is governed by a BSD-style license that can be
|
|
# found in the LICENSE file.
|
|
|
|
[
|
|
['system == macos and asan', {
|
|
# BUG(820416).
|
|
'BitsDeathTest*': [SKIP],
|
|
'LiveRangeUnitTest*': [SKIP],
|
|
'LoggingDeathTest*': [SKIP],
|
|
'LoggingTest.CompareClassTypes': [SKIP],
|
|
'LoggingTest.CompareWithDifferentSignedness': [SKIP],
|
|
'LoggingTest.CompareWithReferenceType': [SKIP],
|
|
'RandomNumberGenerator.NextSampleInvalidParam': [SKIP],
|
|
'RandomNumberGenerator.NextSampleSlowInvalidParam1': [SKIP],
|
|
'RandomNumberGenerator.NextSampleSlowInvalidParam2': [SKIP],
|
|
}], # 'system == macos and asan'
|
|
|
|
['(arch == arm or arch == mips) and not simulator_run', {
|
|
# Uses too much memory.
|
|
'Parameterized/WasmCodeManagerTest.GrowingVsFixedModule/Fixed': [SKIP]
|
|
}], # '(arch == arm or arch == mips) and not simulator_run'
|
|
|
|
##############################################################################
|
|
['lite_mode or variant == jitless', {
|
|
# TODO(v8:7777): Re-enable once wasm is supported in jitless mode.
|
|
'ValueSerializerTestWithSharedArrayBufferClone.RoundTripWebAssemblyMemory': [SKIP],
|
|
'ValueSerializerTestWithWasm.*': [SKIP],
|
|
'Parameterized/WasmCodeManagerTest.*': [SKIP],
|
|
}], # lite_mode or variant == jitless
|
|
|
|
##############################################################################
|
|
['variant == jitless and not embedded_builtins', {
|
|
'*': [SKIP],
|
|
}], # variant == jitless and not embedded_builtins
|
|
|
|
['system == windows and asan', {
|
|
# BUG(893437).
|
|
'Torque*': [SKIP],
|
|
}], # 'system == windows and asan'
|
|
|
|
##############################################################################
|
|
['tsan == True', {
|
|
# https://crbug.com/v8/9380
|
|
# The test is broken and needs to be fixed to use separate isolates.
|
|
'BackingStoreTest.RacyGrowWasmMemoryInPlace': [SKIP],
|
|
}], # 'tsan == True'
|
|
|
|
]
|