e24c612a5e
This also refactors the way we set the length of an arrays' backing store to use the new elements accessor interface. The actual fix is in DictionaryElementsAccessor::SetLengthWithoutNormalize() where we first search for non-deletable elements according to ES5 section 15.4.5.2 specifications. Snippet from the specification: Attempting to set the length property of an Array object to a value that is numerically less than or equal to the largest numeric property name of an existing array indexed non-deletable property of the array will result in the length being set to a numeric value that is one greater than that largest numeric property name. R=danno@chromium.org TEST=test262/15.4.4.??-7-b-16 Review URL: http://codereview.chromium.org/8372064 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9911 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
101 lines
4.2 KiB
C++
101 lines
4.2 KiB
C++
// Copyright 2011 the V8 project authors. All rights reserved.
|
|
// Redistribution and use in source and binary forms, with or without
|
|
// modification, are permitted provided that the following conditions are
|
|
// met:
|
|
//
|
|
// * Redistributions of source code must retain the above copyright
|
|
// notice, this list of conditions and the following disclaimer.
|
|
// * Redistributions in binary form must reproduce the above
|
|
// copyright notice, this list of conditions and the following
|
|
// disclaimer in the documentation and/or other materials provided
|
|
// with the distribution.
|
|
// * Neither the name of Google Inc. nor the names of its
|
|
// contributors may be used to endorse or promote products derived
|
|
// from this software without specific prior written permission.
|
|
//
|
|
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
#ifndef V8_ELEMENTS_H_
|
|
#define V8_ELEMENTS_H_
|
|
|
|
#include "objects.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
|
|
// Abstract base class for handles that can operate on objects with differing
|
|
// ElementsKinds.
|
|
class ElementsAccessor {
|
|
public:
|
|
ElementsAccessor() { }
|
|
virtual ~ElementsAccessor() { }
|
|
virtual MaybeObject* Get(FixedArrayBase* backing_store,
|
|
uint32_t key,
|
|
JSObject* holder,
|
|
Object* receiver) = 0;
|
|
|
|
// Modifies the length data property as specified for JSArrays and resizes
|
|
// the underlying backing store accordingly.
|
|
virtual MaybeObject* SetLength(JSObject* holder,
|
|
Object* new_length) = 0;
|
|
|
|
virtual MaybeObject* Delete(JSObject* holder,
|
|
uint32_t key,
|
|
JSReceiver::DeleteMode mode) = 0;
|
|
|
|
virtual MaybeObject* AddElementsToFixedArray(FixedArrayBase* from,
|
|
FixedArray* to,
|
|
JSObject* holder,
|
|
Object* receiver) = 0;
|
|
|
|
// Returns a shared ElementsAccessor for the specified ElementsKind.
|
|
static ElementsAccessor* ForKind(ElementsKind elements_kind) {
|
|
ASSERT(elements_kind < kElementsKindCount);
|
|
return elements_accessors_[elements_kind];
|
|
}
|
|
|
|
static ElementsAccessor* ForArray(FixedArrayBase* array);
|
|
|
|
static void InitializeOncePerProcess();
|
|
|
|
protected:
|
|
friend class NonStrictArgumentsElementsAccessor;
|
|
|
|
virtual uint32_t GetCapacity(FixedArrayBase* backing_store) = 0;
|
|
|
|
virtual bool HasElementAtIndex(FixedArrayBase* backing_store,
|
|
uint32_t index,
|
|
JSObject* holder,
|
|
Object* receiver) = 0;
|
|
|
|
// Element handlers distinguish between indexes and keys when the manipulate
|
|
// elements. Indexes refer to elements in terms of their location in the
|
|
// underlying storage's backing store representation, and are between 0
|
|
// GetCapacity. Keys refer to elements in terms of the value that would be
|
|
// specific in JavaScript to access the element. In most implementations, keys
|
|
// are equivalent to indexes, and GetKeyForIndex returns the same value it is
|
|
// passed. In the NumberDictionary ElementsAccessor, GetKeyForIndex maps the
|
|
// index to a key using the KeyAt method on the NumberDictionary.
|
|
virtual uint32_t GetKeyForIndex(FixedArrayBase* backing_store,
|
|
uint32_t index) = 0;
|
|
|
|
private:
|
|
static ElementsAccessor** elements_accessors_;
|
|
|
|
DISALLOW_COPY_AND_ASSIGN(ElementsAccessor);
|
|
};
|
|
|
|
} } // namespace v8::internal
|
|
|
|
#endif // V8_ELEMENTS_H_
|