ffee558e14
With this CL, {CreateDefaultPlatform} returns a unique_ptr to indicate
that the caller owns the returned memory. We had several memory leaks
where the memory of the DefaultPlatform did not get deallocated.
In addition, the {TracingController} of the {DefaultPlatform} also gets
received as a unique_ptr. Thereby we document that the {DefaultPlatform}
takes ownership of the {TracingController}. Note that the memory of the
{TracingController} was already owned by the {DefaultPlatform}, but it
was not documented in the interface, and it was used incorrectly in
tests.
This CL fixes the asan issues in
https://chromium-review.googlesource.com/c/v8/v8/+/753583
([platform] Implement TaskRunners in the DefaultPlatform)
R=rmcilroy@chromium.org
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
Change-Id: I0d1a6d3b22bb8289dc050b1977e4f58381cec675
Reviewed-on: https://chromium-review.googlesource.com/755033
Reviewed-by: Adam Klein <adamk@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49349}
47 lines
1.3 KiB
C++
47 lines
1.3 KiB
C++
// Copyright 2014 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "include/libplatform/libplatform.h"
|
|
#include "include/v8.h"
|
|
#include "src/base/compiler-specific.h"
|
|
#include "testing/gmock/include/gmock/gmock.h"
|
|
|
|
namespace {
|
|
|
|
class DefaultPlatformEnvironment final : public ::testing::Environment {
|
|
public:
|
|
DefaultPlatformEnvironment() {}
|
|
|
|
void SetUp() override {
|
|
platform_ = v8::platform::NewDefaultPlatform(
|
|
0, v8::platform::IdleTaskSupport::kEnabled);
|
|
ASSERT_TRUE(platform_.get() != NULL);
|
|
v8::V8::InitializePlatform(platform_.get());
|
|
ASSERT_TRUE(v8::V8::Initialize());
|
|
}
|
|
|
|
void TearDown() override {
|
|
ASSERT_TRUE(platform_.get() != NULL);
|
|
v8::V8::Dispose();
|
|
v8::V8::ShutdownPlatform();
|
|
}
|
|
|
|
private:
|
|
std::unique_ptr<v8::Platform> platform_;
|
|
};
|
|
|
|
} // namespace
|
|
|
|
|
|
int main(int argc, char** argv) {
|
|
// Don't catch SEH exceptions and continue as the following tests might hang
|
|
// in an broken environment on windows.
|
|
testing::GTEST_FLAG(catch_exceptions) = false;
|
|
testing::InitGoogleMock(&argc, argv);
|
|
testing::AddGlobalTestEnvironment(new DefaultPlatformEnvironment);
|
|
v8::V8::SetFlagsFromCommandLine(&argc, argv, true);
|
|
v8::V8::InitializeExternalStartupData(argv[0]);
|
|
return RUN_ALL_TESTS();
|
|
}
|