503e07c3ef
This reverts commit f9a2e24bbc
.
Reason for revert: gc stress failures not all fixed by follow up.
Original change's description:
> [cleanup] Refactor the Factory
>
> There is no good reason to have the meat of most objects' initialization
> logic in heap.cc, all wrapped by the CALL_HEAP_FUNCTION macro. Instead,
> this CL changes the protocol between Heap and Factory to be AllocateRaw,
> and all object initialization work after (possibly retried) successful
> raw allocation happens in the Factory.
>
> This saves about 20KB of binary size on x64.
>
> Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
> Change-Id: Icbfdc4266d7be8b48d2fe085f03411743dc6a0ca
> Reviewed-on: https://chromium-review.googlesource.com/959533
> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
> Reviewed-by: Hannes Payer <hpayer@chromium.org>
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#52416}
TBR=jkummerow@chromium.org,yangguo@chromium.org,mstarzinger@chromium.org,hpayer@chromium.org
Change-Id: Idbbc53478742f3e9525eee83342afc6aedae122f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/999414
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52420}
393 lines
13 KiB
C++
393 lines
13 KiB
C++
// Copyright 2018 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "src/api.h"
|
|
#include "src/assembler-inl.h"
|
|
#include "src/factory.h"
|
|
#include "src/isolate.h"
|
|
#include "test/cctest/cctest.h"
|
|
#include "test/cctest/heap/heap-utils.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
namespace heap {
|
|
|
|
Handle<FeedbackVector> CreateFeedbackVectorForTest(
|
|
v8::Isolate* isolate, Factory* factory,
|
|
PretenureFlag pretenure_flag = NOT_TENURED) {
|
|
v8::Local<v8::Script> script =
|
|
v8::Script::Compile(isolate->GetCurrentContext(),
|
|
v8::String::NewFromUtf8(isolate, "function foo() {}",
|
|
v8::NewStringType::kNormal)
|
|
.ToLocalChecked())
|
|
.ToLocalChecked();
|
|
Handle<Object> obj = v8::Utils::OpenHandle(*script);
|
|
Handle<SharedFunctionInfo> shared_function =
|
|
Handle<SharedFunctionInfo>(JSFunction::cast(*obj)->shared());
|
|
Handle<FeedbackVector> fv =
|
|
factory->NewFeedbackVector(shared_function, pretenure_flag);
|
|
return fv;
|
|
}
|
|
|
|
TEST(WeakReferencesBasic) {
|
|
CcTest::InitializeVM();
|
|
Isolate* isolate = CcTest::i_isolate();
|
|
Factory* factory = isolate->factory();
|
|
Heap* heap = isolate->heap();
|
|
HandleScope outer_scope(isolate);
|
|
|
|
Handle<FeedbackVector> fv =
|
|
CreateFeedbackVectorForTest(CcTest::isolate(), factory);
|
|
CHECK(heap->InNewSpace(*fv));
|
|
|
|
MaybeObject* code_object = fv->optimized_code_weak_or_smi();
|
|
CHECK(code_object->IsSmi());
|
|
CcTest::CollectAllGarbage();
|
|
CHECK(heap->InNewSpace(*fv));
|
|
CHECK_EQ(code_object, fv->optimized_code_weak_or_smi());
|
|
|
|
{
|
|
HandleScope inner_scope(isolate);
|
|
|
|
// Create a new Code.
|
|
Assembler assm(isolate, nullptr, 0);
|
|
assm.nop(); // supported on all architectures
|
|
CodeDesc desc;
|
|
assm.GetCode(isolate, &desc);
|
|
Handle<Code> code =
|
|
isolate->factory()->NewCode(desc, Code::STUB, Handle<Code>());
|
|
CHECK(code->IsCode());
|
|
|
|
fv->set_optimized_code_weak_or_smi(HeapObjectReference::Weak(*code));
|
|
HeapObject* code_heap_object;
|
|
CHECK(
|
|
fv->optimized_code_weak_or_smi()->ToWeakHeapObject(&code_heap_object));
|
|
CHECK_EQ(*code, code_heap_object);
|
|
|
|
CcTest::CollectAllGarbage();
|
|
|
|
CHECK(
|
|
fv->optimized_code_weak_or_smi()->ToWeakHeapObject(&code_heap_object));
|
|
CHECK_EQ(*code, code_heap_object);
|
|
} // code will go out of scope.
|
|
|
|
CcTest::CollectAllGarbage();
|
|
CHECK(fv->optimized_code_weak_or_smi()->IsClearedWeakHeapObject());
|
|
}
|
|
|
|
TEST(WeakReferencesOldToOld) {
|
|
// Like WeakReferencesBasic, but the updated weak slot is in the old space,
|
|
// and referring to an old space object.
|
|
ManualGCScope manual_gc_scope;
|
|
FLAG_manual_evacuation_candidates_selection = true;
|
|
CcTest::InitializeVM();
|
|
Isolate* isolate = CcTest::i_isolate();
|
|
Factory* factory = isolate->factory();
|
|
Heap* heap = isolate->heap();
|
|
|
|
HandleScope outer_scope(isolate);
|
|
Handle<FeedbackVector> fv =
|
|
CreateFeedbackVectorForTest(CcTest::isolate(), factory, TENURED);
|
|
CHECK(heap->InOldSpace(*fv));
|
|
|
|
// Create a new FixedArray which the FeedbackVector will point to.
|
|
Handle<FixedArray> fixed_array = factory->NewFixedArray(1, TENURED);
|
|
CHECK(heap->InOldSpace(*fixed_array));
|
|
fv->set_optimized_code_weak_or_smi(HeapObjectReference::Weak(*fixed_array));
|
|
|
|
Page* page_before_gc = Page::FromAddress(fixed_array->address());
|
|
heap::ForceEvacuationCandidate(page_before_gc);
|
|
CcTest::CollectAllGarbage();
|
|
CHECK(heap->InOldSpace(*fixed_array));
|
|
|
|
HeapObject* heap_object;
|
|
CHECK(fv->optimized_code_weak_or_smi()->ToWeakHeapObject(&heap_object));
|
|
CHECK_EQ(heap_object, *fixed_array);
|
|
}
|
|
|
|
TEST(WeakReferencesOldToNew) {
|
|
// Like WeakReferencesBasic, but the updated weak slot is in the old space,
|
|
// and referring to an new space object.
|
|
CcTest::InitializeVM();
|
|
Isolate* isolate = CcTest::i_isolate();
|
|
Factory* factory = isolate->factory();
|
|
Heap* heap = isolate->heap();
|
|
|
|
HandleScope outer_scope(isolate);
|
|
Handle<FeedbackVector> fv =
|
|
CreateFeedbackVectorForTest(CcTest::isolate(), factory, TENURED);
|
|
CHECK(heap->InOldSpace(*fv));
|
|
|
|
// Create a new FixedArray which the FeedbackVector will point to.
|
|
Handle<FixedArray> fixed_array = factory->NewFixedArray(1);
|
|
CHECK(heap->InNewSpace(*fixed_array));
|
|
fv->set_optimized_code_weak_or_smi(HeapObjectReference::Weak(*fixed_array));
|
|
|
|
CcTest::CollectAllGarbage();
|
|
|
|
HeapObject* heap_object;
|
|
CHECK(fv->optimized_code_weak_or_smi()->ToWeakHeapObject(&heap_object));
|
|
CHECK_EQ(heap_object, *fixed_array);
|
|
}
|
|
|
|
TEST(WeakReferencesOldToNewScavenged) {
|
|
// Like WeakReferencesBasic, but the updated weak slot is in the old space,
|
|
// and referring to an new space object, which is then scavenged.
|
|
CcTest::InitializeVM();
|
|
Isolate* isolate = CcTest::i_isolate();
|
|
Factory* factory = isolate->factory();
|
|
Heap* heap = isolate->heap();
|
|
|
|
HandleScope outer_scope(isolate);
|
|
Handle<FeedbackVector> fv =
|
|
CreateFeedbackVectorForTest(CcTest::isolate(), factory, TENURED);
|
|
CHECK(heap->InOldSpace(*fv));
|
|
|
|
// Create a new FixedArray which the FeedbackVector will point to.
|
|
Handle<FixedArray> fixed_array = factory->NewFixedArray(1);
|
|
CHECK(heap->InNewSpace(*fixed_array));
|
|
fv->set_optimized_code_weak_or_smi(HeapObjectReference::Weak(*fixed_array));
|
|
|
|
CcTest::CollectGarbage(NEW_SPACE);
|
|
|
|
HeapObject* heap_object;
|
|
CHECK(fv->optimized_code_weak_or_smi()->ToWeakHeapObject(&heap_object));
|
|
CHECK_EQ(heap_object, *fixed_array);
|
|
}
|
|
|
|
TEST(WeakReferencesOldToCleared) {
|
|
// Like WeakReferencesBasic, but the updated weak slot is in the old space,
|
|
// and is cleared.
|
|
ManualGCScope manual_gc_scope;
|
|
FLAG_manual_evacuation_candidates_selection = true;
|
|
CcTest::InitializeVM();
|
|
Isolate* isolate = CcTest::i_isolate();
|
|
Factory* factory = isolate->factory();
|
|
Heap* heap = isolate->heap();
|
|
|
|
HandleScope outer_scope(isolate);
|
|
Handle<FeedbackVector> fv =
|
|
CreateFeedbackVectorForTest(CcTest::isolate(), factory, TENURED);
|
|
CHECK(heap->InOldSpace(*fv));
|
|
fv->set_optimized_code_weak_or_smi(HeapObjectReference::ClearedValue());
|
|
|
|
CcTest::CollectAllGarbage();
|
|
CHECK(fv->optimized_code_weak_or_smi()->IsClearedWeakHeapObject());
|
|
}
|
|
|
|
TEST(ObjectMovesBeforeClearingWeakField) {
|
|
if (!FLAG_incremental_marking) {
|
|
return;
|
|
}
|
|
ManualGCScope manual_gc_scope;
|
|
CcTest::InitializeVM();
|
|
Isolate* isolate = CcTest::i_isolate();
|
|
Factory* factory = isolate->factory();
|
|
Heap* heap = isolate->heap();
|
|
|
|
HandleScope outer_scope(isolate);
|
|
Handle<FeedbackVector> fv =
|
|
CreateFeedbackVectorForTest(CcTest::isolate(), factory);
|
|
CHECK(heap->InNewSpace(*fv));
|
|
FeedbackVector* fv_location = *fv;
|
|
{
|
|
HandleScope inner_scope(isolate);
|
|
// Create a new FixedArray which the FeedbackVector will point to.
|
|
Handle<FixedArray> fixed_array = factory->NewFixedArray(1);
|
|
CHECK(heap->InNewSpace(*fixed_array));
|
|
fv->set_optimized_code_weak_or_smi(HeapObjectReference::Weak(*fixed_array));
|
|
// inner_scope will go out of scope, so when marking the next time,
|
|
// *fixed_array will stay white.
|
|
}
|
|
|
|
// Do marking steps; this will store *fv into the list for later processing
|
|
// (since it points to a white object).
|
|
SimulateIncrementalMarking(heap, true);
|
|
|
|
// Scavenger will move *fv.
|
|
CcTest::CollectGarbage(NEW_SPACE);
|
|
FeedbackVector* new_fv_location = *fv;
|
|
CHECK_NE(fv_location, new_fv_location);
|
|
CHECK(fv->optimized_code_weak_or_smi()->IsWeakHeapObject());
|
|
|
|
// Now we try to clear *fv.
|
|
CcTest::CollectAllGarbage();
|
|
CHECK(fv->optimized_code_weak_or_smi()->IsClearedWeakHeapObject());
|
|
}
|
|
|
|
TEST(ObjectWithWeakReferencePromoted) {
|
|
CcTest::InitializeVM();
|
|
Isolate* isolate = CcTest::i_isolate();
|
|
Factory* factory = isolate->factory();
|
|
Heap* heap = isolate->heap();
|
|
|
|
HandleScope outer_scope(isolate);
|
|
Handle<FeedbackVector> fv =
|
|
CreateFeedbackVectorForTest(CcTest::isolate(), factory);
|
|
CHECK(heap->InNewSpace(*fv));
|
|
|
|
// Create a new FixedArray which the FeedbackVector will point to.
|
|
Handle<FixedArray> fixed_array = factory->NewFixedArray(1);
|
|
CHECK(heap->InNewSpace(*fixed_array));
|
|
fv->set_optimized_code_weak_or_smi(HeapObjectReference::Weak(*fixed_array));
|
|
|
|
CcTest::CollectGarbage(NEW_SPACE);
|
|
CcTest::CollectGarbage(NEW_SPACE);
|
|
CHECK(heap->InOldSpace(*fv));
|
|
CHECK(heap->InOldSpace(*fixed_array));
|
|
|
|
HeapObject* heap_object;
|
|
CHECK(fv->optimized_code_weak_or_smi()->ToWeakHeapObject(&heap_object));
|
|
CHECK_EQ(heap_object, *fixed_array);
|
|
}
|
|
|
|
TEST(ObjectWithClearedWeakReferencePromoted) {
|
|
CcTest::InitializeVM();
|
|
Isolate* isolate = CcTest::i_isolate();
|
|
Factory* factory = isolate->factory();
|
|
Heap* heap = isolate->heap();
|
|
|
|
HandleScope outer_scope(isolate);
|
|
Handle<FeedbackVector> fv =
|
|
CreateFeedbackVectorForTest(CcTest::isolate(), factory);
|
|
CHECK(heap->InNewSpace(*fv));
|
|
|
|
fv->set_optimized_code_weak_or_smi(HeapObjectReference::ClearedValue());
|
|
|
|
CcTest::CollectGarbage(NEW_SPACE);
|
|
CHECK(heap->InNewSpace(*fv));
|
|
CHECK(fv->optimized_code_weak_or_smi()->IsClearedWeakHeapObject());
|
|
|
|
CcTest::CollectGarbage(NEW_SPACE);
|
|
CHECK(heap->InOldSpace(*fv));
|
|
CHECK(fv->optimized_code_weak_or_smi()->IsClearedWeakHeapObject());
|
|
|
|
CcTest::CollectAllGarbage();
|
|
CHECK(fv->optimized_code_weak_or_smi()->IsClearedWeakHeapObject());
|
|
}
|
|
|
|
TEST(WeakReferenceWriteBarrier) {
|
|
if (!FLAG_incremental_marking) {
|
|
return;
|
|
}
|
|
|
|
ManualGCScope manual_gc_scope;
|
|
CcTest::InitializeVM();
|
|
Isolate* isolate = CcTest::i_isolate();
|
|
Factory* factory = isolate->factory();
|
|
Heap* heap = isolate->heap();
|
|
|
|
HandleScope outer_scope(isolate);
|
|
Handle<FeedbackVector> fv =
|
|
CreateFeedbackVectorForTest(CcTest::isolate(), factory);
|
|
CHECK(heap->InNewSpace(*fv));
|
|
|
|
{
|
|
HandleScope inner_scope(isolate);
|
|
|
|
// Create a new FixedArray which the FeedbackVector will point to.
|
|
Handle<FixedArray> fixed_array1 = factory->NewFixedArray(1);
|
|
CHECK(heap->InNewSpace(*fixed_array1));
|
|
fv->set_optimized_code_weak_or_smi(
|
|
HeapObjectReference::Weak(*fixed_array1));
|
|
|
|
SimulateIncrementalMarking(heap, true);
|
|
|
|
Handle<FixedArray> fixed_array2 = factory->NewFixedArray(1);
|
|
CHECK(heap->InNewSpace(*fixed_array2));
|
|
// This write will trigger the write barrier.
|
|
fv->set_optimized_code_weak_or_smi(
|
|
HeapObjectReference::Weak(*fixed_array2));
|
|
}
|
|
|
|
CcTest::CollectAllGarbage();
|
|
|
|
// Check that the write barrier treated the weak reference as strong.
|
|
CHECK(fv->optimized_code_weak_or_smi()->IsWeakHeapObject());
|
|
}
|
|
|
|
TEST(EmptyWeakArray) {
|
|
CcTest::InitializeVM();
|
|
Isolate* isolate = CcTest::i_isolate();
|
|
Factory* factory = isolate->factory();
|
|
HandleScope outer_scope(isolate);
|
|
|
|
Handle<WeakFixedArray> array = factory->empty_weak_fixed_array();
|
|
CHECK(array->IsWeakFixedArray());
|
|
CHECK(!array->IsFixedArray());
|
|
CHECK_EQ(array->length(), 0);
|
|
}
|
|
|
|
TEST(WeakArraysBasic) {
|
|
ManualGCScope manual_gc_scope;
|
|
CcTest::InitializeVM();
|
|
Isolate* isolate = CcTest::i_isolate();
|
|
Factory* factory = isolate->factory();
|
|
Heap* heap = isolate->heap();
|
|
HandleScope outer_scope(isolate);
|
|
|
|
const int length = 4;
|
|
Handle<WeakFixedArray> array = factory->NewWeakFixedArray(length);
|
|
CHECK(array->IsWeakFixedArray());
|
|
CHECK(!array->IsFixedArray());
|
|
CHECK_EQ(array->length(), length);
|
|
CHECK(heap->InNewSpace(*array));
|
|
|
|
for (int i = 0; i < length; ++i) {
|
|
HeapObject* heap_object;
|
|
CHECK(array->Get(i)->ToStrongHeapObject(&heap_object));
|
|
CHECK_EQ(heap_object, heap->undefined_value());
|
|
}
|
|
|
|
Handle<HeapObject> saved;
|
|
{
|
|
HandleScope inner_scope(isolate);
|
|
Handle<FixedArray> index0 = factory->NewFixedArray(1);
|
|
index0->set(0, Smi::FromInt(2016));
|
|
Handle<FixedArray> index1 = factory->NewFixedArray(1);
|
|
index1->set(0, Smi::FromInt(2017));
|
|
|
|
Handle<FixedArray> index2 = factory->NewFixedArray(1);
|
|
index2->set(0, Smi::FromInt(2018));
|
|
Handle<FixedArray> index3 = factory->NewFixedArray(1);
|
|
index3->set(0, Smi::FromInt(2019));
|
|
|
|
array->Set(0, HeapObjectReference::Weak(*index0));
|
|
array->Set(1, HeapObjectReference::Weak(*index1));
|
|
array->Set(2, HeapObjectReference::Strong(*index2));
|
|
array->Set(3, HeapObjectReference::Weak(*index3));
|
|
saved = inner_scope.CloseAndEscape(index1);
|
|
} // inner_scope goes out of scope.
|
|
|
|
// The references are only cleared by the mark-compact (scavenger treats weak
|
|
// references as strong). Thus we need to GC until the array reaches old
|
|
// space.
|
|
|
|
// TODO(marja): update this when/if we do handle weak references in the new
|
|
// space.
|
|
CcTest::CollectGarbage(NEW_SPACE);
|
|
HeapObject* heap_object;
|
|
CHECK(array->Get(0)->ToWeakHeapObject(&heap_object));
|
|
CHECK_EQ(Smi::cast(FixedArray::cast(heap_object)->get(0))->value(), 2016);
|
|
CHECK(array->Get(1)->ToWeakHeapObject(&heap_object));
|
|
CHECK_EQ(Smi::cast(FixedArray::cast(heap_object)->get(0))->value(), 2017);
|
|
CHECK(array->Get(2)->ToStrongHeapObject(&heap_object));
|
|
CHECK_EQ(Smi::cast(FixedArray::cast(heap_object)->get(0))->value(), 2018);
|
|
CHECK(array->Get(3)->ToWeakHeapObject(&heap_object));
|
|
CHECK_EQ(Smi::cast(FixedArray::cast(heap_object)->get(0))->value(), 2019);
|
|
|
|
CcTest::CollectAllGarbage();
|
|
CHECK(heap->InOldSpace(*array));
|
|
CHECK(array->Get(0)->IsClearedWeakHeapObject());
|
|
CHECK(array->Get(1)->ToWeakHeapObject(&heap_object));
|
|
CHECK_EQ(Smi::cast(FixedArray::cast(heap_object)->get(0))->value(), 2017);
|
|
CHECK(array->Get(2)->ToStrongHeapObject(&heap_object));
|
|
CHECK_EQ(Smi::cast(FixedArray::cast(heap_object)->get(0))->value(), 2018);
|
|
CHECK(array->Get(3)->IsClearedWeakHeapObject());
|
|
}
|
|
|
|
} // namespace heap
|
|
} // namespace internal
|
|
} // namespace v8
|