3c1dc424d3
We may not emit bytecode for the evaluation of the to-be-returned expression. In that case we cannot set two return positions for a return statement (one before and one after the expression evaluation). This sets the interpreter apart from full-codegen. Make sure that we always have the second of the two return positions. Note that we end up with separate test cases for ignition and FCG. R=rmcilroy@chromium.org, vogelheim@chromium.org BUG=v8:4690 LOG=N Review URL: https://codereview.chromium.org/1801473003 Cr-Commit-Position: refs/heads/master@{#34771}
93 lines
3.0 KiB
C++
93 lines
3.0 KiB
C++
// Copyright 2016 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "src/v8.h"
|
|
|
|
#include "src/interpreter/source-position-table.h"
|
|
#include "test/unittests/test-utils.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
namespace interpreter {
|
|
|
|
class SourcePositionTableTest : public TestWithIsolateAndZone {
|
|
public:
|
|
SourcePositionTableTest() {}
|
|
~SourcePositionTableTest() override {}
|
|
};
|
|
|
|
// Some random offsets, mostly at 'suspicious' bit boundaries.
|
|
static int offsets[] = {0, 1, 2, 3, 4, 30, 31, 32,
|
|
33, 62, 63, 64, 65, 126, 127, 128,
|
|
129, 250, 1000, 9999, 12000, 31415926};
|
|
|
|
TEST_F(SourcePositionTableTest, EncodeStatement) {
|
|
SourcePositionTableBuilder builder(isolate(), zone());
|
|
for (int i = 0; i < arraysize(offsets); i++) {
|
|
builder.AddStatementPosition(offsets[i], offsets[i]);
|
|
}
|
|
|
|
// To test correctness, we rely on the assertions in ToSourcePositionTable().
|
|
// (Also below.)
|
|
CHECK(!builder.ToSourcePositionTable().is_null());
|
|
}
|
|
|
|
TEST_F(SourcePositionTableTest, EncodeStatementDuplicates) {
|
|
SourcePositionTableBuilder builder(isolate(), zone());
|
|
for (int i = 0; i < arraysize(offsets); i++) {
|
|
builder.AddStatementPosition(offsets[i], offsets[i]);
|
|
builder.AddStatementPosition(
|
|
offsets[i], offsets[i],
|
|
(i % 2 == 0) ? SourcePositionTableBuilder::OVERWRITE_DUPLICATE
|
|
: SourcePositionTableBuilder::DISCARD_DUPLICATE);
|
|
builder.AddStatementPosition(offsets[i], offsets[i]);
|
|
builder.AddStatementPosition(
|
|
offsets[i], offsets[i],
|
|
(i % 2 == 0) ? SourcePositionTableBuilder::OVERWRITE_DUPLICATE
|
|
: SourcePositionTableBuilder::DISCARD_DUPLICATE);
|
|
}
|
|
|
|
// To test correctness, we rely on the assertions in ToSourcePositionTable().
|
|
// (Also below.)
|
|
CHECK(!builder.ToSourcePositionTable().is_null());
|
|
}
|
|
|
|
TEST_F(SourcePositionTableTest, EncodeExpression) {
|
|
SourcePositionTableBuilder builder(isolate(), zone());
|
|
for (int i = 0; i < arraysize(offsets); i++) {
|
|
builder.AddExpressionPosition(offsets[i], offsets[i]);
|
|
}
|
|
CHECK(!builder.ToSourcePositionTable().is_null());
|
|
}
|
|
|
|
TEST_F(SourcePositionTableTest, EncodeAscending) {
|
|
SourcePositionTableBuilder builder(isolate(), zone());
|
|
|
|
int accumulator = 0;
|
|
for (int i = 0; i < arraysize(offsets); i++) {
|
|
accumulator += offsets[i];
|
|
if (i % 2) {
|
|
builder.AddStatementPosition(accumulator, accumulator);
|
|
} else {
|
|
builder.AddExpressionPosition(accumulator, accumulator);
|
|
}
|
|
}
|
|
|
|
// Also test negative offsets:
|
|
for (int i = 0; i < arraysize(offsets); i++) {
|
|
accumulator -= offsets[i];
|
|
if (i % 2) {
|
|
builder.AddStatementPosition(accumulator, accumulator);
|
|
} else {
|
|
builder.AddExpressionPosition(accumulator, accumulator);
|
|
}
|
|
}
|
|
|
|
CHECK(!builder.ToSourcePositionTable().is_null());
|
|
}
|
|
|
|
} // namespace interpreter
|
|
} // namespace internal
|
|
} // namespace v8
|