d1b27019d3
This moves every single class/function out of include/v8.h into a separate header in include/, which v8.h then includes so that externally nothing appears to have changed. Every include of v8.h from inside v8 has been changed to a more fine-grained include. Previously inline functions defined at the bottom of v8.h would call private non-inline functions in the V8 class. Since that class is now in v8-initialization.h and is rarely included (as that would create dependency cycles), this is not possible and so those methods have been moved out of the V8 class into the namespace v8::api_internal. None of the previous files in include/ now #include v8.h, which means if embedders were relying on this transitive dependency then it will give compile failures. v8-inspector.h does depend on v8-scripts.h for the time being to ensure that Chrome continue to compile but that change will be reverted once those transitive #includes in chrome are changed to include it directly. Full design: https://docs.google.com/document/d/1rTD--I8hCAr-Rho1WTumZzFKaDpEp0IJ8ejZtk4nJdA/edit?usp=sharing Bug: v8:11965 Change-Id: I53b84b29581632710edc80eb11f819c2097a2877 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097448 Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/main@{#76424}
74 lines
2.6 KiB
C++
74 lines
2.6 KiB
C++
// Copyright 2021 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#ifndef INCLUDE_V8_WEAK_CALLBACK_INFO_H_
|
|
#define INCLUDE_V8_WEAK_CALLBACK_INFO_H_
|
|
|
|
#include "v8config.h" // NOLINT(build/include_directory)
|
|
|
|
namespace v8 {
|
|
|
|
class Isolate;
|
|
|
|
namespace api_internal {
|
|
V8_EXPORT void InternalFieldOutOfBounds(int index);
|
|
} // namespace api_internal
|
|
|
|
static const int kInternalFieldsInWeakCallback = 2;
|
|
static const int kEmbedderFieldsInWeakCallback = 2;
|
|
|
|
template <typename T>
|
|
class WeakCallbackInfo {
|
|
public:
|
|
using Callback = void (*)(const WeakCallbackInfo<T>& data);
|
|
|
|
WeakCallbackInfo(Isolate* isolate, T* parameter,
|
|
void* embedder_fields[kEmbedderFieldsInWeakCallback],
|
|
Callback* callback)
|
|
: isolate_(isolate), parameter_(parameter), callback_(callback) {
|
|
for (int i = 0; i < kEmbedderFieldsInWeakCallback; ++i) {
|
|
embedder_fields_[i] = embedder_fields[i];
|
|
}
|
|
}
|
|
|
|
V8_INLINE Isolate* GetIsolate() const { return isolate_; }
|
|
V8_INLINE T* GetParameter() const { return parameter_; }
|
|
V8_INLINE void* GetInternalField(int index) const;
|
|
|
|
// When first called, the embedder MUST Reset() the Global which triggered the
|
|
// callback. The Global itself is unusable for anything else. No v8 other api
|
|
// calls may be called in the first callback. Should additional work be
|
|
// required, the embedder must set a second pass callback, which will be
|
|
// called after all the initial callbacks are processed.
|
|
// Calling SetSecondPassCallback on the second pass will immediately crash.
|
|
void SetSecondPassCallback(Callback callback) const { *callback_ = callback; }
|
|
|
|
private:
|
|
Isolate* isolate_;
|
|
T* parameter_;
|
|
Callback* callback_;
|
|
void* embedder_fields_[kEmbedderFieldsInWeakCallback];
|
|
};
|
|
|
|
// kParameter will pass a void* parameter back to the callback, kInternalFields
|
|
// will pass the first two internal fields back to the callback, kFinalizer
|
|
// will pass a void* parameter back, but is invoked before the object is
|
|
// actually collected, so it can be resurrected. In the last case, it is not
|
|
// possible to request a second pass callback.
|
|
enum class WeakCallbackType { kParameter, kInternalFields, kFinalizer };
|
|
|
|
template <class T>
|
|
void* WeakCallbackInfo<T>::GetInternalField(int index) const {
|
|
#ifdef V8_ENABLE_CHECKS
|
|
if (index < 0 || index >= kEmbedderFieldsInWeakCallback) {
|
|
api_internal::InternalFieldOutOfBounds(index);
|
|
}
|
|
#endif
|
|
return embedder_fields_[index];
|
|
}
|
|
|
|
} // namespace v8
|
|
|
|
#endif // INCLUDE_V8_WEAK_CALLBACK_INFO_H_
|