d1b27019d3
This moves every single class/function out of include/v8.h into a separate header in include/, which v8.h then includes so that externally nothing appears to have changed. Every include of v8.h from inside v8 has been changed to a more fine-grained include. Previously inline functions defined at the bottom of v8.h would call private non-inline functions in the V8 class. Since that class is now in v8-initialization.h and is rarely included (as that would create dependency cycles), this is not possible and so those methods have been moved out of the V8 class into the namespace v8::api_internal. None of the previous files in include/ now #include v8.h, which means if embedders were relying on this transitive dependency then it will give compile failures. v8-inspector.h does depend on v8-scripts.h for the time being to ensure that Chrome continue to compile but that change will be reverted once those transitive #includes in chrome are changed to include it directly. Full design: https://docs.google.com/document/d/1rTD--I8hCAr-Rho1WTumZzFKaDpEp0IJ8ejZtk4nJdA/edit?usp=sharing Bug: v8:11965 Change-Id: I53b84b29581632710edc80eb11f819c2097a2877 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097448 Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/main@{#76424}
86 lines
2.5 KiB
C++
86 lines
2.5 KiB
C++
// Copyright 2016 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#ifndef V8_TEST_INSPECTOR_PROTOCOL_TASK_RUNNER_H_
|
|
#define V8_TEST_INSPECTOR_PROTOCOL_TASK_RUNNER_H_
|
|
|
|
#include <map>
|
|
#include <memory>
|
|
|
|
#include "include/v8-inspector.h"
|
|
#include "include/v8-platform.h"
|
|
#include "src/base/macros.h"
|
|
#include "src/base/platform/platform.h"
|
|
#include "src/base/vector.h"
|
|
#include "src/utils/locked-queue-inl.h"
|
|
#include "test/inspector/isolate-data.h"
|
|
|
|
namespace v8 {
|
|
|
|
class StartupData;
|
|
|
|
namespace internal {
|
|
|
|
enum CatchExceptions {
|
|
kFailOnUncaughtExceptions,
|
|
kStandardPropagateUncaughtExceptions,
|
|
kSuppressUncaughtExceptions
|
|
};
|
|
|
|
class TaskRunner : public v8::base::Thread {
|
|
public:
|
|
class Task {
|
|
public:
|
|
virtual ~Task() = default;
|
|
virtual bool is_priority_task() = 0;
|
|
virtual void Run(IsolateData* data) = 0;
|
|
};
|
|
|
|
TaskRunner(IsolateData::SetupGlobalTasks setup_global_tasks,
|
|
CatchExceptions catch_exceptions,
|
|
v8::base::Semaphore* ready_semaphore,
|
|
v8::StartupData* startup_data, WithInspector with_inspector);
|
|
~TaskRunner() override;
|
|
TaskRunner(const TaskRunner&) = delete;
|
|
TaskRunner& operator=(const TaskRunner&) = delete;
|
|
IsolateData* data() const { return data_.get(); }
|
|
|
|
// Thread implementation.
|
|
void Run() override;
|
|
|
|
// Should be called from the same thread and only from task.
|
|
void RunMessageLoop(bool only_protocol);
|
|
void QuitMessageLoop();
|
|
|
|
void Append(std::unique_ptr<Task>);
|
|
void InterruptForMessages();
|
|
void Terminate();
|
|
|
|
private:
|
|
std::unique_ptr<Task> GetNext(bool only_protocol);
|
|
v8::Isolate* isolate() const { return data_->isolate(); }
|
|
|
|
IsolateData::SetupGlobalTasks setup_global_tasks_;
|
|
v8::StartupData* startup_data_;
|
|
WithInspector with_inspector_;
|
|
CatchExceptions catch_exceptions_;
|
|
v8::base::Semaphore* ready_semaphore_;
|
|
std::unique_ptr<IsolateData> data_;
|
|
|
|
// deferred_queue_ combined with queue_ (in this order) have all tasks in the
|
|
// correct order. Sometimes we skip non-protocol tasks by moving them from
|
|
// queue_ to deferred_queue_.
|
|
v8::internal::LockedQueue<std::unique_ptr<Task>> queue_;
|
|
v8::internal::LockedQueue<std::unique_ptr<Task>> deferred_queue_;
|
|
v8::base::Semaphore process_queue_semaphore_;
|
|
|
|
int nested_loop_count_;
|
|
std::atomic<int> is_terminated_;
|
|
};
|
|
|
|
} // namespace internal
|
|
} // namespace v8
|
|
|
|
#endif // V8_TEST_INSPECTOR_PROTOCOL_TASK_RUNNER_H_
|