d2d99e084a
Reason for revert:
Mac gc stress failures:
https://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/11195
There's also this flake, but maybe unrelated:
https://build.chromium.org/p/client.v8/builders/V8%20Win64/builds/15422
Original issue's description:
> [tests] Make assertOptimized()/assertUnoptimized() great again.
>
> The mentioned asserts did not work properly with interpreted and turbofanned functions.
>
> To fix this issue %GetOptimizationStatus() now returns a set of flags instead of a single value.
>
> This CL also adds more helper functions to mjsunit, like isNeverOptimize(), isAlwaysOptimize(),
> isOptimized(fun), etc.
>
> BUG=v8:5890
>
> Review-Url: https://codereview.chromium.org/2654733004
> Cr-Commit-Position: refs/heads/master@{#42703}
> Committed: d1ddec7857
TBR=mstarzinger@chromium.org,ishell@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:5890
Review-Url: https://codereview.chromium.org/2655223003
Cr-Commit-Position: refs/heads/master@{#42704}
72 lines
2.7 KiB
JavaScript
72 lines
2.7 KiB
JavaScript
// Copyright 2013 the V8 project authors. All rights reserved.
|
|
// Redistribution and use in source and binary forms, with or without
|
|
// modification, are permitted provided that the following conditions are
|
|
// met:
|
|
//
|
|
// * Redistributions of source code must retain the above copyright
|
|
// notice, this list of conditions and the following disclaimer.
|
|
// * Redistributions in binary form must reproduce the above
|
|
// copyright notice, this list of conditions and the following
|
|
// disclaimer in the documentation and/or other materials provided
|
|
// with the distribution.
|
|
// * Neither the name of Google Inc. nor the names of its
|
|
// contributors may be used to endorse or promote products derived
|
|
// from this software without specific prior written permission.
|
|
//
|
|
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
// Flags: --fold-constants --nodead-code-elimination
|
|
// Flags: --expose-gc --allow-natives-syntax
|
|
// Flags: --concurrent-recompilation --block-concurrent-recompilation
|
|
|
|
if (!%IsConcurrentRecompilationSupported()) {
|
|
print("Concurrent recompilation is disabled. Skipping this test.");
|
|
quit();
|
|
}
|
|
|
|
function test(fun) {
|
|
fun();
|
|
%BaselineFunctionOnNextCall(fun);
|
|
fun();
|
|
// Mark for concurrent optimization.
|
|
%OptimizeFunctionOnNextCall(fun, "concurrent");
|
|
// Kick off recompilation.
|
|
fun();
|
|
// Tenure cons string after compile graph has been created.
|
|
gc();
|
|
// In the mean time, concurrent recompiling is still blocked.
|
|
assertUnoptimized(fun, "no sync");
|
|
// Let concurrent recompilation proceed.
|
|
%UnblockConcurrentRecompilation();
|
|
// Concurrent recompilation eventually finishes, embeds tenured cons string.
|
|
assertOptimized(fun, "sync");
|
|
// Visit embedded cons string during mark compact.
|
|
gc();
|
|
}
|
|
|
|
function f() {
|
|
return "abcdefghijklmn" + "123456789";
|
|
}
|
|
|
|
function g() {
|
|
return "abcdefghijklmn\u2603" + "123456789";
|
|
}
|
|
|
|
function h() {
|
|
return "abcdefghijklmn\u2603" + "123456789\u2604";
|
|
}
|
|
|
|
test(f);
|
|
test(g);
|
|
test(h);
|