cace2f533e
The original CL was flaky because deserialization did not wait correctly for the compilation of missing functions to finish. The baseline-finished event was set even when there were still some functions missing. The combination of deserialization and lazy compilation was also not handled correctly. Original change's description: > [wasm] Support partial serialization of modules > > At the moment a WebAssembly module can be serialized successfully when > all functions were compiled with TurboFan. However, for some functions > it may not be necessary to be compiled with TurboFan, e.g. for functions > where Liftoff code is as good as TurboFan code. > > With this CL we allow WebAssembly modules to get serialized even when > not all functions are compiled with TurboFan. Missing functions are > marked as missing in the serlialization. Upon deserialization, missing > functions either get compiled by Liftoff, or initialized with a > lazy-compilation stub, depending on the V8 configuration. > > Bug: v8:11862 Change-Id: I79a9e8e14199cff87fce6ae41a87087e047bbc65 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3060485 Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#76017}
57 lines
1.6 KiB
JavaScript
57 lines
1.6 KiB
JavaScript
// Copyright 2021 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --allow-natives-syntax --liftoff --no-wasm-tier-up --expose-gc
|
|
// Compile functions 0 and 2 with Turbofan, the rest with Liftoff:
|
|
// Flags: --wasm-tier-mask-for-testing=5
|
|
|
|
d8.file.execute('test/mjsunit/wasm/wasm-module-builder.js');
|
|
|
|
const num_functions = 5;
|
|
|
|
function create_builder() {
|
|
const builder = new WasmModuleBuilder();
|
|
for (let i = 0; i < num_functions; ++i) {
|
|
builder.addFunction('f' + i, kSig_i_v)
|
|
.addBody(wasmI32Const(i))
|
|
.exportFunc();
|
|
}
|
|
return builder;
|
|
}
|
|
|
|
function check(instance) {
|
|
for (let i = 0; i < num_functions; ++i) {
|
|
const expect_liftoff = i != 0 && i != 2;
|
|
assertEquals(
|
|
expect_liftoff, %IsLiftoffFunction(instance.exports['f' + i]),
|
|
'function ' + i);
|
|
}
|
|
}
|
|
|
|
const wire_bytes = create_builder().toBuffer();
|
|
|
|
function testTierTestingFlag() {
|
|
print(arguments.callee.name);
|
|
const module = new WebAssembly.Module(wire_bytes);
|
|
const buff = %SerializeWasmModule(module);
|
|
const instance = new WebAssembly.Instance(module);
|
|
check(instance);
|
|
return buff;
|
|
};
|
|
|
|
const serialized_module = testTierTestingFlag();
|
|
// Do some GCs to make sure the first module got collected and removed from the
|
|
// module cache.
|
|
gc();
|
|
gc();
|
|
gc();
|
|
|
|
(function testSerializedModule() {
|
|
print(arguments.callee.name);
|
|
const module = %DeserializeWasmModule(serialized_module, wire_bytes);
|
|
|
|
const instance = new WebAssembly.Instance(module);
|
|
check(instance);
|
|
})();
|