b8ae2249a4
Some debugging tests relied on the following anti-pattern:
let exception = false;
try {
/* ... some code that may throw on test failure ... */
} catch (e) {
exception = e;
}
assertFalse(exception);
This may be problematic if a falseish value is thrown.
Change-Id: I02eace4cc656fc9581928a90ac53cda4dc72b30c
Reviewed-on: https://chromium-review.googlesource.com/972822
Reviewed-by: Georg Neis <neis@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52105}
25 lines
714 B
JavaScript
25 lines
714 B
JavaScript
// Copyright 2018 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --harmony-bigint
|
|
|
|
Debug = debug.Debug
|
|
let exceptionThrown = false;
|
|
|
|
Debug.setListener(function(event, exec_state, event_data, data) {
|
|
if (event != Debug.DebugEvent.Break) return;
|
|
try {
|
|
const o = exec_state.frame(0).evaluate("42n", true);
|
|
assertEquals("bigint", o.type());
|
|
assertFalse(o.isUndefined());
|
|
assertEquals("bigint", typeof(o.value()));
|
|
assertEquals(42n, o.value());
|
|
} catch (e) {
|
|
exceptionThrown = true;
|
|
};
|
|
});
|
|
|
|
!function() { debugger; }();
|
|
assertFalse(exceptionThrown, "exception in listener")
|