d3f074b231
We'll be able to optimize rest parameters in TurboFan similarly to the arguments array. This CL restores the previous behavior, and a follow-on will enable TurboFan optimization. (TBR for rossberg since we discussed the revert beforehand. The only changes are a few lines related to tests and rebasing.) TBR=rossberg@chromium.org BUG= Review URL: https://codereview.chromium.org/1537683002 Cr-Commit-Position: refs/heads/master@{#33024}
55 lines
1.9 KiB
C++
55 lines
1.9 KiB
C++
// Copyright 2015 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "test/cctest/compiler/function-tester.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
namespace compiler {
|
|
|
|
TEST(ArgumentsMapped) {
|
|
FunctionTester T("(function(a) { return arguments; })");
|
|
|
|
Handle<Object> arguments;
|
|
T.Call(T.Val(19), T.Val(23), T.Val(42), T.Val(65)).ToHandle(&arguments);
|
|
CHECK(arguments->IsJSObject() && !arguments->IsJSArray());
|
|
CHECK(JSObject::cast(*arguments)->HasSloppyArgumentsElements());
|
|
Handle<String> l = T.isolate->factory()->length_string();
|
|
Handle<Object> length = JSObject::GetProperty(arguments, l).ToHandleChecked();
|
|
CHECK_EQ(4, length->Number());
|
|
}
|
|
|
|
|
|
TEST(ArgumentsUnmapped) {
|
|
FunctionTester T("(function(a) { 'use strict'; return arguments; })");
|
|
|
|
Handle<Object> arguments;
|
|
T.Call(T.Val(19), T.Val(23), T.Val(42), T.Val(65)).ToHandle(&arguments);
|
|
CHECK(arguments->IsJSObject() && !arguments->IsJSArray());
|
|
CHECK(!JSObject::cast(*arguments)->HasSloppyArgumentsElements());
|
|
Handle<String> l = T.isolate->factory()->length_string();
|
|
Handle<Object> length = JSObject::GetProperty(arguments, l).ToHandleChecked();
|
|
CHECK_EQ(4, length->Number());
|
|
}
|
|
|
|
|
|
TEST(ArgumentsRest) {
|
|
// TODO(mvstanton): restore this test when Turbofan again supports rest args.
|
|
// (soon).
|
|
return;
|
|
FunctionTester T("(function(a, ...args) { return args; })");
|
|
|
|
Handle<Object> arguments;
|
|
T.Call(T.Val(19), T.Val(23), T.Val(42), T.Val(65)).ToHandle(&arguments);
|
|
CHECK(arguments->IsJSObject() && arguments->IsJSArray());
|
|
CHECK(!JSObject::cast(*arguments)->HasSloppyArgumentsElements());
|
|
Handle<String> l = T.isolate->factory()->length_string();
|
|
Handle<Object> length = JSObject::GetProperty(arguments, l).ToHandleChecked();
|
|
CHECK_EQ(3, length->Number());
|
|
}
|
|
|
|
} // namespace compiler
|
|
} // namespace internal
|
|
} // namespace v8
|