AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity
d5565c1f68
v8/test
History
arv d5565c1f68 Revert of [es6] Map/Set size getter should have "get size" name (patchset #4 id:80001 of https://codereview.chromium.org/1094323005/) 
Reason for revert:
Breaks GCMole ia32

http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gcmole/builds/1685/steps/GCMole%20ia32/logs/stdio

src/runtime/runtime-function.cc:96:3: warning: Possible problem with evaluation order.
  f->shared()->set_name(*NameToFunctionName(name));
  ^
src/runtime/runtime-function.cc:96:3: warning: Possible problem with evaluation order.
2 warnings generated.

Original issue's description:
> [es6] Map/Set size getter should have "get size" name
>
> Getter and setter function names in ES6 are defined as "get foo" and
> "set foo".
>
> BUG=None
> LOG=N
> R=adamk@chromium.org
>
> Committed: https://crrev.com/83c89a2e71a363afb35595f903423e650d788e42
> Cr-Commit-Position: refs/heads/master@{#28034}

TBR=adamk@chromium.org,caitpotter88@gmail.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/1106713002

Cr-Commit-Position: refs/heads/master@{#28035}
2015-04-23 22:06:27 +00:00
..
benchmarks [turbofan] Add single --turbo flag. 2015-04-16 16:28:39 +00:00
cctest Empty Array prototype elements protection needs to alert on length change. 2015-04-23 16:08:51 +00:00
intl Allow identifier code points from supplementary multilingual planes. 2014-10-10 07:13:46 +00:00
js-perf-test [cleanup] fix SpreadCalls perf-test names in JSTests.json 2015-04-10 18:29:25 +00:00
memory Correctly name memory stat for context snapshot size. 2015-04-10 22:36:02 +00:00
message Factor formal argument parsing into ParserBase 2015-04-21 11:09:34 +00:00
mjsunit Revert of [es6] Map/Set size getter should have "get size" name (patchset #4 id:80001 of https://codereview.chromium.org/1094323005/) 2015-04-23 22:06:27 +00:00
mozilla Revert "ES6: Number and Boolean prototype should be ordinary objects" 2015-04-13 16:21:00 +00:00
preparser Remove --harmony-scoping flag. 2015-03-13 15:15:57 +00:00
promises-aplus
test262 Revert of Revert of [es6] don't throw if argument is non-object (O.freeze, O.seal, O.preventExtensions) (patchset #1 id:1 of https://codereview.chromium.org/1103473003/) 2015-04-22 10:33:33 +00:00
test262-es6 Revert of Revert of [es6] don't throw if argument is non-object (O.freeze, O.seal, O.preventExtensions) (patchset #1 id:1 of https://codereview.chromium.org/1103473003/) 2015-04-22 10:33:33 +00:00
unittests [turbofan] Unify frame state inputs. 2015-04-23 09:04:19 +00:00
webkit [es6] do not add caller/arguments to ES6 function definitions 2015-04-09 22:40:28 +00:00