Go to file
Marja Hölttä d69159d52d [parser] Skipping inner funcs: fix related to aborting preparsing.
When skipping inner funcs is enabled, we also track variables for top level
funcs. Thus, we also declared the function name for the function scope, even
though it was the function scope for a function whose preparsing was
aborted. This lead into declaring the function name twice.

The fix is to declare the function name only in the success case.

The code was "wrong" before too, but this was never a problem, since variable
tracking and aborting preparsing were enabled for disjoint sets of
functions (aborting preparsing only for top-level, and variable tracking for
non-top-level).

BUG=v8:5516,chromium:774475

Change-Id: Ie6c321cc834cd946e8843f73916fa7dd75e9cd09
Reviewed-on: https://chromium-review.googlesource.com/720920
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: Marja Hölttä <marja@chromium.org>
Cr-Commit-Position: refs/heads/master@{#48592}
2017-10-16 13:31:49 +00:00
benchmarks Fix common misspellings 2017-08-02 09:35:28 +00:00
build_overrides Remove build_override for macOS min SDK and deployment target. 2017-07-14 18:24:44 +00:00
docs
gni Reland "[build] Switch windows default compilation to MSVS 2017" 2017-09-29 09:36:49 +00:00
gypfiles [test] Remove valgrind support 2017-10-11 07:41:33 +00:00
include fix compile error when use PersistentValueMap. 2017-10-13 10:23:57 +00:00
infra [build] Fix build configs for win-asan 2017-10-16 08:21:13 +00:00
samples [presubmit] Enable and fix "build/namespaces" linter check. 2017-09-04 11:24:26 +00:00
src [parser] Skipping inner funcs: fix related to aborting preparsing. 2017-10-16 13:31:49 +00:00
test [parser] Skipping inner funcs: fix related to aborting preparsing. 2017-10-16 13:31:49 +00:00
testing Use GTEST_LANG_CXX11 in V8 2016-07-25 13:06:42 +00:00
third_party Roll third_party/inspector_protocol to 8cb7a4f50ff7d5b1b7f2e5df0542dc577c88bdc3 2017-10-11 22:52:17 +00:00
tools [cleanup] [presubmit] Remove left-over comment 2017-10-16 11:37:52 +00:00
.clang-format [clang-format] Don't derive pointer alignment 2017-01-17 09:28:19 +00:00
.editorconfig Add .editorconfig 2017-07-28 13:39:24 +00:00
.git-blame-ignore-revs [build] Add DEPS formatting to hyper-blame 2017-10-09 14:08:45 +00:00
.gitignore [wasm] Add uma stat for wasm lazy throughput 2017-10-11 21:00:22 +00:00
.gn For building v8 using gn on aix_ppc64, linux_s390x and linux_ppc64(both LE and BE). 2017-05-12 01:35:09 +00:00
.ycm_extra_conf.py
AUTHORS fix compile error when use PersistentValueMap. 2017-10-13 10:23:57 +00:00
BUILD.gn [objects.h splitting] Move Code & related classes. 2017-10-13 14:22:11 +00:00
ChangeLog
CODE_OF_CONDUCT.md
codereview.settings Make Gerrit the default code review for V8 2017-06-30 17:37:37 +00:00
DEPS Update V8 DEPS. 2017-10-16 03:55:17 +00:00
LICENSE
LICENSE.fdlibm Add LICENSE.fdlibm for all the fdlibm imported sources. 2016-06-09 07:17:03 +00:00
LICENSE.strongtalk
LICENSE.v8
LICENSE.valgrind
Makefile [heap] Port concurrent marking flag to GYP. 2017-08-23 15:26:43 +00:00
Makefile.android [build] Fix d8-for-Android builds 2016-05-20 12:10:45 +00:00
OWNERS Add eholk and gdeepti to toplevel owners 2017-08-12 07:07:29 +00:00
PRESUBMIT.py [iwyu] Turn inclusion presubmit warning into and error. 2017-09-14 10:17:58 +00:00
README.md
snapshot_toolchain.gni MIPS[64]: Add support for big endian build using GN 2017-06-02 15:02:18 +00:00
WATCHLISTS [V8Tracing] Add lpy@ and fmeawad@ into watchlist for tracing/. 2017-05-22 19:40:17 +00:00

V8 JavaScript Engine

V8 is Google's open source JavaScript engine.

V8 implements ECMAScript as specified in ECMA-262.

V8 is written in C++ and is used in Google Chrome, the open source browser from Google.

V8 can run standalone, or can be embedded into any C++ application.

V8 Project page: https://github.com/v8/v8/wiki

Getting the Code

Checkout depot tools, and run

    fetch v8

This will checkout V8 into the directory v8 and fetch all of its dependencies. To stay up to date, run

    git pull origin
    gclient sync

For fetching all branches, add the following into your remote configuration in .git/config:

    fetch = +refs/branch-heads/*:refs/remotes/branch-heads/*
    fetch = +refs/tags/*:refs/tags/*

Contributing

Please follow the instructions mentioned on the V8 wiki.