AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity
d691fde360
v8/test
History
Sigurd Schneider d691fde360 Revert "Reland "[builtins] [turbofan] Refactor Float64Pow to use single implementation"" 
This reverts commit d7def9003d.

Reason for revert: Breaks UBSan:
https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20UBSan/4542

Besides undefined behavior, things were looking good!


Original change's description:
> Reland "[builtins] [turbofan] Refactor Float64Pow to use single implementation"
> 
> This is a reland of I968a08cef6a6d49350aa79185b2c6fb856d15f23
> 
> Original change's description:
> > [builtins] [turbofan] Refactor Float64Pow to use single implementation
> >
> > Remove platform-specific Float64Pow implementations and utils Pow in
> > favor of a base::ieee754::pow implementation.
> >
> > This unifies the implementation of pow for the compiler, wasm, and
> > runtime.
> >
> > Bug: v8:5848, v8:5086
> > Change-Id: I968a08cef6a6d49350aa79185b2c6fb856d15f23
> > Reviewed-on: https://chromium-review.googlesource.com/c/1403018
> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
> > Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
> > Reviewed-by: Georg Neis <neis@chromium.org>
> > Reviewed-by: Yang Guo <yangguo@chromium.org>
> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#59229}
> 
> Bug: v8:5848, v8:5086
> Change-Id: I92f22ae03adafd9ad042e8d4bb406cbd5b5fb51e
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_ubsan_rel_ng
> Reviewed-on: https://chromium-review.googlesource.com/c/1447854
> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
> Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
> Reviewed-by: Georg Neis <neis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#59411}

TBR=jkummerow@chromium.org,jarin@chromium.org,neis@chromium.org,jgruber@chromium.org,clemensh@chromium.org,bmeurer@chromium.org,me@gus.host

Change-Id: I65c4bbd3ab7aaa1c396d182467c5a1fe6a639df5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:5848, v8:5086
Cq-Include-Trybots: luci.chromium.try:linux_chromium_ubsan_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/c/1456107
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59419}
2019-02-06 15:49:46 +00:00
..
benchmarks Reland "Reland "[test] refactor testsuite configuration"" 2019-02-06 09:02:09 +00:00
cctest Constant field tracking for arrays. 2019-02-06 14:44:43 +00:00
common [wasm] Rename memory.drop and table.drop 2019-01-31 19:27:57 +00:00
debugger Reland "Reland "[test] refactor testsuite configuration"" 2019-02-06 09:02:09 +00:00
fuzzer Reland "Reland "[test] refactor testsuite configuration"" 2019-02-06 09:02:09 +00:00
inspector Reland "Reland "[test] refactor testsuite configuration"" 2019-02-06 09:02:09 +00:00
intl Reland "Reland "[test] refactor testsuite configuration"" 2019-02-06 09:02:09 +00:00
js-perf-test [test] add performance tests for String#startsWith 2019-01-17 08:23:06 +00:00
memory [snapshot] Remove the builtins snapshot 2018-10-31 10:18:28 +00:00
message Reland "Reland "[test] refactor testsuite configuration"" 2019-02-06 09:02:09 +00:00
mjsunit Revert "Reland "[builtins] [turbofan] Refactor Float64Pow to use single implementation"" 2019-02-06 15:49:46 +00:00
mkgrokdump Reland "Reland "[test] refactor testsuite configuration"" 2019-02-06 09:02:09 +00:00
mozilla Reland "Reland "[test] refactor testsuite configuration"" 2019-02-06 09:02:09 +00:00
preparser Reland "Reland "[test] refactor testsuite configuration"" 2019-02-06 09:02:09 +00:00
test262 Reland "Reland "[test] refactor testsuite configuration"" 2019-02-06 09:02:09 +00:00
torque [torque] add internal classes that map to FixedArray instances 2019-02-06 13:51:51 +00:00
unittests Revert "Reland "[builtins] [turbofan] Refactor Float64Pow to use single implementation"" 2019-02-06 15:49:46 +00:00
wasm-js Reland "Reland "[test] refactor testsuite configuration"" 2019-02-06 09:02:09 +00:00
wasm-spec-tests Reland "Reland "[test] refactor testsuite configuration"" 2019-02-06 09:02:09 +00:00
webkit Reland "Reland "[test] refactor testsuite configuration"" 2019-02-06 09:02:09 +00:00
BUILD.gn Reland "[wasm] Add a new wasm-js testsuite to run js-api tests" 2018-10-18 20:18:55 +00:00