fb6a094db5
This CL improves break locations for expressions like 'var a = <expr>'. Without CL we use <expr> position as break location for initialization statement, with this CL we use position of first character after '=' as position.
Benefits (see test for details):
- only one break in expressions which includes mix of property lookup and calls, e.g. var p = Promise.resolve().then(x => x * 2),
- removed redundant break location for expressions like: let { x, y } = { x: 1, y: 2}.
TBR=dgozman@chromium.org,rmcilroy@chromium.org,machenbach@chromium.org,marja@chromium.org,kozyatinskiy@chromium.org,devtools-reviews@chromium.org,v8-reviews@googlegroups.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: v8:5909
Change-Id: Ie84fa79afeed09e28cf8478ba610a0cfbfdfc294
Reviewed-on: https://chromium-review.googlesource.com/518116
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#45598}
83 lines
2.5 KiB
JavaScript
83 lines
2.5 KiB
JavaScript
// Copyright 2017 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
let {session, contextGroup, Protocol} =
|
|
InspectorTest.start('Tests breakable locations in for-of loops.');
|
|
|
|
let source = `
|
|
function testFunction() {
|
|
var obj = {a : 1};
|
|
var arr = [1];
|
|
var all = [];
|
|
for (var k in arr) { all.push(k); }
|
|
for (var k of arr) { all.push(k); }
|
|
for (var k in obj) { all.push(k); }
|
|
for (let k in arr) { all.push(k); }
|
|
for (let k of arr) { all.push(k); }
|
|
for (let k in obj) { all.push(k); }
|
|
|
|
var iterable = {
|
|
[Symbol.iterator]() {
|
|
return {
|
|
i: 0,
|
|
next() {
|
|
if (this.i < 1) {
|
|
return { value: this.i++, done: false };
|
|
}
|
|
return { value: undefined, done: true };
|
|
}
|
|
};
|
|
}
|
|
};
|
|
for (var k of iterable) { all.push(k); }
|
|
iterable.i = 0;
|
|
for (let k of iterable) { all.push(k); }
|
|
}
|
|
//# sourceURL=test.js`;
|
|
|
|
contextGroup.addScript(source);
|
|
session.setupScriptMap();
|
|
|
|
InspectorTest.runAsyncTestSuite([
|
|
async function testBreakLocations() {
|
|
Protocol.Debugger.enable();
|
|
let {params:{scriptId}} = await Protocol.Debugger.onceScriptParsed();
|
|
let {result:{locations}} = await Protocol.Debugger.getPossibleBreakpoints({
|
|
start: {lineNumber: 0, columnNumber : 0, scriptId}});
|
|
session.logBreakLocations(locations);
|
|
},
|
|
|
|
async function testStepInto() {
|
|
Protocol.Debugger.pause();
|
|
let fin = Protocol.Runtime.evaluate({
|
|
expression: 'testFunction()//# sourceURL=expr.js'}).then(() => false);
|
|
let result;
|
|
while (result = await Promise.race([fin, Protocol.Debugger.oncePaused()])) {
|
|
let {params:{callFrames}} = result;
|
|
session.logCallFrames(callFrames);
|
|
session.logSourceLocation(callFrames[0].location);
|
|
Protocol.Debugger.stepInto();
|
|
}
|
|
Protocol.Runtime.evaluate({expression: '42'});
|
|
await Protocol.Debugger.oncePaused();
|
|
await Protocol.Debugger.resume();
|
|
},
|
|
|
|
async function testStepIntoAfterBreakpoint() {
|
|
Protocol.Debugger.setBreakpointByUrl({lineNumber: 25, url: 'test.js'});
|
|
Protocol.Runtime.evaluate({
|
|
expression: 'testFunction()//# sourceURL=expr.js'});
|
|
await awaitPausedAndDump();
|
|
Protocol.Debugger.stepInto();
|
|
await awaitPausedAndDump();
|
|
await Protocol.Debugger.resume();
|
|
|
|
async function awaitPausedAndDump() {
|
|
let {params:{callFrames}} = await Protocol.Debugger.oncePaused();
|
|
session.logCallFrames(callFrames);
|
|
session.logSourceLocation(callFrames[0].location);
|
|
}
|
|
}
|
|
]);
|