Ng Zhi An d16eefe0f2 [wasm-simd] Canonicalize shuffles when creating TurboFan graph ... We currently canonicalize shuffles in the architecture specific instruction selector. This has the drawback that if we want to pattern match on nodes that have a shuffle as input, they need to individually canonicalize the shuffle. There can also be a subtle bug if we canonicalize the same shuffle node twice (see bug for details). This moves the canonicalization to "construction time", in wasm-compiler, when building the graph. As such, any pattern matches in instruction-selector will only need to deal with canonicalized shuffles. We introduce a new kind of parameter for shuffle nodes, ShuffleParameter, to store the 16 bytes plus a bool indicating if this is a swizzle. A swizzle essentially: inputs to the shuffle are the same or all indices only touch 1 input. We calculate this when canonicalizing, so store this bit of information inside of the node's parameter. We update the tests in x64 to handle special cases where, even though the node's inputs are not swapped (due to canonicalization), they need to be swapped for the specific instruction selected (e.g. palignr). The test data also contains canonicalized shuffles, so we have to manually canonicalize them. Bug: v8:11542 Change-Id: I4e78082267bd03d6caedf43d68d81ef3f5f364a8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2762420 Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#73495}		2021-03-17 22:27:13 +00:00
..
arm	Revert "Move branch inversion on ==0 into platform-agnostic reducer"	2020-03-25 16:47:48 +00:00
arm64	[wasm-simd] Canonicalize shuffles when creating TurboFan graph	2021-03-17 22:27:13 +00:00
backend	[frames] Add UnoptimizedFrame	2021-02-15 14:35:04 +00:00
ia32	[wasm-simd][ia32] Optimize integer splats of constant 0	2020-11-09 01:42:10 +00:00
mips	Move architecture dependent files	2019-05-28 14:02:15 +00:00
mips64	Move architecture dependent files	2019-05-28 14:02:15 +00:00
ppc	Adding myself to relevant OWNERS files.	2020-11-02 16:37:28 +00:00
regalloc	[Turboprop] Ensure constant operands are only used when allowed.	2021-02-12 20:40:36 +00:00
riscv64	Add RISC-V backend	2021-02-09 17:06:36 +00:00
s390	Move architecture dependent files	2019-05-28 14:02:15 +00:00
x64	[wasm-simd] Canonicalize shuffles when creating TurboFan graph	2021-03-17 22:27:13 +00:00
branch-elimination-unittest.cc	[compiler] Fix --trace-turbo-reduction in the presence of direct reads	2020-09-11 17:21:43 +00:00
bytecode-analysis-unittest.cc	[cleanup] Replace redundant BytecodeArrayIterator class	2021-02-24 13:54:53 +00:00
checkpoint-elimination-unittest.cc	[cleanup] Refactor compiler to use default members.	2018-09-17 12:12:21 +00:00
common-operator-reducer-unittest.cc	[compiler] Remove persistent handles as a broker parameter	2020-08-13 08:13:33 +00:00
common-operator-unittest.cc	[compiler] Fix typo in IfValueParameters operator==	2021-01-11 11:15:14 +00:00
compiler-test-utils.h
constant-folding-reducer-unittest.cc	[compiler] Fix --trace-turbo-reduction in the presence of direct reads	2020-09-11 17:21:43 +00:00
control-equivalence-unittest.cc	Move utility code to src/utils	2019-05-23 14:13:34 +00:00
control-flow-optimizer-unittest.cc	[turbofan] introduce a deterministic tick measurement and assert optimization doesn't take too long	2019-07-17 07:00:00 +00:00
csa-load-elimination-unittest.cc	[turbofan] Fix CsaLoadElimination for small types	2021-03-11 11:09:06 +00:00
dead-code-elimination-unittest.cc	[cleanup] Refactor compiler to use default members.	2018-09-17 12:12:21 +00:00
decompression-optimizer-unittest.cc	[compiler] Rename type BailoutId to BytecodeOffset	2021-01-20 13:03:41 +00:00
diamond-unittest.cc	[cleanup] [compiler] Fix (D)CHECK macros	2017-09-25 10:21:34 +00:00
effect-control-linearizer-unittest.cc	Reland "[turboprop] Add a slot for optimization marker in feedback vector"	2020-10-28 11:09:14 +00:00
frame-unittest.cc	Reland "Reland "Reland "[compiler][wasm] Align Frame slots to value size"""	2021-03-05 19:49:19 +00:00
graph-reducer-unittest.cc	[compiler] Fix --trace-turbo-reduction in the presence of direct reads	2020-09-11 17:21:43 +00:00
graph-reducer-unittest.h	[unittests] Convert to the new MOCK_METHOD macro.	2020-06-10 15:50:38 +00:00
graph-trimmer-unittest.cc
graph-unittest.cc	[frames] Add UnoptimizedFrame	2021-02-15 14:35:04 +00:00
graph-unittest.h	[turbofan] introduce a deterministic tick measurement and assert optimization doesn't take too long	2019-07-17 07:00:00 +00:00
int64-lowering-unittest.cc	[wasm] Use object operators in wasm compiler, enable optimizations	2021-03-08 14:35:25 +00:00
js-call-reducer-unittest.cc	[compiler] Fix --trace-turbo-reduction in the presence of direct reads	2020-09-11 17:21:43 +00:00
js-create-lowering-unittest.cc	[frames] Add UnoptimizedFrame	2021-02-15 14:35:04 +00:00
js-intrinsic-lowering-unittest.cc	[compiler] Fix --trace-turbo-reduction in the presence of direct reads	2020-09-11 17:21:43 +00:00
js-native-context-specialization-unittest.cc	Move number related files to src/numbers	2019-05-15 19:34:44 +00:00
js-operator-unittest.cc	[tests] Fix subobject-linkage error when building with GCC	2019-10-07 11:11:39 +00:00
js-typed-lowering-unittest.cc	[compiler] Fix --trace-turbo-reduction in the presence of direct reads	2020-09-11 17:21:43 +00:00
linkage-tail-call-unittest.cc	Reland "[codegen][frames] Generalize argument padding slot code"	2021-03-05 22:35:30 +00:00
load-elimination-unittest.cc	Retire PretenureFlag and use AllocationType everywhere.	2019-03-12 08:10:44 +00:00
loop-peeling-unittest.cc	[turbofan] Add MachineRepresentation argument to LoopExitValue	2020-12-16 16:27:50 +00:00
machine-operator-reducer-unittest.cc	[compiler] Silence NaNs in Float64Mod and Float64Atan2	2021-01-25 07:45:30 +00:00
machine-operator-unittest.cc	Reland "[compiler] Optionally apply an offset to stack checks"	2019-10-30 10:23:05 +00:00
node-cache-unittest.cc	[turbofan] use ZoneUnorderedMap for NodeCache	2020-03-05 13:00:34 +00:00
node-matchers-unittest.cc	[cleanup] Refactor compiler to use default members.	2018-09-17 12:12:21 +00:00
node-properties-unittest.cc	[zone-compr] Add kCompressGraphZone constant	2020-07-24 08:50:11 +00:00
node-test-utils.cc	[wasm] Use object operators in wasm compiler, enable optimizations	2021-03-08 14:35:25 +00:00
node-test-utils.h	[wasm] Use object operators in wasm compiler, enable optimizations	2021-03-08 14:35:25 +00:00
node-unittest.cc	[zone-compr] Add kCompressGraphZone constant	2020-07-24 08:50:11 +00:00
opcodes-unittest.cc	[compiler] Refactor opcode macro lists	2020-06-23 07:54:14 +00:00
persistent-unittest.cc	[ubsan] Fix numerical overflows in the compiler	2019-01-10 11:17:37 +00:00
redundancy-elimination-unittest.cc	Remove obsolete {Binary,Number}OperationHint::kSigned32	2020-11-24 11:12:10 +00:00
schedule-unittest.cc	Reland "[zone-compr] Introduce ZoneTypeTraits and ZoneCompression"	2020-07-31 11:43:08 +00:00
scheduler-rpo-unittest.cc	[cleanup] Refactor compiler to use default members.	2018-09-17 12:12:21 +00:00
scheduler-unittest.cc	[zone-compr] Add kCompressGraphZone constant	2020-07-24 08:50:11 +00:00
simplified-lowering-unittest.cc	Reland "[turboprop] Pass required parameters as value inputs to TierUpCheck node"	2020-10-28 18:18:36 +00:00
simplified-operator-reducer-unittest.cc	[turbofan] Reduce consecutive overflow addition with constants	2020-09-22 16:17:53 +00:00
simplified-operator-unittest.cc	[ptr-compr] Remove Compressed mentions from in the pipeline	2019-11-11 12:23:41 +00:00
state-values-utils-unittest.cc	[compiler] Optimize AddInputsToFrameStateDescriptor	2020-03-05 11:45:15 +00:00
typed-optimization-unittest.cc	[compiler] Fix --trace-turbo-reduction in the presence of direct reads	2020-09-11 17:21:43 +00:00
typer-unittest.cc	[compiler] Remove persistent handles as a broker parameter	2020-08-13 08:13:33 +00:00
value-numbering-reducer-unittest.cc	Reland "[zone-compr] Introduce ZoneTypeTraits and ZoneCompression"	2020-07-31 11:43:08 +00:00
zone-stats-unittest.cc	[zone] Cleanup zone allocations in src/compiler and tests, pt.3	2020-07-10 16:39:05 +00:00