1f28904b24
After this change, the functionality of the CodeStubAssembler should be sufficient to generate non-trivial stubs (e.g. the KeyedLoadIC) with control flow, variables and probing of internal meta data structures. Specifically this patch: * introduces a Label class, which allows stubs to construct graphs that don't have linear control graphs. * introduces a Variable class. Variables can be bound to Node* values at different points in a non-linear control flow graph. In conjunction with the Label machinery, the CodeStubAssembler ensures that Phi nodes are inserted at the "minimal" set of merge points. * adds Tail calling support to other Stubs and to any arbitrary code whose interface can be described by a CallInterfaceDescriptor. * provides new macros for accessing FixedArray elements that are optimized for use with Smi values. Review URL: https://codereview.chromium.org/1649723002 Cr-Commit-Position: refs/heads/master@{#33664}
253 lines
8.2 KiB
C++
253 lines
8.2 KiB
C++
// Copyright 2015 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "src/interface-descriptors.h"
|
|
#include "src/isolate.h"
|
|
#include "test/cctest/compiler/function-tester.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
namespace compiler {
|
|
|
|
|
|
class CodeStubAssemblerTester : public CodeStubAssembler {
|
|
public:
|
|
CodeStubAssemblerTester(Isolate* isolate,
|
|
const CallInterfaceDescriptor& descriptor)
|
|
: CodeStubAssembler(isolate, isolate->runtime_zone(), descriptor,
|
|
Code::ComputeFlags(Code::STUB), "test"),
|
|
scope_(isolate) {}
|
|
|
|
private:
|
|
HandleScope scope_;
|
|
LocalContext context_;
|
|
};
|
|
|
|
|
|
TEST(SimpleSmiReturn) {
|
|
Isolate* isolate(CcTest::InitIsolateOnce());
|
|
VoidDescriptor descriptor(isolate);
|
|
CodeStubAssemblerTester m(isolate, descriptor);
|
|
m.Return(m.SmiTag(m.Int32Constant(37)));
|
|
Handle<Code> code = m.GenerateCode();
|
|
FunctionTester ft(descriptor, code);
|
|
MaybeHandle<Object> result = ft.Call();
|
|
CHECK_EQ(37, Handle<Smi>::cast(result.ToHandleChecked())->value());
|
|
}
|
|
|
|
|
|
TEST(SimpleIntPtrReturn) {
|
|
Isolate* isolate(CcTest::InitIsolateOnce());
|
|
VoidDescriptor descriptor(isolate);
|
|
CodeStubAssemblerTester m(isolate, descriptor);
|
|
int test;
|
|
m.Return(m.IntPtrConstant(reinterpret_cast<intptr_t>(&test)));
|
|
Handle<Code> code = m.GenerateCode();
|
|
FunctionTester ft(descriptor, code);
|
|
MaybeHandle<Object> result = ft.Call();
|
|
CHECK_EQ(reinterpret_cast<intptr_t>(&test),
|
|
reinterpret_cast<intptr_t>(*result.ToHandleChecked()));
|
|
}
|
|
|
|
|
|
TEST(SimpleDoubleReturn) {
|
|
Isolate* isolate(CcTest::InitIsolateOnce());
|
|
VoidDescriptor descriptor(isolate);
|
|
CodeStubAssemblerTester m(isolate, descriptor);
|
|
m.Return(m.NumberConstant(0.5));
|
|
Handle<Code> code = m.GenerateCode();
|
|
FunctionTester ft(descriptor, code);
|
|
MaybeHandle<Object> result = ft.Call();
|
|
CHECK_EQ(0.5, Handle<HeapNumber>::cast(result.ToHandleChecked())->value());
|
|
}
|
|
|
|
|
|
TEST(SimpleCallRuntime1Arg) {
|
|
Isolate* isolate(CcTest::InitIsolateOnce());
|
|
VoidDescriptor descriptor(isolate);
|
|
CodeStubAssemblerTester m(isolate, descriptor);
|
|
Node* context = m.HeapConstant(Handle<Context>(isolate->native_context()));
|
|
Node* b = m.SmiTag(m.Int32Constant(256));
|
|
m.Return(m.CallRuntime(Runtime::kMathSqrt, context, b));
|
|
Handle<Code> code = m.GenerateCode();
|
|
FunctionTester ft(descriptor, code);
|
|
MaybeHandle<Object> result = ft.Call();
|
|
CHECK_EQ(16, Handle<Smi>::cast(result.ToHandleChecked())->value());
|
|
}
|
|
|
|
|
|
TEST(SimpleTailCallRuntime1Arg) {
|
|
Isolate* isolate(CcTest::InitIsolateOnce());
|
|
VoidDescriptor descriptor(isolate);
|
|
CodeStubAssemblerTester m(isolate, descriptor);
|
|
Node* context = m.HeapConstant(Handle<Context>(isolate->native_context()));
|
|
Node* b = m.SmiTag(m.Int32Constant(256));
|
|
m.TailCallRuntime(Runtime::kMathSqrt, context, b);
|
|
Handle<Code> code = m.GenerateCode();
|
|
FunctionTester ft(descriptor, code);
|
|
MaybeHandle<Object> result = ft.Call();
|
|
CHECK_EQ(16, Handle<Smi>::cast(result.ToHandleChecked())->value());
|
|
}
|
|
|
|
|
|
TEST(SimpleCallRuntime2Arg) {
|
|
Isolate* isolate(CcTest::InitIsolateOnce());
|
|
VoidDescriptor descriptor(isolate);
|
|
CodeStubAssemblerTester m(isolate, descriptor);
|
|
Node* context = m.HeapConstant(Handle<Context>(isolate->native_context()));
|
|
Node* a = m.SmiTag(m.Int32Constant(2));
|
|
Node* b = m.SmiTag(m.Int32Constant(4));
|
|
m.Return(m.CallRuntime(Runtime::kMathPow, context, a, b));
|
|
Handle<Code> code = m.GenerateCode();
|
|
FunctionTester ft(descriptor, code);
|
|
MaybeHandle<Object> result = ft.Call();
|
|
CHECK_EQ(16, Handle<Smi>::cast(result.ToHandleChecked())->value());
|
|
}
|
|
|
|
|
|
TEST(SimpleTailCallRuntime2Arg) {
|
|
Isolate* isolate(CcTest::InitIsolateOnce());
|
|
VoidDescriptor descriptor(isolate);
|
|
CodeStubAssemblerTester m(isolate, descriptor);
|
|
Node* context = m.HeapConstant(Handle<Context>(isolate->native_context()));
|
|
Node* a = m.SmiTag(m.Int32Constant(2));
|
|
Node* b = m.SmiTag(m.Int32Constant(4));
|
|
m.TailCallRuntime(Runtime::kMathPow, context, a, b);
|
|
Handle<Code> code = m.GenerateCode();
|
|
FunctionTester ft(descriptor, code);
|
|
MaybeHandle<Object> result = ft.Call();
|
|
CHECK_EQ(16, Handle<Smi>::cast(result.ToHandleChecked())->value());
|
|
}
|
|
|
|
TEST(VariableMerge1) {
|
|
Isolate* isolate(CcTest::InitIsolateOnce());
|
|
VoidDescriptor descriptor(isolate);
|
|
CodeStubAssemblerTester m(isolate, descriptor);
|
|
CodeStubAssembler::Variable var1(&m, MachineRepresentation::kTagged);
|
|
CodeStubAssembler::Label l1(&m), l2(&m), merge(&m);
|
|
Node* temp = m.Int32Constant(0);
|
|
var1.Bind(temp);
|
|
m.Branch(m.Int32Constant(1), &l1, &l2);
|
|
m.Bind(&l1);
|
|
CHECK_EQ(var1.value(), temp);
|
|
m.Goto(&merge);
|
|
m.Bind(&l2);
|
|
CHECK_EQ(var1.value(), temp);
|
|
m.Goto(&merge);
|
|
m.Bind(&merge);
|
|
CHECK_EQ(var1.value(), temp);
|
|
}
|
|
|
|
TEST(VariableMerge2) {
|
|
Isolate* isolate(CcTest::InitIsolateOnce());
|
|
VoidDescriptor descriptor(isolate);
|
|
CodeStubAssemblerTester m(isolate, descriptor);
|
|
CodeStubAssembler::Variable var1(&m, MachineRepresentation::kTagged);
|
|
CodeStubAssembler::Label l1(&m), l2(&m), merge(&m);
|
|
Node* temp = m.Int32Constant(0);
|
|
var1.Bind(temp);
|
|
m.Branch(m.Int32Constant(1), &l1, &l2);
|
|
m.Bind(&l1);
|
|
CHECK_EQ(var1.value(), temp);
|
|
m.Goto(&merge);
|
|
m.Bind(&l2);
|
|
Node* temp2 = m.Int32Constant(2);
|
|
var1.Bind(temp2);
|
|
CHECK_EQ(var1.value(), temp2);
|
|
m.Goto(&merge);
|
|
m.Bind(&merge);
|
|
CHECK_NE(var1.value(), temp);
|
|
}
|
|
|
|
TEST(VariableMerge3) {
|
|
Isolate* isolate(CcTest::InitIsolateOnce());
|
|
VoidDescriptor descriptor(isolate);
|
|
CodeStubAssemblerTester m(isolate, descriptor);
|
|
CodeStubAssembler::Variable var1(&m, MachineRepresentation::kTagged);
|
|
CodeStubAssembler::Variable var2(&m, MachineRepresentation::kTagged);
|
|
CodeStubAssembler::Label l1(&m), l2(&m), merge(&m);
|
|
Node* temp = m.Int32Constant(0);
|
|
var1.Bind(temp);
|
|
var2.Bind(temp);
|
|
m.Branch(m.Int32Constant(1), &l1, &l2);
|
|
m.Bind(&l1);
|
|
CHECK_EQ(var1.value(), temp);
|
|
m.Goto(&merge);
|
|
m.Bind(&l2);
|
|
Node* temp2 = m.Int32Constant(2);
|
|
var1.Bind(temp2);
|
|
CHECK_EQ(var1.value(), temp2);
|
|
m.Goto(&merge);
|
|
m.Bind(&merge);
|
|
CHECK_NE(var1.value(), temp);
|
|
CHECK_NE(var1.value(), temp2);
|
|
CHECK_EQ(var2.value(), temp);
|
|
}
|
|
|
|
TEST(VariableMergeBindFirst) {
|
|
Isolate* isolate(CcTest::InitIsolateOnce());
|
|
VoidDescriptor descriptor(isolate);
|
|
CodeStubAssemblerTester m(isolate, descriptor);
|
|
CodeStubAssembler::Variable var1(&m, MachineRepresentation::kTagged);
|
|
CodeStubAssembler::Label l1(&m), l2(&m), merge(&m, &var1), end(&m);
|
|
Node* temp = m.Int32Constant(0);
|
|
var1.Bind(temp);
|
|
m.Branch(m.Int32Constant(1), &l1, &l2);
|
|
m.Bind(&l1);
|
|
CHECK_EQ(var1.value(), temp);
|
|
m.Goto(&merge);
|
|
m.Bind(&merge);
|
|
CHECK(var1.value() != temp);
|
|
CHECK(var1.value() != nullptr);
|
|
m.Goto(&end);
|
|
m.Bind(&l2);
|
|
Node* temp2 = m.Int32Constant(2);
|
|
var1.Bind(temp2);
|
|
CHECK_EQ(var1.value(), temp2);
|
|
m.Goto(&merge);
|
|
m.Bind(&end);
|
|
CHECK(var1.value() != temp);
|
|
CHECK(var1.value() != nullptr);
|
|
}
|
|
|
|
TEST(VariableMergeSwitch) {
|
|
Isolate* isolate(CcTest::InitIsolateOnce());
|
|
VoidDescriptor descriptor(isolate);
|
|
CodeStubAssemblerTester m(isolate, descriptor);
|
|
CodeStubAssembler::Variable var1(&m, MachineRepresentation::kTagged);
|
|
CodeStubAssembler::Label l1(&m), l2(&m), default_label(&m);
|
|
CodeStubAssembler::Label* labels[] = {&l1, &l2};
|
|
int32_t values[] = {1, 2};
|
|
Node* temp = m.Int32Constant(0);
|
|
var1.Bind(temp);
|
|
m.Switch(m.Int32Constant(2), &default_label, values, labels, 2);
|
|
m.Bind(&l1);
|
|
DCHECK_EQ(temp, var1.value());
|
|
m.Return(temp);
|
|
m.Bind(&l2);
|
|
DCHECK_EQ(temp, var1.value());
|
|
m.Return(temp);
|
|
m.Bind(&default_label);
|
|
DCHECK_EQ(temp, var1.value());
|
|
m.Return(temp);
|
|
}
|
|
|
|
TEST(FixedArrayAccessSmiIndex) {
|
|
Isolate* isolate(CcTest::InitIsolateOnce());
|
|
VoidDescriptor descriptor(isolate);
|
|
CodeStubAssemblerTester m(isolate, descriptor);
|
|
Handle<FixedArray> array = isolate->factory()->NewFixedArray(5);
|
|
array->set(4, Smi::FromInt(733));
|
|
m.Return(m.LoadFixedArrayElementSmiIndex(m.HeapConstant(array),
|
|
m.SmiTag(m.Int32Constant(4))));
|
|
Handle<Code> code = m.GenerateCode();
|
|
FunctionTester ft(descriptor, code);
|
|
MaybeHandle<Object> result = ft.Call();
|
|
CHECK_EQ(733, Handle<Smi>::cast(result.ToHandleChecked())->value());
|
|
}
|
|
|
|
} // namespace compiler
|
|
} // namespace internal
|
|
} // namespace v8
|