v8/test
Clemens Hammacher daa2667990 Remove FixedArray::GetValueChecked
This method is rarely used, and has several problems:
1) It CHECKs that the value is not undefined, then creates a
   {Handle<T>} which again DCHECKs that the value is of type {T}.
2) It is called on a raw {FixedArray} but returns a handle.
3) It is often used when no handle is actually needed, adding
   unnecessary overhead.
4) It adds complexity and hides actual checks and handlification.

This CL removes that method, replacing some uses by explicit CHECKs (in
tests) and relying on the DCHECKs in the casts otherwise.

R=mstarzinger@chromium.org

Bug: v8:9183
Change-Id: I90ff59e8b78c909a9a207029d8cc9ab16c0c7b56
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1621939
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#61710}
2019-05-21 17:50:21 +00:00
..
benchmarks [test] Skip flaky test on predictable mode 2019-05-07 13:57:18 +00:00
cctest Remove FixedArray::GetValueChecked 2019-05-21 17:50:21 +00:00
common Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
debugger Revert "[test] Skip debugger tests failing with JSON parsing" 2019-05-20 13:58:05 +00:00
fuzzer Move code generation related files to src/codegen 2019-05-21 10:33:39 +00:00
inspector [coverage] Enable optimizations in block coverage modes 2019-05-16 14:39:19 +00:00
intl [Intl] Intl.NumberFormat Unified API Proposal 2019-05-21 17:23:21 +00:00
js-perf-test [benchmarks] Move Array slice benchmarks to js-perf-test 2019-05-20 09:05:52 +00:00
memory [perf] Refactor the Memory benchmark to use d8 2019-05-06 15:10:57 +00:00
message Reland "[stack-trace] Include API functions in Error.stack stack trace" 2019-05-21 10:40:30 +00:00
mjsunit [runtime] Make sure we don't inplace update None to Double 2019-05-21 15:17:27 +00:00
mkgrokdump [roheap] Switch to ReadOnlyHeapIterator in mkgrokdump 2019-05-21 17:16:21 +00:00
mozilla Reland "[test] Remove longer timeout on bots" 2019-05-02 13:04:29 +00:00
preparser [test] Don't test jitless without embedded-builtins 2019-02-26 14:33:01 +00:00
test262 [Intl] Intl.NumberFormat Unified API Proposal 2019-05-21 17:23:21 +00:00
torque Add StaticAssert in Torque 2019-05-21 15:39:57 +00:00
unittests [torque] More flexibel and uniform error reporting 2019-05-21 13:26:08 +00:00
wasm-js [testrunner] handle timeout param in file 2019-02-27 17:49:17 +00:00
wasm-spec-tests Clean up infra owners 2019-05-15 11:18:43 +00:00
webkit [test] Stress wasm code gc in "stress_background_compile" 2019-05-02 09:56:05 +00:00
BUILD.gn [tools] Implement confidence-based number of runs 2019-05-09 09:42:28 +00:00
OWNERS Clean up infra owners 2019-05-15 11:18:43 +00:00